From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE0BC33C8C for ; Tue, 7 Jan 2020 17:08:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B5592087F for ; Tue, 7 Jan 2020 17:08:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B5592087F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9DBBE6E82C; Tue, 7 Jan 2020 17:08:39 +0000 (UTC) Received: from mout.kundenserver.de (mout.kundenserver.de [212.227.126.135]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC9E86E82C for ; Tue, 7 Jan 2020 17:08:38 +0000 (UTC) Received: from mail-qt1-f176.google.com ([209.85.160.176]) by mrelayeu.kundenserver.de (mreue012 [212.227.15.129]) with ESMTPSA (Nemesis) id 1N4eOd-1jo5yt39WR-011iUd; Tue, 07 Jan 2020 18:08:36 +0100 Received: by mail-qt1-f176.google.com with SMTP id e12so383065qto.2; Tue, 07 Jan 2020 09:08:36 -0800 (PST) X-Gm-Message-State: APjAAAXqTVI9wmEOoULoNlRQy3R9GNmCICUVYlUn8yBG7qDMh+EO8x9j mcjhreC9V3O3I+qznkNXp9QBMZed/SfwiFv6ZzI= X-Google-Smtp-Source: APXvYqzRk52Ew2lmsQMfvghk3ylFHcEIR88yL70qbdC0HVK9etbYRWgu7fgyXH4+189J3IyWZY+dkJGnvq1XjVlLM+A= X-Received: by 2002:a05:620a:a5b:: with SMTP id j27mr335658qka.286.1578416914895; Tue, 07 Jan 2020 09:08:34 -0800 (PST) MIME-Version: 1.0 References: <1578415992-24054-1-git-send-email-krzk@kernel.org> <1578415992-24054-6-git-send-email-krzk@kernel.org> In-Reply-To: <1578415992-24054-6-git-send-email-krzk@kernel.org> From: Arnd Bergmann Date: Tue, 7 Jan 2020 18:08:18 +0100 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFT 03/13] sh: Constify ioreadX() iomem argument (as in generic implementation) To: Krzysztof Kozlowski X-Provags-ID: V03:K1:IDMrLgC3H0ekmK6SwU9PMUPDAlZ6fljKTY5XMWA8Myz/jUHSKWE pXwUQZK18iHBuQPyaE7xSxkyKwdHREvojqcA9MEODrB/MbXHbg85sr+aRj/zFD4vz53ck5J FWTz9ZovYLhMwd21BkrUqaYI4DcqD19BcLadoJ45YmK9GH0tK/vVTscAqoPrzAkd9yBShIg t6XFKKvd4xI7+zETbAxkg== X-UI-Out-Filterresults: notjunk:1;V03:K0:mR/c4lj8xd8=:Ncy4Vv6lgUVoMBjg+pvFIx rvJhbWimU8pv0OWpqelzbkmfEb8GypCJZVwEQcflUfgsn6poAN5ltQw4UWr1VLZajhpIfQLgt 26L4BzxOuzUX4pP6vhS+C3p2PSTxspu6i7I/cYPbkRMZWNv/+vgQsX1BQjy38+0RCee3EXZaJ 2sxAqgf6yCLCcgUjC5FyttUdPSIALicyPBGq/e7bhnht1cCuunP9ucOrsitSn3nVdqlBv+COd 2ByLRWl41vMPrv+cJ5h31jQzl/A42B1qpnJ72AGbrvoCnUIb7Bv8uaOo9KxxEc+hjH0tBOuYS VFfWu4/D89snYQygPGIxajO63Wvz11lIQAEJG4WpMxYQskqVJCx6xHCh8D6j9slewTUzDLRf8 7oxrztwudLzhy96QvSgL4fM2OV9TtgFkFnOkbylRp96emFjx0RQQ+LrhBqCfRyD1VZfP5upDY NRkRahONsaah53v8o2hVjtu84pvXT01GIiX2dplWboz+69Ioy+s3TII6HW45szsuQAk12qtlJ LSoj4lAe+YNVVXGu8JPwaO2ifPwPFAion7NNO9OrHVAGE4LgYYEJBCroNz7gZ5g5sTL12LSp6 OjQfbRMTYYoca6xEs2feADrOk1g3W6gGQLw4rjOkouINhi139FUtNOvIWFJTxG+u3OAECiKiF qGi3PpKfl3TqvWgZbjmDi/C/ZWeNh7uWEPt7dH03aI7tpaJ3C0MxSP3GBCXHWvvxbDchHWu03 v8IoJImYtPj3XcvdzpSIGcnq1ufIPHh4RUBqSwUPBpOF9jdUD8gTXhSvSXqIbRoDQBap6NurC oqUrxImD958kzip88Y8lw505r46OEbOfAfphmQ0plTPE+bNrBunzX3K9s5CnNjYfmO/Q4UPhs 60QT3OGoJfOmuFxbqqJw== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rich Felker , Jiri Slaby , "Michael S. Tsirkin" , David Airlie , Jason Wang , dri-devel , virtualization@lists.linux-foundation.org, "James E.J. Bottomley" , Networking , Paul Mackerras , linux-arch , Dave Jiang , Yoshinori Sato , Michael Ellerman , Helge Deller , Linux-sh list , Alexey Brodkin , Geert Uytterhoeven , Ben Skeggs , ML nouveau , Dave Airlie , Matt Turner , "open list:SYNOPSYS ARC ARCHITECTURE" , Nick Kossifidis , Allen Hubbe , alpha , Ivan Kokshaysky , Thomas Gleixner , Mauro Carvalho Chehab , Kalle Valo , Richard Henderson , Parisc List , Vineet Gupta , linux-wireless , "linux-kernel@vger.kernel.org" , Luis Chamberlain , Jon Mason , linux-ntb@googlegroups.com, Andrew Morton , Linux Media Mailing List , linuxppc-dev , "David S. Miller" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jan 7, 2020 at 5:54 PM Krzysztof Kozlowski wrote: > > The ioreadX() helpers have inconsistent interface. On some architectures > void *__iomem address argument is a pointer to const, on some not. > > Implementations of ioreadX() do not modify the memory under the address > so they can be converted to a "const" version for const-safety and > consistency among architectures. > > Signed-off-by: Krzysztof Kozlowski The patch looks good, but I think this has to be done together with the powerpc version and the header that declares the function, for bisectibility. Arnd _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel