From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D7CFC433DF for ; Thu, 28 May 2020 09:09:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1330E20B80 for ; Thu, 28 May 2020 09:09:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1330E20B80 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arndb.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 723A16E0F8; Thu, 28 May 2020 09:09:34 +0000 (UTC) Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id 15D336E0F8 for ; Thu, 28 May 2020 09:09:32 +0000 (UTC) Received: from mail-qt1-f169.google.com ([209.85.160.169]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.145]) with ESMTPSA (Nemesis) id 1MGhds-1jqpTM4Bfu-00Do1Y; Thu, 28 May 2020 11:09:31 +0200 Received: by mail-qt1-f169.google.com with SMTP id j32so6687511qte.10; Thu, 28 May 2020 02:09:29 -0700 (PDT) X-Gm-Message-State: AOAM531ZckDf+1kJ/gxkWCd2TbySgD1KgU8746k9/qwuKp2dSFw6u495 +rBBFiqHpW7c+bqtM9renkzbODeqTnOH1G/ZiH8= X-Google-Smtp-Source: ABdhPJw0lPr/TwhrVNC3iy5YtxH6Hjy8bzmX2rAe1KGmP7eYz/oL6ngiwKPu38ETWEqiMphjY7bZ3Eseev3rSciH8pY= X-Received: by 2002:ac8:6a09:: with SMTP id t9mr2005129qtr.7.1590656968528; Thu, 28 May 2020 02:09:28 -0700 (PDT) MIME-Version: 1.0 References: <20200527134254.854672-1-arnd@arndb.de> In-Reply-To: From: Arnd Bergmann Date: Thu, 28 May 2020 11:09:12 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [Nouveau] [PATCH] nouveau: add fbdev dependency To: Dave Airlie X-Provags-ID: V03:K1:+m3ukmoA1ks/niOL9hBvbGQ8a1cq/CDwTe+9K4T9isRbNoC9Nnn i0dqCCiverb0ay5guh+7xAc+JPFc3i3OHyBO/pG1Hb4t3YuHAC8hu6knV9gqL6irC957St2 Fxk5tY24hlWYJys6kyXJxTI5Ci95Hog1DR6CjScN/Tff2O+KPK/0uozYdvc3bHGIEm7WP8p d1Ph0cuTZEarP2cuVpHeg== X-UI-Out-Filterresults: notjunk:1;V03:K0:C8bldEvzp0Y=:ln1mGADWnb4CxUIUhBSIIB LZHmR/nWtSf4nNwXq1QTCyRDBlDn9xTUGHeWIdGTmZr7niclwdR9zUjXR0P5DPou9EPNRWRqt mjjfl2Eguv9OxQtI04HIrrdJP2onZfuY8BLe73XwxsroDfsRUQIHtaxx95stZaZnKsANkPii/ ImbbXtiePqEUtowEQMC9ntk4k0deUjJVqLazjyRsPOOtA1YSC9fpJMls4WuwyqSJwzEfBWpI1 R1b6GtseEdjtZAX8NVpgBu+3XLKW2mIYgVeChIUeDEjz2h7O2SpU0r7zK4xLq1r3f/shXPssk BDXI403+CuSDPpuYGrMIsH9LmIqhB9gkgva9K+da6pYYsc27f5cNps6BoWbmLDUS2NRVniM6e y10uO3G5xyAfiBXiiNm7ggH2t0zN51/Dak1nf5J2plH2tQXFBZgOOFqBGMyHP3SShs+tWGRQp V4XFmePP6lWcXOHCBScJKunALzcjHNsEt8JgawVm9gOy2/GBc+SQJ97I/azv0RpzIzmqB+EhF So633hGuHTulJgLN11uL1P2Hg6ykvNTley3UhReTorONgaEyMPGhZuRK7+wxLN3l8sYMLvepV I/BIZ178MKVU+5QH31wrCQOKFuH37yPQ9Io8QeCgDndeO+XPWyB5cSBl9FnMZt1cW0AtWCDQu osu8K3QmmOSWYhwcw+4kq2IMI/9YSz9pzBEIzrWaulKOKCRpve9RS3bhlwvU6wWSGB85VNDRk /HHmQh0uWHxsU2y/JNWcigv1rX5sutcwZYSeMXeVf3sT1XVf+6jEFw0ndruhVBdttMq+N+s7o EEG8eKVS82n0t3p7pwuwy5eqWuxiDmJJ0P0hbqrtaIh/zsJo0M= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , nouveau , LKML , dri-devel , Ben Skeggs Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, May 28, 2020 at 7:37 AM Dave Airlie wrote: > > On Thu, 28 May 2020 at 00:36, Arnd Bergmann wrote: > > > > On Wed, May 27, 2020 at 4:05 PM Ilia Mirkin wrote: > > > > > > Isn't this already fixed by > > > > > > https://cgit.freedesktop.org/drm/drm/commit/?id=7dbbdd37f2ae7dd4175ba3f86f4335c463b18403 > > > > Ok, I see that fixes the link error, but I when I created my fix, that did > > not seem like the correct solution because it reverts part of the original > > patch without reverting the rest of it. Unfortunately there was no > > changelog text in the first patch to explain why this is safe. > > No it doesn't, I think you missed the pci in API name. > > The initial behaviour doesn't use the pci version of the API, the > replacement did, and the fix used the drm wrapper around the pci one. > > So this patch isn't necessary now that I've fixed it the other way, Ok, got it, thanks for explaining! Arnd _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel