From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qiang Yu Subject: Re: [PATCH v3 2/2] drm/lima: driver for ARM Mali4xx GPUs Date: Wed, 6 Mar 2019 10:01:22 +0800 Message-ID: References: <20190227134124.28602-1-yuq825@gmail.com> <87imwx5b2w.fsf@anholt.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <87imwx5b2w.fsf@anholt.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Eric Anholt Cc: Marek Vasut , lima@lists.freedesktop.org, Andreas Baierl , Maxime Ripard , =?UTF-8?Q?Christian_K=C3=B6nig?= , Neil Armstrong , dri-devel , Vasily Khoruzhick , David Airlie , Simon Shields , Sean Paul , Erico Nunes List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBNYXIgNiwgMjAxOSBhdCA0OjE4IEFNIEVyaWMgQW5ob2x0IDxlcmljQGFuaG9sdC5u ZXQ+IHdyb3RlOgo+Cj4gUm9iIEhlcnJpbmcgPHJvYmhAa2VybmVsLm9yZz4gd3JpdGVzOgo+Cj4g PiBPbiBGcmksIE1hciAxLCAyMDE5IGF0IDExOjIzIFBNIFFpYW5nIFl1IDx5dXE4MjVAZ21haWwu Y29tPiB3cm90ZToKPiA+Pgo+ID4+ID4gPiArc3RhdGljIHN0cnVjdCBsaW1hX2ZlbmNlICpsaW1h X2ZlbmNlX2NyZWF0ZShzdHJ1Y3QgbGltYV9zY2hlZF9waXBlICpwaXBlKQo+ID4+ID4gPiArewo+ ID4+ID4gPiArICAgICAgIHN0cnVjdCBsaW1hX2ZlbmNlICpmZW5jZTsKPiA+PiA+ID4gKwo+ID4+ ID4gPiArICAgICAgIGZlbmNlID0ga21lbV9jYWNoZV96YWxsb2MobGltYV9mZW5jZV9zbGFiLCBH RlBfS0VSTkVMKTsKPiA+PiA+Cj4gPj4gPiBPdXQgb2YgY3VyaW9zaXR5LCB3aGF0IGlzIHRoZSBi ZW5lZml0IG9mIHVzaW5nIGEgc2VwYXJhdGUgc2xhYiBoZXJlPwo+ID4+ID4gSWYgdGhpcyBpcyBi ZW5lZmljaWFsLCB0aGVuIG90aGVyIGRyaXZlcnMgc2hvdWxkIGRvIHRoaXMgdG9vIGFuZCBpdAo+ ID4+ID4gc2hvdWxkIGJlIGNvbW1vbi4gT3RoZXJ3aXNlLCBpdCBhZGRzIHNvbWUgY29tcGxleGl0 eS4KPiA+Pgo+ID4+IGZlbmNlIGlzIHByZXR0eSBmcmVxdWVudGx5IGFsbG9jIGZyZWUgc3RydWN0 LCBzbyBtYWtlIGl0IGEgc2xhYi4gQW5kIGl0J3MgdXNlZAo+ID4+IGluIGdldC9wdXQgcGF0dGVy biwgc28gbWF5IGxpdmUgbG9uZ2VyIHRoYW4gZW1iZWRkZWQgc3RydWN0LiBUaGlzIGlzIHJlZmVy ZW5jZWQKPiA+PiBmcm9tIGFtZGdwdSBkcml2ZXIuCj4gPj4KPiA+PiA+Cj4gPj4gPiBBbmQgbWF5 YmUgdGhlIHNsYWIgc2hvdWxkIGJlIGluaXRpYWx6ZWQgaW4gcHJvYmUgcmF0aGVyIHRoYW4gbW9k dWxlX2luaXQuCj4gPj4gPgo+ID4+IEVpdGhlciB3YXkgaXMgT0suIEJ1dCBsaXZlIGluIG1vZHVs ZSBpbml0IGlzIGVhc2llciBub3QgdG8gaW5pdCB0d2ljZQo+ID4+IGZvciB0d28gZGV2aWNlcy4K PiA+Cj4gPiBUcnVlLCBidXQgSSB3YXMgdGhpbmtpbmcgbW9yZSBhYm91dCBpbml0aWFsaXppbmcg aXQgZm9yIDAgZGV2aWNlcwo+ID4gd2hpY2ggY2FuIGJlIGNvbW1vbiBpZiBidWlsdC1pbiBvbiBh IG11bHRpLXBsYXRmb3JtIGtlcm5lbC4KCkkgdGhpbmsgaXQncyBtb3JlIGNvbW1vbiB0byBidWls ZCB0aGlzIGRyaXZlciB0byBhIGxvYWRhYmxlIG1vZHVsZS4KQnV0IHlvdXIgY29uY2VybiBtYWtl IHNlbnNlIGZvciBidWlsZCBpbiBjYXNlLCBJJ2xsIG1vdmUgdGhpcyB0bwpwcm9iZS4KCj4gPgo+ ID4+ID4gPiAraW50IGxpbWFfdm1fYm9fYWRkKHN0cnVjdCBsaW1hX3ZtICp2bSwgc3RydWN0IGxp bWFfYm8gKmJvLCBib29sIGNyZWF0ZSkKPiA+PiA+ID4gK3sKPiA+PiA+ID4gKyAgICAgICBzdHJ1 Y3QgbGltYV9ib192YSAqYm9fdmE7Cj4gPj4gPiA+ICsgICAgICAgaW50IGVycjsKPiA+PiA+ID4g Kwo+ID4+ID4gPiArICAgICAgIG11dGV4X2xvY2soJmJvLT5sb2NrKTsKPiA+PiA+ID4gKwo+ID4+ ID4gPiArICAgICAgIGJvX3ZhID0gbGltYV92bV9ib19maW5kKHZtLCBibyk7Cj4gPj4gPiA+ICsg ICAgICAgaWYgKGJvX3ZhKSB7Cj4gPj4gPiA+ICsgICAgICAgICAgICAgICBib192YS0+cmVmX2Nv dW50Kys7Cj4gPj4gPiA+ICsgICAgICAgICAgICAgICBtdXRleF91bmxvY2soJmJvLT5sb2NrKTsK PiA+PiA+ID4gKyAgICAgICAgICAgICAgIHJldHVybiAwOwo+ID4+ID4gPiArICAgICAgIH0KPiA+ PiA+ID4gKwo+ID4+ID4gPiArICAgICAgIC8qIHNob3VsZCBub3QgY3JlYXRlIG5ldyBib192YSBp ZiBub3QgYXNrZWQgYnkgY2FsbGVyICovCj4gPj4gPiA+ICsgICAgICAgaWYgKCFjcmVhdGUpIHsK PiA+PiA+ID4gKyAgICAgICAgICAgICAgIG11dGV4X3VubG9jaygmYm8tPmxvY2spOwo+ID4+ID4g PiArICAgICAgICAgICAgICAgcmV0dXJuIC1FTk9FTlQ7Cj4gPj4gPiA+ICsgICAgICAgfQo+ID4+ ID4gPiArCj4gPj4gPiA+ICsgICAgICAgYm9fdmEgPSBremFsbG9jKHNpemVvZigqYm9fdmEpLCBH RlBfS0VSTkVMKTsKPiA+PiA+ID4gKyAgICAgICBpZiAoIWJvX3ZhKSB7Cj4gPj4gPiA+ICsgICAg ICAgICAgICAgICBlcnIgPSAtRU5PTUVNOwo+ID4+ID4gPiArICAgICAgICAgICAgICAgZ290byBl cnJfb3V0MDsKPiA+PiA+ID4gKyAgICAgICB9Cj4gPj4gPiA+ICsKPiA+PiA+ID4gKyAgICAgICBi b192YS0+dm0gPSB2bTsKPiA+PiA+ID4gKyAgICAgICBib192YS0+cmVmX2NvdW50ID0gMTsKPiA+ PiA+ID4gKwo+ID4+ID4gPiArICAgICAgIG11dGV4X2xvY2soJnZtLT5sb2NrKTsKPiA+PiA+ID4g Kwo+ID4+ID4gPiArICAgICAgIGVyciA9IGRybV9tbV9pbnNlcnRfbm9kZSgmdm0tPm1tLCAmYm9f dmEtPm5vZGUsIGJvLT5nZW0uc2l6ZSk7Cj4gPj4gPiA+ICsgICAgICAgaWYgKGVycikKPiA+PiA+ ID4gKyAgICAgICAgICAgICAgIGdvdG8gZXJyX291dDE7Cj4gPj4gPiA+ICsKPiA+PiA+ID4gKyAg ICAgICBlcnIgPSBsaW1hX3ZtX21hcF9wYWdlX3RhYmxlKHZtLCBiby0+cGFnZXNfZG1hX2FkZHIs IGJvX3ZhLT5ub2RlLnN0YXJ0LAo+ID4+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgYm9fdmEtPm5vZGUuc3RhcnQgKyBib192YS0+bm9kZS5zaXplIC0gMSk7Cj4gPj4g PiA+ICsgICAgICAgaWYgKGVycikKPiA+PiA+ID4gKyAgICAgICAgICAgICAgIGdvdG8gZXJyX291 dDI7Cj4gPj4gPiA+ICsKPiA+PiA+ID4gKyAgICAgICBtdXRleF91bmxvY2soJnZtLT5sb2NrKTsK PiA+PiA+ID4gKwo+ID4+ID4gPiArICAgICAgIGxpc3RfYWRkX3RhaWwoJmJvX3ZhLT5saXN0LCAm Ym8tPnZhKTsKPiA+PiA+Cj4gPj4gPiBTbyB5b3UgY2FuIGhhdmUgMSBCTyBhdCBtdWx0aXBsZSBW QXM/IElzIHRoYXQgcmVhbGx5IG5lZWRlZD8KPiA+PiA+Cj4gPj4gQWN0dWFsbHkgMSBCTyBjYW4n dCBoYXZlIG11bHRpIFZBIGluIHNpbmdsZSBWTSwgYnV0IG9uZSBWQSBpbiBlYWNoIFZNLgo+ID4+ IFdoZW4gYSBCTyBpcyBleHBvcnRlZC9pbXBvcnRlZCBiZXR3ZWVuIHR3byBwcm9jZXNzLCBpLmUu IHhzZXJ2ZXIgYW5kIGNsaWVudCwKPiA+PiB0d28gcHJvY2Vzc2VzIGhhdmUgZGlmZmVyZW50IFZN LCBzbyBjYW4ndCBtYWtlIHN1cmUgaXQgY2FuIGJlIG1hcHBlZCBhdCB0aGUgc2FtZQo+ID4+IHBs YWNlLgo+ID4KPiA+IFJpZ2h0LCBidXQgd2hlbiB5b3UgaW1wb3J0IGEgQk8sIGEgbmV3IEJPIHN0 cnVjdCBpcyBjcmVhdGVkIGFuZAo+ID4gdGhlcmVmb3JlIGEgbmV3IGxpc3QuIElmIHRoZXJlJ3Mg b25seSAxIFZBLCB0aGVuIHlvdSBkb24ndCBuZWVkIGEKPiA+IGxpc3QuIEp1c3QgbW92ZSAnbm9k ZScgaW50byBsaW1hX2JvLiAoSXQgaXMgcG9zc2libGUgSSBtaXNzZWQgc29tZQo+ID4gZGV0YWls IHRob3VnaC4pCj4KPiBZb3Ugb25seSBtYWtlIGEgbmV3IEdFTSBCTyBzdHJ1Y3Qgb24gaW1wb3J0 aW5nIGEgbmV3IGRtYWJ1ZiBpbnRvIHRoZQo+IGRyaXZlciAtLSBleHBvcnQvaW1wb3J0cyBiZXR3 ZWVuIHByb2Nlc3Mgc2hhcmUgdGhlIHNhbWUgR0VNIEJPIHN0cnVjdAo+ICh1bmxlc3MgSSd2ZSBt aXNyZWFkIHdoYXQgeW91J3JlIHNheWluZykuCgpCZSBtb3JlIGNsZWFyLCBHRU0gQk8gc3RydWN0 IGdldHMgY3JlYXRlZCBvbmx5IHdoZW4gaW1wb3J0IGRtYWJ1Zgpmcm9tIGRpZmZlcmVudCBkZXZp Y2VzLgoKUmVnYXJkcywKUWlhbmcKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVs