From: Qiang Yu <yuq825@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: lima@lists.freedesktop.org,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
David Airlie <airlied@linux.ie>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 1/3] drm/lima: Mark 64-bit number as ULL to silence Smatch warning
Date: Thu, 20 Jun 2019 08:52:52 +0800 [thread overview]
Message-ID: <CAKGbVbuai1sBvqovBQZg8BfqEKqFPnKO5YRs-yd_JKXijEHRLA@mail.gmail.com> (raw)
In-Reply-To: <20190618185502.3839-1-krzk@kernel.org>
Looks good for me, patch is:
Reviewed-by: Qiang Yu <yuq825@gmail.com>
I'll apply it to drm-misc-next.
Regards,
Qiang
On Wed, Jun 19, 2019 at 2:55 AM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Mark long numbers with ULL to silence the Smatch warning:
>
> drivers/gpu/drm/lima/lima_device.c:314:32: warning: constant 0x100000000 is so big it is long long
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/gpu/drm/lima/lima_vm.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_vm.h b/drivers/gpu/drm/lima/lima_vm.h
> index caee2f8a29b4..e0bdedcf14dd 100644
> --- a/drivers/gpu/drm/lima/lima_vm.h
> +++ b/drivers/gpu/drm/lima/lima_vm.h
> @@ -15,9 +15,9 @@
> #define LIMA_VM_NUM_PT_PER_BT (1 << LIMA_VM_NUM_PT_PER_BT_SHIFT)
> #define LIMA_VM_NUM_BT (LIMA_PAGE_ENT_NUM >> LIMA_VM_NUM_PT_PER_BT_SHIFT)
>
> -#define LIMA_VA_RESERVE_START 0xFFF00000
> +#define LIMA_VA_RESERVE_START 0x0FFF00000ULL
> #define LIMA_VA_RESERVE_DLBU LIMA_VA_RESERVE_START
> -#define LIMA_VA_RESERVE_END 0x100000000
> +#define LIMA_VA_RESERVE_END 0x100000000ULL
>
> struct lima_device;
>
> --
> 2.17.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-06-20 0:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 18:55 [PATCH 1/3] drm/lima: Mark 64-bit number as ULL to silence Smatch warning Krzysztof Kozlowski
2019-06-18 18:55 ` [PATCH 2/3] drm/lima: Reduce the amount of logs on deferred probe Krzysztof Kozlowski
2019-06-20 0:54 ` Qiang Yu
2019-06-20 6:45 ` Krzysztof Kozlowski
2019-06-18 18:55 ` [PATCH 3/3] drm/panfrost: " Krzysztof Kozlowski
2019-06-20 0:52 ` Qiang Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKGbVbuai1sBvqovBQZg8BfqEKqFPnKO5YRs-yd_JKXijEHRLA@mail.gmail.com \
--to=yuq825@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk@kernel.org \
--cc=lima@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).