From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC5FCC433E1 for ; Mon, 20 Jul 2020 01:00:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99EDB20656 for ; Mon, 20 Jul 2020 01:00:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OJQHF33X" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99EDB20656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 84D2589FDB; Mon, 20 Jul 2020 01:00:43 +0000 (UTC) Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by gabe.freedesktop.org (Postfix) with ESMTPS id 063A089FCC; Mon, 20 Jul 2020 01:00:42 +0000 (UTC) Received: by mail-wr1-x443.google.com with SMTP id a15so1211698wrh.10; Sun, 19 Jul 2020 18:00:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8gbeyqQLMszcPP9qj1dbwb1CV+0Fr8C5EowMymPGD4Y=; b=OJQHF33XODiz/liOvf2YbEnnJ3MeCfKjaS5o8nIyuRr014PLWcxr12E+lCtbrg/Aoa OV1zD9DHcN31tBlqMxIHQyMWh016mSieejmbNfSkwnlWMBH6hmSDXPdCfu87HE1VvT8Y O7CXKnK2Rnf2l7fymC4H0lCndRtN1fAVAsTGfeFYA4wHn4lukDPMwPvPMAjy0pH0gy7U 9X5YwnXnYj8sevOcU80HXjdlgQsRRZCR9tFWWFVb9Fq1eeB3+UHAFNoHq6fKWq738PAW Fm7O+5YBezhO84UUA+nSAV/tcyPN8MORdwNQmurWPgSbUZScpwEaMbZsEf4daliVYUPU EtbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8gbeyqQLMszcPP9qj1dbwb1CV+0Fr8C5EowMymPGD4Y=; b=L1X9gqzOe/hwYYJwIrrSpWcOM3NCLYG2mM+pW0nLGzpZepKNvO9EsGNFFrQwjbFvcG i4f+TuTcK3XauuvflGeJrSUIy+ctknqEGddM2P1wLSBSY8gyfk6BEHzXR3u3TqxX90/n IJZZqpJwYMwQTd3XxWuvf9ztLvs4YnPFmImXYxzdTcafiWHlVVZpCp9QU5c65BGSSjgR E9KFMqLbKVpNtNHoSED/F8FlW3Ns32HgQKnTFSpltuiUKewcPWwpw7Sf6HbhgNVdCMff rak829v7pcag0XfrUOB1OCBrAh6TAf9EChtj5qSA9Zad79nNJwarZMM/jZk8+lrVDxlM Q4KA== X-Gm-Message-State: AOAM532eydJ1YSrLmCsVIARdGaVeB9DTcoTwcq33pgCZFQy9q/AQQjKz s7pcw2OblzmQpBQY43wEYszLnOKcuQ5FAYcv/T8= X-Google-Smtp-Source: ABdhPJxrksBHA9ekD0Q/20KLDUQZ92btwc8L37bHfTwDqFM6qzG03eQZRswFvXz1b/JUPLT+oe663zi8FmpLE2SObkM= X-Received: by 2002:a5d:5642:: with SMTP id j2mr19802770wrw.19.1595206840506; Sun, 19 Jul 2020 18:00:40 -0700 (PDT) MIME-Version: 1.0 References: <20200719073050.776962-1-yuq825@gmail.com> In-Reply-To: From: Qiang Yu Date: Mon, 20 Jul 2020 09:00:29 +0800 Message-ID: Subject: Re: [PATCH] drm/lima: fix wait pp reset timeout To: Erico Nunes X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lima@lists.freedesktop.org, David Airlie , dri-devel , Vasily Khoruzhick , Andreas Baierl Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thanks, applied to drm-misc-fixes. Regards, Qiang On Sun, Jul 19, 2020 at 6:41 PM Erico Nunes wrote: > > On Sun, Jul 19, 2020 at 9:31 AM Qiang Yu wrote: > > > > PP bcast is marked as doing async reset after job is done. > > When resume after suspend, each PP is reset individually, > > so no need to reset in PP bcast resume. But I forgot to > > clear the PP bcast async reset mark so call into async wait > > before job run and gets timeout. > > > > Fixes: 3446d7e9883d ("drm/lima: add resume/suspend callback for each ip") > > Signed-off-by: Qiang Yu > > --- > > drivers/gpu/drm/lima/lima_pp.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/gpu/drm/lima/lima_pp.c b/drivers/gpu/drm/lima/lima_pp.c > > index 33f01383409c..a5c95bed08c0 100644 > > --- a/drivers/gpu/drm/lima/lima_pp.c > > +++ b/drivers/gpu/drm/lima/lima_pp.c > > @@ -271,6 +271,8 @@ void lima_pp_fini(struct lima_ip *ip) > > > > int lima_pp_bcast_resume(struct lima_ip *ip) > > { > > + /* PP has been reset by individual PP resume */ > > + ip->data.async_reset = false; > > return 0; > > } > > > > -- > > Reviewed-by: Erico Nunes > > This fixes the issue reported at > https://gitlab.freedesktop.org/lima/linux/-/issues/34 . _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel