From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC PATCH] drm/vc4: Add a load tracker to prevent HVS underflow errors Date: Tue, 16 Oct 2018 19:51:55 +0200 Message-ID: References: <20181016094045.23021-1-boris.brezillon@bootlin.com> <20181016125743.GZ31561@phenom.ffwll.local> <20181016151045.76944938@bbrezillon> <20181016132809.GF9144@intel.com> <20181016164151.GB31561@phenom.ffwll.local> <20181016173949.GI9144@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9852A6E060 for ; Tue, 16 Oct 2018 17:52:08 +0000 (UTC) Received: by mail-qk1-x742.google.com with SMTP id q12-v6so14673726qkl.13 for ; Tue, 16 Oct 2018 10:52:08 -0700 (PDT) In-Reply-To: <20181016173949.GI9144@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Syrjala, Ville" Cc: Boris Brezillon , gordon@raspberrypi.org, dri-devel , eben@raspberrypi.org List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBPY3QgMTYsIDIwMTggYXQgNzozOSBQTSBWaWxsZSBTeXJqw6Rsw6QKPHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tPiB3cm90ZToKPgo+IE9uIFR1ZSwgT2N0IDE2LCAyMDE4IGF0 IDA2OjQxOjUxUE0gKzAyMDAsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4gPiBPbiBUdWUsIE9jdCAx NiwgMjAxOCBhdCAwNDoyODowOVBNICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gPiA+ IE9uIFR1ZSwgT2N0IDE2LCAyMDE4IGF0IDAzOjEyOjU0UE0gKzAyMDAsIERhbmllbCBWZXR0ZXIg d3JvdGU6Cj4gPiA+ID4gT24gVHVlLCBPY3QgMTYsIDIwMTggYXQgMzoxMCBQTSBCb3JpcyBCcmV6 aWxsb24KPiA+ID4gPiA8Ym9yaXMuYnJlemlsbG9uQGJvb3RsaW4uY29tPiB3cm90ZToKPiA+ID4g PiA+Cj4gPiA+ID4gPiBIaSBEYW5pZWwsCj4gPiA+ID4gPgo+ID4gPiA+ID4gT24gVHVlLCAxNiBP Y3QgMjAxOCAxNDo1Nzo0MyArMDIwMAo+ID4gPiA+ID4gRGFuaWVsIFZldHRlciA8ZGFuaWVsQGZm d2xsLmNoPiB3cm90ZToKPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IE9uIFR1ZSwgT2N0IDE2LCAyMDE4 IGF0IDExOjQwOjQ1QU0gKzAyMDAsIEJvcmlzIEJyZXppbGxvbiB3cm90ZToKPiA+ID4gPiA+ID4g PiBUaGUgSFZTIGJsb2NrIGlzIHN1cHBvc2VkIHRvIGZpbGwgdGhlIHBpeGVsdmFsdmUgRklGT3Mg ZmFzdCBlbm91Z2ggdG8KPiA+ID4gPiA+ID4gPiBtZWV0IHRoZSByZXF1ZXN0ZWQgZnJhbWVyYXRl LiBUaGUgcHJvYmxlbSBpcywgdGhlIEhWUyBhbmQgbWVtb3J5IGJ1cwo+ID4gPiA+ID4gPiA+IGJh bmR3aWR0aHMgYXJlIGxpbWl0ZWQsIGFuZCBpZiB3ZSBkb24ndCB0YWtlIHRoZXNlIGxpbWl0YXRp b25zIGludG8KPiA+ID4gPiA+ID4gPiBhY2NvdW50IHdlIG1pZ2h0IGVuZCB1cCB3aXRoIEhWUyB1 bmRlcmZsb3cgZXJyb3JzLgo+ID4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gVGhpcyBwYXRjaCBp cyB0cnlpbmcgdG8gbW9kZWwgdGhlIHBlci1wbGFuZSBIVlMgYW5kIG1lbW9yeSBidXMgYmFuZHdp ZHRoCj4gPiA+ID4gPiA+ID4gY29uc3VtcHRpb24gYW5kIHRha2UgYSBkZWNpc2lvbiBhdCBhdG9t aWNfY2hlY2soKSB0aW1lIHdoZXRoZXIgdGhlCj4gPiA+ID4gPiA+ID4gZXN0aW1hdGVkIGxvYWQg d2lsbCBmaXQgaW4gdGhlIEhWUyBhbmQgbWVtYnVzIGJ1ZGdldC4KPiA+ID4gPiA+ID4gPgo+ID4g PiA+ID4gPiA+IE5vdGUgdGhhdCB3ZSB0YWtlIGFuIGV4dHJhIG1hcmdpbiBvbiB0aGUgbWVtb3J5 IGJ1cyBjb25zdW1wdGlvbiB0byBsZXQKPiA+ID4gPiA+ID4gPiB0aGUgc3lzdGVtIHJ1biBzbW9v dGhseSB3aGVuIG90aGVyIGJsb2NrcyBhcmUgZG9pbmcgaGVhdnkgdXNlIG9mIHRoZQo+ID4gPiA+ ID4gPiA+IG1lbW9yeSBidXMuIFNhbWUgZ29lcyBmb3IgdGhlIEhWUyBsaW1pdCwgZXhjZXB0IHRo ZSBtYXJnaW4gaXMgc21hbGxlciBpbgo+ID4gPiA+ID4gPiA+IHRoaXMgY2FzZSwgc2luY2UgdGhl IEhWUyBpcyBub3QgdXNlZCBieSBleHRlcm5hbCBjb21wb25lbnRzLgo+ID4gPiA+ID4gPiA+Cj4g PiA+ID4gPiA+ID4gU2lnbmVkLW9mZi1ieTogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxs b25AYm9vdGxpbi5jb20+Cj4gPiA+ID4gPiA+ID4gLS0tCj4gPiA+ID4gPiA+ID4gVGhpcyBsb2dp YyBoYXMgYmVlbiB2YWxpZGF0ZWQgdXNpbmcgYSBzaW1wbGUgc2hlbGwgc2NyaXB0IGFuZAo+ID4g PiA+ID4gPiA+IHNvbWUgaW5zdHJ1bWVudGF0aW9uIGluIHRoZSBWQzQgZHJpdmVyOgo+ID4gPiA+ ID4gPiA+Cj4gPiA+ID4gPiA+ID4gLSBjYXB0dXJlIHVuZGVyZmxvdyBlcnJvcnMgYXQgdGhlIEhW UyBsZXZlbCBhbmQgZXhwb3NlIGEgZGVidWdmcyBmaWxlCj4gPiA+ID4gPiA+ID4gICByZXBvcnRp bmcgdGhvc2UgZXJyb3JzCj4gPiA+ID4gPiA+ID4gLSBhZGQgZGVidWdmcyBmaWxlcyB0byBleHBv c2Ugd2hlbiBhdG9taWNfY2hlY2sgZmFpbHMgYmVjYXVzZSBvZiB0aGUKPiA+ID4gPiA+ID4gPiAg IEhWUyBvciBtZW1idXMgbG9hZCBsaW1pdGF0aW9uIG9yIHdoZW4gaXQgZmFpbHMgZm9yIG90aGVy IHJlYXNvbnMKPiA+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiA+IFRoZSBicmFuY2ggY29udGFpbmlu ZyB0aG9zZSBtb2RpZmljYXRpb24gaXMgYXZhaWxhYmxlIGhlcmUgWzFdLCBhbmQgdGhlCj4gPiA+ ID4gPiA+ID4gc2NyaXB0ICh3aGljaCBpcyBpbnRlcm5hbGx5IHVzaW5nIG1vZGV0ZXN0KSBpcyBo ZXJlIFsyXSAocGxlYXNlIG5vdGUKPiA+ID4gPiA+ID4gPiB0aGF0IEknbSBiYWQgYXQgd3JpdGlu ZyBzaGVsbCBzY3JpcHRzIDotKSkuCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBOb3RlIHRo YXQgdGhvc2UgbW9kaWZpY2F0aW9uIHRlbmQgdG8gb3Zlci1lc3RpbWF0ZSB0aGUgbG9hZCwgYW5k IHRodXMKPiA+ID4gPiA+ID4gPiByZWplY3Qgc2V0dXBzIHRoYXQgbWlnaHQgaGF2ZSBwcmV2aW91 c2x5IHdvcmtlZCwgc28gd2UgbWlnaHQgd2FudCB0bwo+ID4gPiA+ID4gPiA+IGFkanVzdCB0aGUg bGltaXRzIHRvIGF2b2lkIHRoYXQuCj4gPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gPiBbMV1odHRw czovL2dpdGh1Yi5jb20vYmJyZXppbGxvbi9saW51eC90cmVlL3ZjNC9odnMtYmFuZHdpZHRoLWV2 YWwKPiA+ID4gPiA+ID4gPiBbMl1odHRwczovL2dpdGh1Yi5jb20vYmJyZXppbGxvbi92YzQtaHZz LWJhbmR3aWR0aC10ZXN0Cj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IEFueSBpbnRlcmVzdCBpbiB1 c2luZyBpZ3QgdG8gdGVzdCB0aGlzIHN0dWZmPyBXZSBoYXZlIGF0IGxlYXN0IGEgYnVuY2ggb2YK PiA+ID4gPiA+ID4gdGVzdHMgYWxyZWFkeSBpbiB0aGVyZSB0aGF0IHRyeSBhbGwga2luZHMgb2Yg cGxhbmUgc2V0dXBzLiBBbmQgd2UgdXNlCj4gPiA+ID4gPiA+IHRob3NlIHRvIGh1bnQgZm9yIHVu ZGVycnVucyBvbiBpOTE1IGh3Lgo+ID4gPiA+ID4gPgo+ID4gPiA+ID4gPiBXcnQgdW5kZXJydW4g cmVwb3J0aW5nOiBPbiBpOTE1IHdlIGp1c3QgZHVtcCB0aGVtIGludG8gZG1lc2cgYXQgdGhlIGVy cm9yCj4gPiA+ID4gPiA+IGxldmVsLCB1c2luZyBEUk1fRVJST1IsIHBsdXMgYSB0cmFjZXBvaW50 LiBTZWUgZS5nLgo+ID4gPiA+ID4gPiBpbnRlbF9wY2hfZmlmb191bmRlcnJ1bl9pcnFfaGFuZGxl cigpLiBJZiB0aGVyZSdzIGludGVyZXN0IHdlIGNvdWxkCj4gPiA+ID4gPiA+IHBlcmhhcHMgZXh0 cmFjdCB0aGlzIGludG8gc29tZXRoaW5nIGNvbW1vbiwgc2ltaWxhciB0byB3aGF0IHdhcyBkb25l IHdpdGgKPiA+ID4gPiA+ID4gY3JjIHN1cHBvcnQgYWxyZWFkeS4KPiA+ID4gPiA+Cj4gPiA+ID4g PiBTb3VuZHMgbGlrZSBhIGdvb2QgaWRlYS4gSSdsbCBoYXZlIGEgbG9vayBhdCB3aGF0J3MgZG9u ZSBpbiB0aGUgaW50ZWwKPiA+ID4gPiA+IGRyaXZlciBhbmQgd2lsbCBjaGVjayBob3cgZmVhc2li bGUgdGhpcyBpcyB0byBoYXZlIGEgY29tbW9uCj4gPiA+ID4gPiBpbmZyYXN0cnVjdHVyZSB0byB0 ZXN0IHRoYXQgaW4gaWd0Lgo+ID4gPiA+ID4KPiA+ID4gPiA+IFRoYW5rcyBmb3IgdGhlIHBvaW50 ZXJzLgo+ID4gPiA+ID4KPiA+ID4gPiA+Cj4gPiA+ID4gPiA+ID4gK3N0YXRpYyBpbnQgdmM0X2xv YWRfdHJhY2tlcl9hdG9taWNfY2hlY2soc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlKQo+ ID4gPiA+ID4gPiA+ICt7Cj4gPiA+ID4gPiA+ID4gKyAgIHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUg Km9sZF9wbGFuZV9zdGF0ZSwgKm5ld19wbGFuZV9zdGF0ZTsKPiA+ID4gPiA+ID4gPiArICAgc3Ry dWN0IHZjNF9kZXYgKnZjNCA9IHRvX3ZjNF9kZXYoc3RhdGUtPmRldik7Cj4gPiA+ID4gPiA+ID4g KyAgIHN0cnVjdCB2YzRfbG9hZF90cmFja2VyX3N0YXRlICpsb2FkX3N0YXRlOwo+ID4gPiA+ID4g PiA+ICsgICBzdHJ1Y3QgZHJtX3ByaXZhdGVfc3RhdGUgKnByaXZfc3RhdGU7Cj4gPiA+ID4gPiA+ ID4gKyAgIHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lOwo+ID4gPiA+ID4gPiA+ICsgICBpbnQgcmV0 LCBpOwo+ID4gPiA+ID4gPiA+ICsKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gWW91J3JlIG1pc3Np bmcgdGhlIG1vZGVzZXQgbG9ja2luZyBmb3IgdmM0LT5sb2FkX3RyYWNrZXIuIFNlZSB0aGUKPiA+ ID4gPiA+ID4ga2VybmVsZG9jIGZvciBkcm1fYXRvbWljX2dldF9wcml2YXRlX29ial9zdGF0ZSgp Lgo+ID4gPiA+ID4KPiA+ID4gPiA+IEhtLCBJIG1pc3NlZCB0aGlzIHBhcnQgb2YgdGhlIGRvYywg YW5kIEkgdGhvdWdodCB3ZSB3ZXJlIHByb3RlY3RlZCBieQo+ID4gPiA+ID4gdGhlIG1vZGVzZXQg bG9jay4KPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IFByb2JhYmx5IGEgZ29vZCB0aW1lIHRvCj4gPiA+ ID4gPiA+IGltcGxlbWVudCB0aGUgbG9ja2luZyByZWZhY3RvcmluZyBpZGVhIEkgaGF2ZSBhbmQg anVzdCBpbXBsZW1lbnQgYSBwZXIKPiA+ID4gPiA+ID4gcHJpdmF0ZV9vYmogbG9jaywgYW5kIHJl bW92ZSBhbGwgdGhlIGFkLWhvYyBsb2NraW5nIGZyb20gYWxsIHRoZSBjYWxsZXJzPwo+ID4gPiA+ ID4KPiA+ID4gPiA+IExldCBtZSBzZWUgaWYgSSBnZXQgaXQgY29ycmVjdGx5LiBZb3Ugd2FudCB0 byBhZGQgYSBsb2NrIHRvIHRoZQo+ID4gPiA+ID4gZHJtX3ByaXZhdGVfb2JqIHN0cnVjdCwgcmln aHQ/Cj4gPiA+ID4KPiA+ID4gPiBZdXAsIHBsdXMgYXV0b21hdGljYWxseSBncmFiIHRoYXQgbG9j ayBpbiBnZXRfcHJpdmF0ZV9vYmpfc3RhdGUsIGFuZAo+ID4gPiA+IHRoZW4gZHJvcCB0aGUgbm93 IHN1cGVyZmx1b3VzIGxvY2tpbmcgZnJvbSBhbGwgdGhlIGNhbGxlcnMuCj4gPiA+Cj4gPiA+IFlv dSBtZWFuIHRoaXM/Cj4gPiA+IGh0dHBzOi8vcGF0Y2h3b3JrLmZyZWVkZXNrdG9wLm9yZy9wYXRj aC8yMDU5NDMvCj4gPgo+ID4gWXVwLCB0aGF0IG9uZSBleGFjdGx5LiBObyBpZGVhIHdoeSBpdCBk aWVkIGluIGEgYmlrZXNoZWQsIGV4Y2VwdCBtYXliZSB3ZQo+ID4gc2hvdWxkIHB1dCBhbGwgdGhl IHByaXZhdGUgb2JqIG9uIGEgbGlzdCBhbmQgYWRkIHNvbWUgY29kZSB0bwo+ID4gbG9ja19hbGxf Y3R4KCkgdG8gYWxzbyBsb2NrIHRob3NlLgo+Cj4gWWVhaCwgSSB3YXMgYWxzbyB0aGlua2luZyBh bG9uZyB0aG9zZSBsaW5lcyBhIHdoaWxlIGFnbyB3aGVuIGxvb2tpbmcKPiBhdCBzb21lIGZ1bmN0 aW9uIHRoYXQgaXRlcmF0ZXMgYWxsIHRoZSBvdGhlciBvYmplY3RzIGFscmVhZHkuIENhbid0Cj4g cmVjYWxsIHdoYXQgZnVuY3Rpb24gdGhhdCB3YXMgdGhvdWdoIDooCj4KPiBXcnQuIHRoZSBwZXIt cHJpdmF0ZSBvYmogbG9ja3MsIHdlIHN0aWxsIGRvbid0IHVzZSB0aGF0IGZvciBpOTE1IGNkY2xr Cj4gZXRjLiBzbyBJIGNhbid0IGluIGdvb2QgY29uY2llbnNlIG5hayBpdC4gSWYgaXQncyB1c2Vm dWwgZm9yIG90aGVyCj4gZHJpdmVycyB0aGVuIGl0IHNob3VsZCBnbyBpbi4gQW5kIHdlJ2xsIGp1 c3QgaGF2ZSB0byB0aGluayBvZiBzb21lCj4gb3RoZXIgd2F5IHRvIGhhbmRsZSB0aGUgaTkxNSBj YXNlIHNob3VsZCB3ZSBldmVyIGRlY2lkZSB0byBjb252ZXJ0Cj4gaXQgb3Zlci4KCkkgdGhpbmsg d2Ugc2hvdWxkIHN0aWxsIGJlIGFibGUgdG8gaW1wbGVtZW50IGEgcmVhZC1vbmx5IHBlZWsKaW50 ZXJmYWNlIChqdXN0IHJldHVybiB0aGUgY3VycmVudCBzdGF0ZSBwb2ludGVyLCBjYXN0IHRvIGNv bnN0KSwKYXNzdW1pbmcgeW91IGhhdmUgc29tZSBvdGhlciBsb2NraW5nIGNvbnN0cmFpbnRzLiBF bnRpcmVseSBpbiBpOTE1CmNvZGUgb2YgY291cnNlLCB0aGF0J3Mgbm90IHNvbWV0aGluZyB3ZSBj YW4gZWFzaWx5IG1ha2UgZ2VuZXJpYwp1bmZvcnR1bmF0ZWx5LgotRGFuaWVsCi0tIApEYW5pZWwg VmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgorNDEgKDApIDc5IDM2 NSA1NyA0OCAtIGh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2RyaS1kZXZlbAo=