Re: [PATCH] MAINTAINERS: add drm/lima driver info

[Daniel Vetter <daniel@ffwll.ch>]

On Wed, Apr 3, 2019 at 1:54 PM Qiang Yu <yuq825@gmail.com> wrote:
>
> Hi guys,
>
> I have some questions after reading the drm maintainer tools doc:
> https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html
>
> 1. As a committer to drm-misc, do I still need to use dim? Wouldn't just
> raw git commands enough? For example just "git push" to the target
> drm-misc branch.

Yes, there's a pile of sanity checks in dim to make sure there's no
screw-ups. Everytime a new screw-up happens we try to improve the
tooling. So both patch applying and pushing must be done with dim.

> 2. Any special care need to take before push? Like need to test on
> some public CI/CD system or just test locally on affected functionality
> and arch is enough?

Unfortunately that's the one part not automated by dim, because
cross-compiler setups are too tricky. There's a few defconfigs in the
drm-rerere directory (that dim creates) which at least I myself use
for compile testing. So that still needs to be done.

> 3. Do drm-misc have plan to move to gitlab?

Yes, because we want to put all these checks server side (using gitlab
CI). Unfortunately it's held up with some infrastructure work. See
https://gitlab.freedesktop.org/freedesktop/freedesktop/issues/69 for
current status.

Thanks, Daniel

>
> Thanks,
> Qiang
>
> On Tue, Apr 2, 2019 at 10:30 AM Qiang Yu <yuq825@gmail.com> wrote:
> >
> > On Tue, Apr 2, 2019 at 1:48 AM Eric Anholt <eric@anholt.net> wrote:
> > >
> > > Qiang Yu <yuq825@gmail.com> writes:
> > >
> > > > On Fri, Mar 29, 2019 at 11:20 PM Daniel Vetter <daniel@ffwll.ch> wrote:
> > > >>
> > > >> On Fri, Mar 29, 2019 at 09:47:48PM +0800, Qiang Yu wrote:
> > > >> > Signed-off-by: Qiang Yu <yuq825@gmail.com>
> > > >> > ---
> > > >> >  MAINTAINERS | 9 +++++++++
> > > >> >  1 file changed, 9 insertions(+)
> > > >> >
> > > >> > diff --git a/MAINTAINERS b/MAINTAINERS
> > > >> > index f8e63bcc4c1c..cd2d632b713d 100644
> > > >> > --- a/MAINTAINERS
> > > >> > +++ b/MAINTAINERS
> > > >> > @@ -5101,6 +5101,15 @@ S:     Maintained
> > > >> >  F:   drivers/gpu/drm/hisilicon/
> > > >> >  F:   Documentation/devicetree/bindings/display/hisilicon/
> > > >> >
> > > >> > +DRM DRIVERS FOR LIMA
> > > >> > +M:   Qiang Yu <yuq825@gmail.com>
> > > >> > +L:   dri-devel@lists.freedesktop.org
> > > >> > +L:   lima@lists.freedesktop.org
> > > >> > +S:   Maintained
> > > >> > +F:   drivers/gpu/drm/lima/
> > > >> > +F:   include/uapi/drm/lima_drm.h
> > > >> > +T:   git git://anongit.freedesktop.org/drm/drm-misc
> > > >>
> > > >> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> > > >>
> > > >> btw where's your fdo account request so I can ack your drm-misc rights?
> > > > Here it is:
> > > > https://gitlab.freedesktop.org/freedesktop/freedesktop/issues/139
> > > >
> > > >> For merging I think Eric already volunteered, and for questions I think
> > > >> there's enough experienced drm-misc committers in this thread for smooth
> > > >> learning for you.
> > > >>
> > > > OK, thanks.
> > > >
> > > > Hi Eric, please go ahead to push the lima driver and this patch, thanks.
> > >
> > > Did builds on x86_64, arm64, and arm, and all looked good.  Merged now.
> > > Congrats!
> > >
> > > Once this hits drm-next, we'll be ready to merge the Mesa side.
> >
> > Thanks very much!
> >
> > Regards,
> > Qiang



-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel