From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 151AEC433DF for ; Thu, 30 Jul 2020 11:35:19 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD8D320656 for ; Thu, 30 Jul 2020 11:35:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="iipVaGjf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD8D320656 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4796A6E045; Thu, 30 Jul 2020 11:35:18 +0000 (UTC) Received: from mail-ot1-x341.google.com (mail-ot1-x341.google.com [IPv6:2607:f8b0:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5915A6E1B9 for ; Thu, 30 Jul 2020 11:35:17 +0000 (UTC) Received: by mail-ot1-x341.google.com with SMTP id h1so19794189otq.12 for ; Thu, 30 Jul 2020 04:35:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MRzokrMc0Qm9FKeka5mjSS3X3+tAOXypP+ce1X7MQBI=; b=iipVaGjfy4vwKxkDV4BAQroSsbhnoNOfVaRbNPsPbYc617UHV3vMKacI3QuoVFW4Ym NMEfZrR2B+sQF5rf1QYFMQhm71yOP2XE0ErB0cuM7dlMVGT/r/UTqlQt9ZlRjsV3FiHj KOP0wiur98KfxTYFxbJ78Ro9HO5aYJz9EPxPI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MRzokrMc0Qm9FKeka5mjSS3X3+tAOXypP+ce1X7MQBI=; b=NqlnfmPZdSdCub59XfXQTBGHOiX/gxUJ9uOOQRJ5JNI83TmR2WEpWcGDaTWDo9tlhC YkDVqOTp6nmCmcCyyMaawaR7RwqU0sHK161+q6ewpYutu/b2Ut/RtMRCY9oxI9WC64an 6sL1HjjGiQ+5tJx3KcNk0EWYXj5wV6sxlxBgMwGsK8P+vYnvHLqzQ3HNkB8u1r8yNSdx ojbZ+4TDjR5B0pCSPDMphLx+M2nSp/t8gHn9QkWSsrCSK19Ie2tKuxAjoLce6AxFZzsL 9M6N7EGdKrP340xrQ3ucFEXYLef1jspxGap64ecMGb3oMyWDfInYJmIm0Wd3b5nqRaaM 8KOw== X-Gm-Message-State: AOAM531jLCHhqMXvUUkkUk9X9ayddTvJnYiyPesj9wEYYJkst/UZ4ZTx 1r4lRijrin227xXlMNpkd34XLl8+cBPOZjvSV5/nOC/3 X-Google-Smtp-Source: ABdhPJyK3XjO3qAYxV/3DE11QmLPyeVuxGiJw5ED5uo8MdAzpo+p3AFXndZW5wHhjoS7i3OPw7tr1pOnjbzeng7wAi4= X-Received: by 2002:a9d:6052:: with SMTP id v18mr1821579otj.303.1596108916621; Thu, 30 Jul 2020 04:35:16 -0700 (PDT) MIME-Version: 1.0 References: <1596000620-4075-1-git-send-email-penguin-kernel@I-love.SAKURA.ne.jp> In-Reply-To: From: Daniel Vetter Date: Thu, 30 Jul 2020 13:35:05 +0200 Message-ID: Subject: Re: [PATCH] fbmem: pull fbcon_update_vcs() out of fb_set_var() To: Tetsuo Handa X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux Fbdev development list , Bartlomiej Zolnierkiewicz , Greg Kroah-Hartman , Linux Kernel Mailing List , dri-devel , Jiri Slaby , syzbot Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Jul 30, 2020 at 1:27 PM Tetsuo Handa wrote: > > On 2020/07/30 20:16, Daniel Vetter wrote: > > Patch looks good, except ... does this compile? fbcon_update_vcs is > > defined in fbcon.h, and that doesn't seem to be included here ... > > Maybe what we want is an fb_set_var_ioctl in fbmem.c so that the fbcon > > interaction is a bit better hidden (but that's a bikeshed, feel free > > to ignore). Also I have no idea what trickery you need to compile-test > > ps3fb, that's why I'm asking :-) > > Right. I didn't prepare environment for compiling powerpc kernel. > Kernel test robot found it and I already posted V2 patch as > https://lkml.kernel.org/r/075b7e37-3278-cd7d-31ab-c5073cfa8e92@i-love.sakura.ne.jp . Excellent. It's still stuck in a queue somewhere and hasn't reached my inbox, I'll queue it up as soon as I have it. Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel