From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD209C4361A for ; Fri, 4 Dec 2020 15:58:15 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FFB822B30 for ; Fri, 4 Dec 2020 15:58:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FFB822B30 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A19E26E199; Fri, 4 Dec 2020 15:58:14 +0000 (UTC) Received: from mail-oi1-x244.google.com (mail-oi1-x244.google.com [IPv6:2607:f8b0:4864:20::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 20FC36E199 for ; Fri, 4 Dec 2020 15:58:13 +0000 (UTC) Received: by mail-oi1-x244.google.com with SMTP id y74so6593923oia.11 for ; Fri, 04 Dec 2020 07:58:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m5DyIeCqEHow3pyi/ELGyt5+gpVvfGOYWC30niViLAw=; b=ENVmYaHkYKwkKLuOLOYqWHAtVAIBDKKTrE0phm2RbW/YGj6vvZSTOxkWMEVaN3t565 yFv/JRxwqpR0lthp4Sfvme/8pIf2685uvQdK0BCzWNyqyeei1zOK495ZOAakvciS20m1 w/utIJ2/QMjErlSI7wYNxiMUmZvbaLS2ANq7w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m5DyIeCqEHow3pyi/ELGyt5+gpVvfGOYWC30niViLAw=; b=tOaHChbo5GcuQn3RsaValw3OQXZprXVsVZ1r3YeTswTDBX8EKMqq2nNUgy/Cab5e1M 6f0jwiRPP+m6/5xM4VXvMGNivWwNc1mZMTuGa1DEZwl2cXYMoMbwVE4lQ0d4+C/aR2NS dX/s2guevrS+mqjHm6IvK6bfa1gRMADk1ZzZQz/zko9a4C6B7JXV6X9XdqBHa6UBBFHN AkC7nBSK8OtqF4EujCz36kVjQvyht8UUZOZi0u365lyfnEiod2lOo1lopCSXT7uuqFam B6l/Z/F+SMBL01XuhbQvSUV0SfmLA1PrNL2Y5/g+2ATqyrbZi5nOZI9hbHVdNoL+7lzO YYzQ== X-Gm-Message-State: AOAM530V+kQCpTN6B0DIhuwYWgWHpjgtLDmTXlCuyzr61CU8lTVJgmrx fjep5+pqX+FfVHNjDKPByvNalS+T7zENPP2OmfKPjg== X-Google-Smtp-Source: ABdhPJy/glayHXrKa+Blt8mThAT2uPeru1uzubYdwEL07+6IOjO5J4TeJsD6tMCy1ZKZlK4XHPD5cV60PhsoBDOlpy0= X-Received: by 2002:aca:7506:: with SMTP id q6mr3721074oic.128.1607097492303; Fri, 04 Dec 2020 07:58:12 -0800 (PST) MIME-Version: 1.0 References: <1606816916-3724-1-git-send-email-jpark37@lagfreegames.com> <1606816916-3724-2-git-send-email-jpark37@lagfreegames.com> <2dbbc3dc-4df8-9ca4-4dce-808df0b24950@daenzer.net> <20201204101151.55f487b8@eldfell> In-Reply-To: <20201204101151.55f487b8@eldfell> From: Daniel Vetter Date: Fri, 4 Dec 2020 16:58:01 +0100 Message-ID: Subject: Re: [PATCH] drm: Fix drm.h uapi header for Windows To: Pekka Paalanen X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Michel_D=C3=A4nzer?= , dri-devel , James Park , James Park Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Dec 4, 2020 at 9:12 AM Pekka Paalanen wrote: > > On Thu, 3 Dec 2020 21:45:14 +0100 > Daniel Vetter wrote: > > > On Thu, Dec 3, 2020 at 7:55 PM James Park wrote: > > > > > > The trailing underscore for DRM_FOURCC_STANDALONE_ isn't > > > intentional, right? Should I put all the integer types, or just the > > > ones that are used in that file? > > > > Yeah that trailing _ just slipped in. And I'd just do the types > > already used. I don't think anything else than __u32 (for drm fourcc) > > and __u64 (for drm modifier) is needed. > > Hi, > > can that create conflicts if userspace first includes drm_fourcc.h and > then drm.h? > > I would find it natural to userspace have generic headers including > drm_fourcc.h and then DRM-specific C-files including drm.h as well > (through libdrm headers). I think Weston might already do this. > > The generic userspace (weston) header would obviously #define > DRM_FOURCC_STANDALONE, because it is used by non-DRM C-files as well. Hm yes that would break. I guess we could just include the linux types header for this. And I guess on windows you'd need to have that from somewhere. Or we just require that users of the standalone header pull the right header or defines in first? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel