From: Daniel Vetter <daniel.vetter@ffwll.ch>
To: Matthew Wilcox <willy@infradead.org>
Cc: "Christoph Hellwig" <hch@infradead.org>,
"Sandeep Patil" <sspatil@google.com>,
"Linux MM" <linux-mm@kvack.org>,
"Suren Baghdasaryan" <surenb@google.com>,
"James Jones" <jajones@nvidia.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Liam Mark" <lmark@codeaurora.org>,
"moderated list:DMA BUFFER SHARING FRAMEWORK"
<linaro-mm-sig@lists.linaro.org>,
"Minchan Kim" <minchan@kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
"Chris Goldsworthy" <cgoldswo@codeaurora.org>,
"Hridya Valsaraju" <hridya@google.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"open list:DMA BUFFER SHARING FRAMEWORK"
<linux-media@vger.kernel.org>,
"Android Kernel Team" <kernel-team@android.com>,
"Christian König" <christian.koenig@amd.com>,
"Robin Murphy" <robin.murphy@arm.com>
Subject: Re: [Linaro-mm-sig] [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error
Date: Wed, 3 Feb 2021 09:52:22 +0100 [thread overview]
Message-ID: <CAKMK7uHnNdjOYX5Rhj=uGMz7hSz12JhgkZJCfiqgkpjXnMfL4A@mail.gmail.com> (raw)
In-Reply-To: <20210203015553.GX308988@casper.infradead.org>
On Wed, Feb 3, 2021 at 2:57 AM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Tue, Feb 02, 2021 at 04:31:33PM -0800, Suren Baghdasaryan wrote:
> > Replace BUG_ON(vma->vm_flags & VM_PFNMAP) in vm_insert_page with
> > WARN_ON_ONCE and returning an error. This is to ensure users of the
> > vm_insert_page that set VM_PFNMAP are notified of the wrong flag usage
> > and get an indication of an error without panicing the kernel.
> > This will help identifying drivers that need to clear VM_PFNMAP before
> > using dmabuf system heap which is moving to use vm_insert_page.
>
> NACK.
>
> The system may not _panic_, but it is clearly now _broken_. The device
> doesn't work, and so the system is useless. You haven't really improved
> anything here. Just bloated the kernel with yet another _ONCE variable
> that in a normal system will never ever ever be triggered.
Also, what the heck are you doing with your drivers? dma-buf mmap must
call dma_buf_mmap(), even for forwarded/redirected mmaps from driver
char nodes. If that doesn't work we have some issues with the calling
contract for that function, not in vm_insert_page.
Finally why exactly do we need to make this switch for system heap?
I've recently looked at gup usage by random drivers, and found a lot
of worrying things there. gup on dma-buf is really bad idea in
general.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-02-03 8:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 0:31 [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error Suren Baghdasaryan
2021-02-03 0:31 ` [PATCH v2 2/2] dma-buf: heaps: Map system heap pages as managed by linux vm Suren Baghdasaryan
2021-02-03 1:39 ` Minchan Kim
2021-02-03 2:02 ` Suren Baghdasaryan
2021-02-03 8:05 ` Christian König
2021-02-03 19:53 ` Suren Baghdasaryan
2021-02-03 2:07 ` John Stultz
2021-02-03 2:13 ` Suren Baghdasaryan
2021-02-03 1:27 ` [PATCH 1/2] mm: replace BUG_ON in vm_insert_page with a return of an error Miaohe Lin
2021-02-03 1:31 ` Minchan Kim
2021-02-03 1:55 ` Suren Baghdasaryan
2021-02-03 1:55 ` Matthew Wilcox
2021-02-03 2:26 ` Suren Baghdasaryan
2021-02-03 8:52 ` Daniel Vetter [this message]
2021-02-03 20:20 ` [Linaro-mm-sig] " Suren Baghdasaryan
2021-02-03 20:29 ` Daniel Vetter
2021-02-03 21:25 ` Daniel Vetter
2021-02-03 21:41 ` Suren Baghdasaryan
2021-02-04 8:16 ` Christian König
2021-02-04 15:22 ` Daniel Vetter
2021-02-04 15:54 ` Alex Deucher
2021-02-05 3:39 ` Suren Baghdasaryan
2021-02-04 7:53 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKMK7uHnNdjOYX5Rhj=uGMz7hSz12JhgkZJCfiqgkpjXnMfL4A@mail.gmail.com' \
--to=daniel.vetter@ffwll.ch \
--cc=akpm@linux-foundation.org \
--cc=cgoldswo@codeaurora.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@infradead.org \
--cc=hridya@google.com \
--cc=jajones@nvidia.com \
--cc=kernel-team@android.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lmark@codeaurora.org \
--cc=minchan@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sspatil@google.com \
--cc=surenb@google.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).