From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5830FC433B4 for ; Fri, 30 Apr 2021 08:49:49 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02C9761420 for ; Fri, 30 Apr 2021 08:49:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02C9761420 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 614306E0E5; Fri, 30 Apr 2021 08:49:48 +0000 (UTC) Received: from mail-il1-x12f.google.com (mail-il1-x12f.google.com [IPv6:2607:f8b0:4864:20::12f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 441186E0E5 for ; Fri, 30 Apr 2021 08:49:47 +0000 (UTC) Received: by mail-il1-x12f.google.com with SMTP id e14so1046198ils.12 for ; Fri, 30 Apr 2021 01:49:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6XpLFpvoM/MyCxucScV9GHbc1u0ufErrdczH8fINryA=; b=XfdyiakISQV0rCr116VJNrN1pSVJBxJnhTJ36wAigGd+atH9iiXt0+lNxlH+horNLb ITiUPgvRVyeFfalzkClX0syUiifPxjCE6CGSGGJp/t28z5etiIkNkRO9rIrnkUu15fhf GIO1TP2+iIaDMYSRGGp2MyxlEKrb6aGXi9T+9uaIzTKMecoxdO77gb/cI3OjjYXfDElj ozBDRGBu/DhpEiRe7fJsEXyaDafnVYnU0y4y4QTe42zmjWctSLpA+9WW9KGIDPCAgNoe w3H/j2m9HLeM9sQcgJqcggbYuKqInYiWAIqck2rs3kHs5USyYLaW9h7KmKNfRrqPhiDV Bghg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6XpLFpvoM/MyCxucScV9GHbc1u0ufErrdczH8fINryA=; b=XLdW066H8z4hoXOJDntgDKDyFThiyV+MTH+czMoQSgrSjXfgFBMr20MsXJUxbZhCT1 J7+tKUdwOxlBwAFlBWqXXnQUOIj11dm1luq8k9SXWI6CrHXW4a3HjTz6D72cpJca6q/8 L2NYzyeh53Luv7mtPMf+gum48/myMYIMTqJqVJn/1DBWjirjzEOHiBSTW5tDkQqK8pDg YPJfUL210ehX30I3pX4P+nxCl4RXWNsLJqeJMY74htibbUT5rE/SNx4JrCVcrdS8EakH bBe5z6xCfdYe0H5xgJUUUECsCFHl9T0Z5h317xZPeBsd6V2mX8lXLi8Nk0TVvPRJu9Cd trwg== X-Gm-Message-State: AOAM533YslI8JIHGJDjdpSthJSn7nhmza0yDCgxnlkyc9WyE9RCVAaq4 130wTTwv+aazsSAJc1xioKZpPYhxMofoOlF8ks4= X-Google-Smtp-Source: ABdhPJwq7AMNZNBViIBThuRjUDAbnJQd0R8zTalusTtudatSMQDlQfcewQ6cSi3aISJKRV4yX05N2MCV3b2pDAn5iAM= X-Received: by 2002:a92:3203:: with SMTP id z3mr3244322ile.22.1619772586655; Fri, 30 Apr 2021 01:49:46 -0700 (PDT) MIME-Version: 1.0 References: <20210423034247.992052-1-art@khadas.com> <20210423114735.GA5507@sirena.org.uk> <20210426115645.GB4590@sirena.org.uk> In-Reply-To: <20210426115645.GB4590@sirena.org.uk> From: Art Nikpal Date: Fri, 30 Apr 2021 16:49:35 +0800 Message-ID: Subject: Re: [PATCH] SPI: meson-spifc add missed calls to remove function To: Mark Brown X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gouwa Wang , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Christian Hewitt , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-spi@vger.kernel.org, nick@khadas.com, linux-amlogic@lists.infradead.org, Artem Lapkin , linux-arm-kernel@lists.infradead.org, jbrunet@baylibre.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Yep! but if i try call spi_master_put(master) or spi_unregister_controller(master); it's made Segmentation fault for me what's wrong - may be somebody can help me On Mon, Apr 26, 2021 at 7:57 PM Mark Brown wrote: > > On Sat, Apr 24, 2021 at 07:57:19AM +0800, Art Nikpal wrote: > > > > I would expect the driver to unregister the controller at the start of > > > the remove function, suspend doesn't really make sense here > > > It's strange - But without spi_master_suspend i have randomly stucks when i > > try unload this module - as was written before > > i was test it (load/unload module in loop) and for me suspend make sense > > here > > > If anybody has another solution - or real problem not here - please write > > to me the right way! > > As I said above unregister the controller at the start of the remove > function. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel