From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF8E0C55179 for ; Tue, 27 Oct 2020 08:12:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8487B207C3 for ; Tue, 27 Oct 2020 08:12:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="Z12aKn10" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8487B207C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7FB3E6EB26; Tue, 27 Oct 2020 08:12:08 +0000 (UTC) Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7A05F6EA5C for ; Mon, 26 Oct 2020 19:45:01 +0000 (UTC) Received: by mail-pl1-x643.google.com with SMTP id v22so5217836ply.12 for ; Mon, 26 Oct 2020 12:45:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UvmyfAS3FNKDIUlMjXBNYKBYoK/vtIij8n9c082Mubc=; b=Z12aKn10RT7C+3vv+Dd1Qd3nDVfwmXeae7+m3xHAdCx85aOB2Ws7HE+ACqBhBXrMGV NehOiNBdl5lbTfi1yIOBt80NUA5Po4VsqhAyaAOC51MuHbfbmvuV709wMQ6aBx/IGyUm 3henAzzU6ESqHqwQmAGqRvS3m7nsVrOozE3NPK7k28PGVWxMoWzGfImr1yTV7feWcRvA t+prlzoIShFvDMMoupo9RG21asc7kOD82jAGaZhwMF2V/nf9yPC/fU6weKMXF1kVLV0q 6eeylUw0wdGM+y680r9NV7ySMUaHEz1uVz1BHfbcAwTyqkRcCeq0ZIgxkviZFdzsdXc5 pIHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UvmyfAS3FNKDIUlMjXBNYKBYoK/vtIij8n9c082Mubc=; b=ORAh8BR0CvVXPws4FQeVyyYc24jmQKeVYvZYtNesgyJRnku8Xq42/LbyedUqFyXfdZ M0jWscBx5PtF6XhVF2IDThqtlO/AuUY5q89fJ/T3Sr9gQK404anJyBiz++082PJY6e51 F4Y0mKL282NoVSfIDBqFqiZmLGlktOqY+Bm/naTcaC15hLYvF43N+/7SGifZPednAuLi AP87Cgt3/EW1Dfs+psT/L3F83RRPLJ8U532gAUTSfgO6onXFgKDTLNOhicVuxIY7RP3r fgLUzijm1TuWeD06d3QjcQr4tsEsgwJZu8TNEzfpQwwvErpTWipjKsF3JQR6CT/Y/To8 DP5Q== X-Gm-Message-State: AOAM530ddRCaq0O3FZnxDjPdcFzv1qpB4O4juzCfa6Y1YgtvIrWdNUdB ggunppIkIuHs8B0ug3sV8sf2bG4FgWVqRqxZg+GZ0A== X-Google-Smtp-Source: ABdhPJzo8W8E/m1R7rra7IFPqewUOrGPxKXu7J09tIasrTWLM5xWrumM7TFDDFkiXzDRs8Myt1FX1umkbCmB5lyZAZI= X-Received: by 2002:a17:90a:740a:: with SMTP id a10mr18182181pjg.32.1603741500883; Mon, 26 Oct 2020 12:45:00 -0700 (PDT) MIME-Version: 1.0 References: <20201026194110.3817470-1-arnd@kernel.org> <20201026194110.3817470-2-arnd@kernel.org> In-Reply-To: <20201026194110.3817470-2-arnd@kernel.org> From: Nick Desaulniers Date: Mon, 26 Oct 2020 12:44:49 -0700 Message-ID: Subject: Re: [PATCH 2/4] drm/imx: tve remove extraneous type qualifier To: Arnd Bergmann X-Mailman-Approved-At: Tue, 27 Oct 2020 08:12:06 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: LKML , Arnd Bergmann , Thomas Zimmermann , David Airlie , Greg Kroah-Hartman , Sascha Hauer , Marco Felsch , dri-devel , Markus Elfring , clang-built-linux , NXP Linux Team , Nathan Chancellor , Shawn Guo , Pengutronix Kernel Team , Linux ARM , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Oct 26, 2020 at 12:41 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > clang warns about functions returning a 'const int' result: > > drivers/gpu/drm/imx/imx-tve.c:487:8: warning: type qualifiers ignored on function return type [-Wignored-qualifiers] > > Remove the extraneous 'const' qualifier here. I would guess that the > function was intended to be marked __attribute__((const)) instead, > but that would also be wrong since it call other functions without > that attribute. > > Fixes: fcbc51e54d2a ("staging: drm/imx: Add support for Television Encoder (TVEv2)") > Signed-off-by: Arnd Bergmann Thanks for the patch! Reviewed-by: Nick Desaulniers > --- > drivers/gpu/drm/imx/imx-tve.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c > index ef3c25d87d87..2a8d2e32e7b4 100644 > --- a/drivers/gpu/drm/imx/imx-tve.c > +++ b/drivers/gpu/drm/imx/imx-tve.c > @@ -484,7 +484,7 @@ static const char * const imx_tve_modes[] = { > [TVE_MODE_VGA] = "vga", > }; > > -static const int of_get_tve_mode(struct device_node *np) > +static int of_get_tve_mode(struct device_node *np) > { > const char *bm; > int ret, i; > -- > 2.27.0 > -- Thanks, ~Nick Desaulniers _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel