dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: John Stultz <john.stultz@linaro.org>
To: Veera Sundaram Sankaran <veeras@codeaurora.org>
Cc: David Airlie <airlied@linux.ie>,
	Gustavo Padovan <gustavo@padovan.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	pdhaval@codeaurora.org, abhinavk@codeaurora.org,
	Sean Paul <sean@poorly.run>,
	linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] dma-fence: allow signaling drivers to set fence timestamp
Date: Wed, 13 Jan 2021 17:16:34 -0800	[thread overview]
Message-ID: <CALAqxLVCf0w2oO2CPYp4R=Fk2yPGptDXY3v+RW5qzycg8R3NeA@mail.gmail.com> (raw)
In-Reply-To: <1610567539-16750-1-git-send-email-veeras@codeaurora.org>

On Wed, Jan 13, 2021 at 11:52 AM Veera Sundaram Sankaran
<veeras@codeaurora.org> wrote:
> Some drivers have hardware capability to get the precise HW timestamp
> of certain events based on which the fences are triggered. The delta
> between the event HW timestamp & current HW reference timestamp can
> be used to calculate the timestamp in kernel's CLOCK_MONOTONIC time
> domain. This allows it to set accurate timestamp factoring out any
> software and IRQ latencies. Add a timestamp variant of fence signal
> function, dma_fence_signal_timestamp to allow drivers to update the
> precise timestamp for fences.
>
> Changes in v2:
> - Add a new fence signal variant instead of modifying fence struct
>
> Changes in v3:
> - Add timestamp domain information to commit-text and
> dma_fence_signal_timestamp documentation
>
> Signed-off-by: Veera Sundaram Sankaran <veeras@codeaurora.org>

Looks ok to me, also did some brief testing w/ AOSP and didn't see any
regressions.

Reviewed-by: John Stultz <john.stultz@linaro.org>

thanks
-john
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

      parent reply	other threads:[~2021-01-14  1:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-13 19:52 [PATCH v3 1/2] dma-fence: allow signaling drivers to set fence timestamp Veera Sundaram Sankaran
2021-01-13 19:52 ` [PATCH v3 2/2] drm/drm_vblank: set the dma-fence timestamp during send_vblank_event Veera Sundaram Sankaran
2021-01-14  1:29   ` John Stultz
2021-01-14  2:28   ` John Stultz
2021-01-14 20:54     ` veeras
2021-01-15 22:29       ` John Stultz
2021-01-16  1:12         ` veeras
2021-01-14  1:16 ` John Stultz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALAqxLVCf0w2oO2CPYp4R=Fk2yPGptDXY3v+RW5qzycg8R3NeA@mail.gmail.com' \
    --to=john.stultz@linaro.org \
    --cc=abhinavk@codeaurora.org \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gustavo@padovan.org \
    --cc=linux-media@vger.kernel.org \
    --cc=pdhaval@codeaurora.org \
    --cc=sean@poorly.run \
    --cc=veeras@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).