From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FFBAC47258 for ; Fri, 1 May 2020 18:42:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68A5D21775 for ; Fri, 1 May 2020 18:42:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Sqk3ZNvO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68A5D21775 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D9D9A6E973; Fri, 1 May 2020 18:42:41 +0000 (UTC) Received: from mail-ot1-x342.google.com (mail-ot1-x342.google.com [IPv6:2607:f8b0:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id 635736E973 for ; Fri, 1 May 2020 18:42:40 +0000 (UTC) Received: by mail-ot1-x342.google.com with SMTP id e26so3314482otr.2 for ; Fri, 01 May 2020 11:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yq7Ibs47iQ7Lo5VGMp7gRZ6yUxyqVA2i9kts0jwiLrg=; b=Sqk3ZNvO90q24WbyfeYjeqHXxER0SZRc5xSI5RM5Nuv9B3ZrYEi33jQuT1hGlipWhW hvfe10Z7MjuWVqIgFIGCh1vX61lDdIWshuPxlhpxYvSGgIykaDH4wYq9CcG9PYvJCxnG Qod+n3wh9PZsgmkcNsHVm4KLG8FyyBIFO8o+o+M0pbZrNFM0eWtfAF6okflgipvcQ1k0 ZpKOab+w3go1VnlFI2C/NWHJFgBePuy+8oTNmaHzdoaXKkj+5vcaptuIxg4ethg4nCCg oe12HiqThde5msD1xr4IG5FgmGjSqY+lbxjSPwdLZoqN9ONczywqxt+3yssPl4cyaexa 9RFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yq7Ibs47iQ7Lo5VGMp7gRZ6yUxyqVA2i9kts0jwiLrg=; b=bAKSAcfN1zZowZ1HcuwoqmwUf6iOvvPecSpuLK/HofrOM1qyVBOFLuyeoeBY9lQaZa 6rqAdbr5EDOPMugN6wjVMX4J8SP5DQutoXwEB8UGrnHGoSxGQNlbBgzcNJNwYKXLNmnd TtelGdC+k1B1N6F0w53W8oeQQdtlQo295NNVH9zranhtYrzZ5Zw2IPsg9UNQkoAPIbpm zUfZcXoHIoIMzPVQcc6jjOjTMo7lIsJrtbDs2jWDpHls5lhg+hgJyQWy568/oftCg5G+ s1ntcUFGrMk3iYwFW01DmGo8wteEDNaIj2oW75abXk0iUUSkPDbcpbI550LDAjbhODaT bGSg== X-Gm-Message-State: AGi0Pub3yYYUghTbncc/6BvELKEOuNDO/2urmskcd8u2IQrgglZOky2h bv4p+Z6YEGp3JtQcoxhNlFu/Np0aDUT7z8Fh+pXL4w== X-Google-Smtp-Source: APiQypL+VkyGnMilOhi+kaL79AKLY56zEToU7HIKl+3eFaVpJsUVoYecvtEHrqDQsSqZiNr1DTrBBFivrPw2tyNZtok= X-Received: by 2002:a05:6830:1589:: with SMTP id i9mr4948265otr.102.1588358559590; Fri, 01 May 2020 11:42:39 -0700 (PDT) MIME-Version: 1.0 References: <20200501073949.120396-1-john.stultz@linaro.org> <20200501073949.120396-3-john.stultz@linaro.org> <20200501104810.v6oa2yhawr4iki67@DESKTOP-E1NTVVP.localdomain> In-Reply-To: <20200501104810.v6oa2yhawr4iki67@DESKTOP-E1NTVVP.localdomain> From: John Stultz Date: Fri, 1 May 2020 11:42:28 -0700 Message-ID: Subject: Re: [RFC][PATCH 2/4] mm: cma: Add dma_heap flag to cma structure To: Brian Starkey X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , nd , Alistair Strachan , Sandeep Patil , Robin Murphy , Chenbo Feng , lkml , Liam Mark , "Andrew F. Davis" , linux-mm , Rob Herring , Christoph Hellwig , dri-devel , Hridya Valsaraju , Andrew Morton , Laura Abbott , Pratik Patel , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, May 1, 2020 at 3:48 AM Brian Starkey wrote: > On Fri, May 01, 2020 at 07:39:47AM +0000, John Stultz wrote: > > +bool cma_dma_heap_enabled(struct cma *cma) > > +{ > > + return !!cma->dma_heap; > > Stylistic thing, but I don't think the !! is really necessary. It's > already a bool anyway. Yea, I was using a bit field earlier and then moved to a bool for simplicity and left this. I saw it as soon as I sent the patch, so it's already fixed up. > > @@ -157,6 +167,7 @@ static int __init cma_init_reserved_areas(void) > > } > > core_initcall(cma_init_reserved_areas); > > > > + > > nit: spurious newline Yep. Same. The things you only see once the mail is sent. :) Thanks so much for the review though! -john _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel