From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v3 2/2] drm/lima: driver for ARM Mali4xx GPUs Date: Tue, 5 Mar 2019 09:31:09 -0600 Message-ID: References: <20190227134124.28602-1-yuq825@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Qiang Yu Cc: Marek Vasut , Simon Shields , lima@lists.freedesktop.org, Maxime Ripard , =?UTF-8?Q?Christian_K=C3=B6nig?= , Neil Armstrong , dri-devel , Vasily Khoruzhick , David Airlie , Sean Paul , Andreas Baierl , Erico Nunes List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBNYXIgMSwgMjAxOSBhdCAxMToyMyBQTSBRaWFuZyBZdSA8eXVxODI1QGdtYWlsLmNv bT4gd3JvdGU6Cj4KPiA+ID4gK3N0YXRpYyBzdHJ1Y3QgbGltYV9mZW5jZSAqbGltYV9mZW5jZV9j cmVhdGUoc3RydWN0IGxpbWFfc2NoZWRfcGlwZSAqcGlwZSkKPiA+ID4gK3sKPiA+ID4gKyAgICAg ICBzdHJ1Y3QgbGltYV9mZW5jZSAqZmVuY2U7Cj4gPiA+ICsKPiA+ID4gKyAgICAgICBmZW5jZSA9 IGttZW1fY2FjaGVfemFsbG9jKGxpbWFfZmVuY2Vfc2xhYiwgR0ZQX0tFUk5FTCk7Cj4gPgo+ID4g T3V0IG9mIGN1cmlvc2l0eSwgd2hhdCBpcyB0aGUgYmVuZWZpdCBvZiB1c2luZyBhIHNlcGFyYXRl IHNsYWIgaGVyZT8KPiA+IElmIHRoaXMgaXMgYmVuZWZpY2lhbCwgdGhlbiBvdGhlciBkcml2ZXJz IHNob3VsZCBkbyB0aGlzIHRvbyBhbmQgaXQKPiA+IHNob3VsZCBiZSBjb21tb24uIE90aGVyd2lz ZSwgaXQgYWRkcyBzb21lIGNvbXBsZXhpdHkuCj4KPiBmZW5jZSBpcyBwcmV0dHkgZnJlcXVlbnRs eSBhbGxvYyBmcmVlIHN0cnVjdCwgc28gbWFrZSBpdCBhIHNsYWIuIEFuZCBpdCdzIHVzZWQKPiBp biBnZXQvcHV0IHBhdHRlcm4sIHNvIG1heSBsaXZlIGxvbmdlciB0aGFuIGVtYmVkZGVkIHN0cnVj dC4gVGhpcyBpcyByZWZlcmVuY2VkCj4gZnJvbSBhbWRncHUgZHJpdmVyLgo+Cj4gPgo+ID4gQW5k IG1heWJlIHRoZSBzbGFiIHNob3VsZCBiZSBpbml0aWFsemVkIGluIHByb2JlIHJhdGhlciB0aGFu IG1vZHVsZV9pbml0Lgo+ID4KPiBFaXRoZXIgd2F5IGlzIE9LLiBCdXQgbGl2ZSBpbiBtb2R1bGUg aW5pdCBpcyBlYXNpZXIgbm90IHRvIGluaXQgdHdpY2UKPiBmb3IgdHdvIGRldmljZXMuCgpUcnVl LCBidXQgSSB3YXMgdGhpbmtpbmcgbW9yZSBhYm91dCBpbml0aWFsaXppbmcgaXQgZm9yIDAgZGV2 aWNlcwp3aGljaCBjYW4gYmUgY29tbW9uIGlmIGJ1aWx0LWluIG9uIGEgbXVsdGktcGxhdGZvcm0g a2VybmVsLgoKPiA+ID4gK2ludCBsaW1hX3ZtX2JvX2FkZChzdHJ1Y3QgbGltYV92bSAqdm0sIHN0 cnVjdCBsaW1hX2JvICpibywgYm9vbCBjcmVhdGUpCj4gPiA+ICt7Cj4gPiA+ICsgICAgICAgc3Ry dWN0IGxpbWFfYm9fdmEgKmJvX3ZhOwo+ID4gPiArICAgICAgIGludCBlcnI7Cj4gPiA+ICsKPiA+ ID4gKyAgICAgICBtdXRleF9sb2NrKCZiby0+bG9jayk7Cj4gPiA+ICsKPiA+ID4gKyAgICAgICBi b192YSA9IGxpbWFfdm1fYm9fZmluZCh2bSwgYm8pOwo+ID4gPiArICAgICAgIGlmIChib192YSkg ewo+ID4gPiArICAgICAgICAgICAgICAgYm9fdmEtPnJlZl9jb3VudCsrOwo+ID4gPiArICAgICAg ICAgICAgICAgbXV0ZXhfdW5sb2NrKCZiby0+bG9jayk7Cj4gPiA+ICsgICAgICAgICAgICAgICBy ZXR1cm4gMDsKPiA+ID4gKyAgICAgICB9Cj4gPiA+ICsKPiA+ID4gKyAgICAgICAvKiBzaG91bGQg bm90IGNyZWF0ZSBuZXcgYm9fdmEgaWYgbm90IGFza2VkIGJ5IGNhbGxlciAqLwo+ID4gPiArICAg ICAgIGlmICghY3JlYXRlKSB7Cj4gPiA+ICsgICAgICAgICAgICAgICBtdXRleF91bmxvY2soJmJv LT5sb2NrKTsKPiA+ID4gKyAgICAgICAgICAgICAgIHJldHVybiAtRU5PRU5UOwo+ID4gPiArICAg ICAgIH0KPiA+ID4gKwo+ID4gPiArICAgICAgIGJvX3ZhID0ga3phbGxvYyhzaXplb2YoKmJvX3Zh KSwgR0ZQX0tFUk5FTCk7Cj4gPiA+ICsgICAgICAgaWYgKCFib192YSkgewo+ID4gPiArICAgICAg ICAgICAgICAgZXJyID0gLUVOT01FTTsKPiA+ID4gKyAgICAgICAgICAgICAgIGdvdG8gZXJyX291 dDA7Cj4gPiA+ICsgICAgICAgfQo+ID4gPiArCj4gPiA+ICsgICAgICAgYm9fdmEtPnZtID0gdm07 Cj4gPiA+ICsgICAgICAgYm9fdmEtPnJlZl9jb3VudCA9IDE7Cj4gPiA+ICsKPiA+ID4gKyAgICAg ICBtdXRleF9sb2NrKCZ2bS0+bG9jayk7Cj4gPiA+ICsKPiA+ID4gKyAgICAgICBlcnIgPSBkcm1f bW1faW5zZXJ0X25vZGUoJnZtLT5tbSwgJmJvX3ZhLT5ub2RlLCBiby0+Z2VtLnNpemUpOwo+ID4g PiArICAgICAgIGlmIChlcnIpCj4gPiA+ICsgICAgICAgICAgICAgICBnb3RvIGVycl9vdXQxOwo+ ID4gPiArCj4gPiA+ICsgICAgICAgZXJyID0gbGltYV92bV9tYXBfcGFnZV90YWJsZSh2bSwgYm8t PnBhZ2VzX2RtYV9hZGRyLCBib192YS0+bm9kZS5zdGFydCwKPiA+ID4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGJvX3ZhLT5ub2RlLnN0YXJ0ICsgYm9fdmEtPm5vZGUuc2l6 ZSAtIDEpOwo+ID4gPiArICAgICAgIGlmIChlcnIpCj4gPiA+ICsgICAgICAgICAgICAgICBnb3Rv IGVycl9vdXQyOwo+ID4gPiArCj4gPiA+ICsgICAgICAgbXV0ZXhfdW5sb2NrKCZ2bS0+bG9jayk7 Cj4gPiA+ICsKPiA+ID4gKyAgICAgICBsaXN0X2FkZF90YWlsKCZib192YS0+bGlzdCwgJmJvLT52 YSk7Cj4gPgo+ID4gU28geW91IGNhbiBoYXZlIDEgQk8gYXQgbXVsdGlwbGUgVkFzPyBJcyB0aGF0 IHJlYWxseSBuZWVkZWQ/Cj4gPgo+IEFjdHVhbGx5IDEgQk8gY2FuJ3QgaGF2ZSBtdWx0aSBWQSBp biBzaW5nbGUgVk0sIGJ1dCBvbmUgVkEgaW4gZWFjaCBWTS4KPiBXaGVuIGEgQk8gaXMgZXhwb3J0 ZWQvaW1wb3J0ZWQgYmV0d2VlbiB0d28gcHJvY2VzcywgaS5lLiB4c2VydmVyIGFuZCBjbGllbnQs Cj4gdHdvIHByb2Nlc3NlcyBoYXZlIGRpZmZlcmVudCBWTSwgc28gY2FuJ3QgbWFrZSBzdXJlIGl0 IGNhbiBiZSBtYXBwZWQgYXQgdGhlIHNhbWUKPiBwbGFjZS4KClJpZ2h0LCBidXQgd2hlbiB5b3Ug aW1wb3J0IGEgQk8sIGEgbmV3IEJPIHN0cnVjdCBpcyBjcmVhdGVkIGFuZAp0aGVyZWZvcmUgYSBu ZXcgbGlzdC4gSWYgdGhlcmUncyBvbmx5IDEgVkEsIHRoZW4geW91IGRvbid0IG5lZWQgYQpsaXN0 LiBKdXN0IG1vdmUgJ25vZGUnIGludG8gbGltYV9iby4gKEl0IGlzIHBvc3NpYmxlIEkgbWlzc2Vk IHNvbWUKZGV0YWlsIHRob3VnaC4pCgpSb2IKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vZHJpLWRldmVs