From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44802C2D0F2 for ; Tue, 31 Mar 2020 17:20:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CE1A20BED for ; Tue, 31 Mar 2020 17:20:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Xm4DyzFl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CE1A20BED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1DB9D6E86C; Tue, 31 Mar 2020 17:20:29 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id E6F026E86C for ; Tue, 31 Mar 2020 17:20:27 +0000 (UTC) Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 811FD214D8 for ; Tue, 31 Mar 2020 17:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585675227; bh=D7FWF2ylL+0NQ2FWuF8jpzvckwDCaUUfutqBPPPnLhY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Xm4DyzFlw4jGGUBlaafwQAckXswyUC7+wK8f9dZih9Eow6b2D8WjrmJf5p/Jld3fG gQB5Lnaki+PI71nuqEdqSxCB4N0N8kXzta0yDfuH9HdjW0bjHdxslO1Ws5cAcqT3op uQeXB1rPjS35avDSI+GNxcBACEkSyeQLXjnU25xY= Received: by mail-qt1-f178.google.com with SMTP id e14so19061193qts.2 for ; Tue, 31 Mar 2020 10:20:27 -0700 (PDT) X-Gm-Message-State: ANhLgQ2bxuODu/hZWYTbOGPhgNdTyhYBb7B18MehWQgKqRHqfUulSxVB L3lXqOz1iaGr406Ra0vngMJS1DiuiRY91/OE+Q== X-Google-Smtp-Source: ADFU+vuIDLlP6mJJzdijDIsPAvdYaGjDtb9aCWKF5WJKEAR+/umG5DoIAzKXfoqzc8KIaBO8hshbu4VG7fPqaOkBerA= X-Received: by 2002:aed:3461:: with SMTP id w88mr6324133qtd.143.1585675226482; Tue, 31 Mar 2020 10:20:26 -0700 (PDT) MIME-Version: 1.0 References: <20200315134416.16527-1-sam@ravnborg.org> <20200315134416.16527-33-sam@ravnborg.org> <20200319030734.GH29911@bogus> <20200329190352.GA21479@ravnborg.org> In-Reply-To: <20200329190352.GA21479@ravnborg.org> From: Rob Herring Date: Tue, 31 Mar 2020 11:20:13 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v1 32/36] dt-bindings: display: convert sharp, ls037v7dw01 to DT Schema To: Sam Ravnborg X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maxime Ripard , Nikolaus Schaller , Jonathan Bakker , Sandeep Panda , dri-devel , Paul Cercueil , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Chris Zhong , Marco Franchi , Stefan Mavrodiev , Jerry Han , Hoegeun Kwon , Tony Lindgren , Nickey Yang , Tomi Valkeinen , Jagan Teki , Robert Chiras , Vinay Simha BN , Marek Belisko , Heiko Schocher , Brian Masney , devicetree@vger.kernel.org, Guido Gunther , Mark Brown , Alexandre Courbot , Werner Johansson , Purism Kernel Team , Peter Ujfalusi , Lin Huang , Douglas Anderson , linux-spi , Peter Rosin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Mar 29, 2020 at 1:04 PM Sam Ravnborg wrote: > > Hi Rob. > > > > + > > > + mode-gpios: > > > + description: | > > > + GPIO ordered MO, LR, and UD as specified in LS037V7DW01.pdf > > > > 3 or... > > > > > + change configuration between QVGA and VGA mode and the > > > + scan direction. As these pins can be also configured > > > + with external pulls, all the GPIOs are considered > > > + optional with holes in the array. > > > > minItems: 3 > > maxItems: 5 > > This binding can specify up to three GPIOs like this: So it should be: minItems: 1 maxItems: 3 > > > + mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH /* gpio154, lcd MO */ > > > + &gpio1 2 GPIO_ACTIVE_HIGH /* gpio2, lcd LR */ > > > + &gpio1 3 GPIO_ACTIVE_HIGH>; /* gpio3, lcd UD */ > > They are in the linux kernel driver accessed like this: > > devm_gpiod_get_index(&pdev->dev, "mode", 2, GPIOD_OUT_LOW); > > The following is OK in the DT file: > > mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH>; > > mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH > &gpio1 2 GPIO_ACTIVE_HIGH>; > > mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH > &gpio1 2 GPIO_ACTIVE_HIGH > &gpio1 3 GPIO_ACTIVE_HIGH>; With the above, the 2nd 2 should fail... > But the following is not OK: > mode-gpios = <&gpio5 26 GPIO_ACTIVE_HIGH>, <&gpio1 2 GPIO_ACTIVE_HIGH>; And this should pass. We want phandle+arg type properties to be bracketed like this. If that's not working, then it's a bug in the tooling. Please confirm and I'll investigate. Rob _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel