From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAECDC433E2 for ; Mon, 8 Jun 2020 23:01:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A336F206D5 for ; Mon, 8 Jun 2020 23:01:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="QCmsWHtu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A336F206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC31689C98; Mon, 8 Jun 2020 23:01:55 +0000 (UTC) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by gabe.freedesktop.org (Postfix) with ESMTPS id C1DC389C83 for ; Mon, 8 Jun 2020 23:01:53 +0000 (UTC) Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 731462076C for ; Mon, 8 Jun 2020 23:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591657313; bh=E2VDSxyTsjme/SDDJYb/Ce8BPIu8k9mIpohu+7Y2fi4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=QCmsWHtuUrkP99N9zTwI1IYiExbKn+Evf9ftBvwrf3b5ttojeS+Hyn7Edq402+ZVR Qy7IVlA83KbFqbAghS2O1o9Vfm+cSqA6RtCL0MpFakR/wFQqZ6tZbJBuAzjZoGNeG2 9graD5Nhc6mPEcrc7kgBH5k8/4opuDcpntGKKAM4= Received: by mail-oi1-f174.google.com with SMTP id p70so16923278oic.12 for ; Mon, 08 Jun 2020 16:01:53 -0700 (PDT) X-Gm-Message-State: AOAM5314YzI3gcwAi+hZCt1x5e86XTJvfImRysaL4JdEF14evQCcgq91 33hPfKEi8bNxLbzzIeCzzP3i3L9ZZEJJ4syP2w== X-Google-Smtp-Source: ABdhPJxObAvxE+OOnTXcIgh61N2TLSHvj0BypJ4NL+n+aOPoAluENZ8Z4kbXmRaFm6G3U4eAOxdn3BnGxOwTfQQTlPQ= X-Received: by 2002:aca:d454:: with SMTP id l81mr1365615oig.152.1591657312818; Mon, 08 Jun 2020 16:01:52 -0700 (PDT) MIME-Version: 1.0 References: <20200529181833.GA2685451@bogus> <20200602150834.6xovwdxpgncq3ybh@gilmour> In-Reply-To: <20200602150834.6xovwdxpgncq3ybh@gilmour> From: Rob Herring Date: Mon, 8 Jun 2020 17:01:41 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 104/105] dt-bindings: display: vc4: hdmi: Add BCM2711 HDMI controllers bindings To: Maxime Ripard X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Tim Gover , Dave Stevenson , "linux-kernel@vger.kernel.org" , dri-devel , "maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE" , Nicolas Saenz Julienne , Phil Elwell , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2835 ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jun 2, 2020 at 9:08 AM Maxime Ripard wrote: > > Hi Rob, > > On Fri, May 29, 2020 at 12:18:33PM -0600, Rob Herring wrote: > > On Wed, May 27, 2020 at 05:49:14PM +0200, Maxime Ripard wrote: > > > The HDMI controllers found in the BCM2711 SoC need some adjustments to the > > > bindings, especially since the registers have been shuffled around in more > > > register ranges. > > > > > > Cc: Rob Herring > > > Cc: devicetree@vger.kernel.org > > > Signed-off-by: Maxime Ripard > > > --- > > > Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml | 109 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- > > > 1 file changed, 109 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > > > new file mode 100644 > > > index 000000000000..6091fe3d315b > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/display/brcm,bcm2711-hdmi.yaml > > > @@ -0,0 +1,109 @@ > > > +# SPDX-License-Identifier: GPL-2.0 > > > > Dual license... > > > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/display/brcm,bcm2711-hdmi.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Broadcom BCM2711 HDMI Controller Device Tree Bindings > > > + > > > +maintainers: > > > + - Eric Anholt > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - brcm,bcm2711-hdmi0 > > > + - brcm,bcm2711-hdmi1 > > > > What's the difference between the 2 blocks? > > The register layout and the lane mapping in the PHY change a bit. > > > > + > > > + reg: > > > + items: > > > + - description: HDMI controller register range > > > + - description: DVP register range > > > + - description: HDMI PHY register range > > > + - description: Rate Manager register range > > > + - description: Packet RAM register range > > > + - description: Metadata RAM register range > > > + - description: CSC register range > > > + - description: CEC register range > > > + - description: HD register range > > > + > > > + reg-names: > > > + items: > > > + - const: hdmi > > > + - const: dvp > > > + - const: phy > > > + - const: rm > > > + - const: packet > > > + - const: metadata > > > + - const: csc > > > + - const: cec > > > + - const: hd > > > + > > > + clocks: > > > + description: The HDMI state machine clock > > > + > > > + clock-names: > > > + const: hdmi > > > + > > > + ddc: > > > + allOf: > > > + - $ref: /schemas/types.yaml#/definitions/phandle > > > + description: > > > > + Phandle of the I2C controller used for DDC EDID probing > > > > Goes in the connector. > > > > And isn't the standard name ddc-i2c-bus? > > > > > + > > > + hpd-gpios: > > > + description: > > > > + The GPIO pin for the HDMI hotplug detect (if it doesn't appear > > > + as an interrupt/status bit in the HDMI controller itself) > > > > Goes in the connector. > > If this was an entirely new binding, I would agree, but this is not > really the case here. > > We discussed it already for the v2, and this binding is essentially the > same one than the bcm2835 HDMI controller. > > I initially sent a patch adding conditionnals for the clocks and regs > differences too, and you asked to split the binding into a separate file > to simplify it a bit. Ah... Best to assume I don't remember what happened last week. ;) > Supporting both the old binding, and the new one based on the connector > is going to make the code significantly more complicated, and I'm not > really sure why we would here. I'm not really sure I agree on the complexity, but that can be a discussion for another day. Reviewed-by: Rob Herring Rob _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel