From: Rob Herring <robh+dt@kernel.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
dri-devel <dri-devel@lists.freedesktop.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/6] dt-bindings: display: armada: Add display subsystem binding
Date: Fri, 22 Feb 2019 14:23:39 -0600 [thread overview]
Message-ID: <CAL_JsqJsfwC4fAJaVEvKwtZkZwapu5jojEFn6Ddx34a6jZ_dSQ@mail.gmail.com> (raw)
In-Reply-To: <b92426e9f5c50c71fa89ea5b53396c1885cc396f.camel@v3.sk>
On Wed, Feb 13, 2019 at 4:37 PM Lubomir Rintel <lkundrak@v3.sk> wrote:
>
> On Mon, 2019-01-21 at 09:35 -0600, Rob Herring wrote:
> > On Sun, Jan 20, 2019 at 11:26 AM Lubomir Rintel <lkundrak@v3.sk> wrote:
> > > The Marvell Armada DRM master device is a virtual device needed to list all
> > > nodes that comprise the graphics subsystem.
> > >
> > > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > > ---
> > > .../display/armada/marvell-armada-drm.txt | 24 +++++++++++++++++++
> > > 1 file changed, 24 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/display/armada/marvell-armada-drm.txt b/Documentation/devicetree/bindings/display/armada/marvell-armada-drm.txt
> > > index de4cca9432c8..3dbfa8047f0b 100644
> > > --- a/Documentation/devicetree/bindings/display/armada/marvell-armada-drm.txt
> > > +++ b/Documentation/devicetree/bindings/display/armada/marvell-armada-drm.txt
> > > @@ -1,3 +1,27 @@
> > > +Marvell Armada DRM master device
> > > +================================
> > > +
> > > +The Marvell Armada DRM master device is a virtual device needed to list all
> > > +nodes that comprise the graphics subsystem.
> > > +
> > > +Required properties:
> > > +
> > > + - compatible: value should be "marvell,dove-display-subsystem",
> > > + "marvell,armada-display-subsystem"
> > > + - ports: a list of phandles pointing to display interface ports of CRTC
> > > + devices
> > > + - memory-region: phandle to a node describing memory to be used for the
> > > + framebuffer
> > > +
> > > +Example:
> > > +
> > > + display-subsystem {
> > > + compatible = "marvell,dove-display-subsystem",
> > > + "marvell,armada-display-subsystem";
> > > + memory-region = <&display_reserved>;
> > > + ports = <&lcd0_port>;
> >
> > If there is only one device, you don't need this virtual node.
>
> Before I follow up on this and submit a version without the virtual
> node, I'm wondering: is it okay that the bindings for the LCDC and the
> framebuffer are in the same file, or would it be preferrable if they
> were separate? Both styles seem to be used for the display bindings.
framebuffer as in the kernel fbdev? Really, that should be the same
binding. It's the same h/w after all. However, there have been cases
where things deviated. So I don't have a good answer.
Rob
next prev parent reply other threads:[~2019-02-22 20:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-20 17:25 [PATCH 0/6] Bindings for Armada display subsystem Lubomir Rintel
2019-01-20 17:25 ` [PATCH 1/6] dt-bindings: display: armada: Rename the binding doc file Lubomir Rintel
2019-01-20 17:25 ` [PATCH 2/6] dt-bindings: display: armada: Improve the LCDC documentation Lubomir Rintel
2019-01-20 17:25 ` [PATCH 3/6] dt-bindings: display: armada: Add framebuffer reserved-mem binding Lubomir Rintel
2019-01-20 17:25 ` [PATCH 4/6] dt-bindings: display: armada: Add display subsystem binding Lubomir Rintel
2019-01-21 15:35 ` Rob Herring
2019-01-21 15:46 ` Lubomir Rintel
2019-01-21 16:07 ` Rob Herring
2019-01-21 17:53 ` Russell King - ARM Linux admin
2019-01-21 20:45 ` Lubomir Rintel
2019-01-21 23:08 ` Russell King - ARM Linux admin
2019-01-21 23:58 ` Rob Herring
2019-01-22 10:58 ` Russell King - ARM Linux admin
2019-01-22 16:06 ` Rob Herring
2019-02-13 22:37 ` Lubomir Rintel
2019-02-22 20:23 ` Rob Herring [this message]
2019-02-24 16:15 ` Lubomir Rintel
2019-03-04 17:35 ` Rob Herring
2019-01-20 17:25 ` [PATCH 5/6] dt-bindings: display: armada: Add mmp2 compatible strings Lubomir Rintel
2019-01-20 17:25 ` [PATCH 6/6] dt-bindings: display: armada: Document bus-width property Lubomir Rintel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqJsfwC4fAJaVEvKwtZkZwapu5jojEFn6Ddx34a6jZ_dSQ@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkundrak@v3.sk \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).