Re: [PATCH v1] dt-bindings: display: Add support for Intel KeemBay Display

[Rob Herring <robh@kernel.org>]

On Tue, Oct 6, 2020 at 8:00 PM Chrisanthus, Anitha
<anitha.chrisanthus@intel.com> wrote:
>
> Hi Rob,
> Thanks for the your prompt review. Please see my comments/questions inline.
> For everything else, I can incorporate the changes in v2.
> Anitha
>
> > -----Original Message-----
> > From: Rob Herring <robh@kernel.org>
> > Sent: Tuesday, October 6, 2020 2:08 PM
> > To: Chrisanthus, Anitha <anitha.chrisanthus@intel.com>
> > Cc: devicetree@vger.kernel.org; Paauwe, Bob J <bob.j.paauwe@intel.com>;
> > Dea, Edmund J <edmund.j.dea@intel.com>; sam@ravnborg.org;
> > narmstrong@baylibre.com
> > Subject: Re: [PATCH v1] dt-bindings: display: Add support for Intel KeemBay
> > Display
> >
> > On Fri, Oct 02, 2020 at 07:21:02PM -0700, Anitha Chrisanthus wrote:
> > > This patch adds bindings for Intel KeemBay Display
> > >
> > > Signed-off-by: Anitha Chrisanthus <anitha.chrisanthus@intel.com>
> > > ---
> > >  .../bindings/display/intel,kmb_display.yaml        | 106
> > +++++++++++++++++++++
> > >  1 file changed, 106 insertions(+)
> > >  create mode 100644
> > Documentation/devicetree/bindings/display/intel,kmb_display.yaml
> > >
> > > diff --git
> > a/Documentation/devicetree/bindings/display/intel,kmb_display.yaml
> > b/Documentation/devicetree/bindings/display/intel,kmb_display.yaml
> > > new file mode 100644
> > > index 0000000..65835cb
> > > --- /dev/null
> > > +++
> > b/Documentation/devicetree/bindings/display/intel,kmb_display.yaml
> > > @@ -0,0 +1,106 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only
> >
> > check checkpatch.pl
> >
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/display/intel,kmb_display.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Devicetree bindings for Intel Keem Bay display controller
> > > +
> > > +maintainers:
> > > +  - Anitha Chrisanthus <anitha.chrisanthus@intel.com>
> > > +  - Edmond J Dea <edmund.j.dea@intel.com>
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: intel,kmb_display
> >
> > 'keembay' was used elsewhere. Please be consistent.
> >
> > Don't use '_' either.
> Please note that I cannot change the name at this point as there is a dependency on the u-boot firmware which loads the device tree. I can change the name to kmb-drm or keembay-display when updated firmware becomes available.

That's unfortunate that you used bindings without a definition, but it
doesn't matter. If that was fine, then we should just stop documenting
bindings.

> > > +  reg:
> > > +    maxItems: 3
> >
> > Can drop, implied.
> >
> > > +    items:
> > > +      - description: Lcd registers range
> > > +      - description: Mipi registers range
> > > +      - description: Msscam registers range
> >
> > Is this really 1 h/w block? Don't really seem like it given addresses
> > aren't adjacent, separate clocks, and MIPI blocks are often licensed IP.
> Yes, these are part of the camera subsystem block of Intel Movidius Keembay SOC.

Then where's the camera parts? The DT should reflect the h/w, not
what's a convenient split for your drivers.

> Please see  https://lwn.net/Articles/833540/

This should be part of that series.

Rob
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel