From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F199C4363A for ; Tue, 27 Oct 2020 09:54:42 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9965E21D24 for ; Tue, 27 Oct 2020 09:54:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NItm7icc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9965E21D24 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E6F9E89FDB; Tue, 27 Oct 2020 09:54:40 +0000 (UTC) Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 48E1589FDB for ; Tue, 27 Oct 2020 09:54:40 +0000 (UTC) Received: by mail-lj1-x241.google.com with SMTP id i2so1037567ljg.4 for ; Tue, 27 Oct 2020 02:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dlZKihEU47KO2Q4wXh/mn6fHnYIgZzljB9zpEIZhZu8=; b=NItm7iccu0ev/qqIqm16sypSo+zBzIrorG1+c6Z1TIxSDMiFde0Hl2fmmVytXGIPPD LUqYzvXNdrn/eAoQPyJkQGEOzg/KQCozSg0VTGSehoiRmqxgpYU5dyPbAltUWZVWtI22 Lcik3pFj3nyaUisDmpa6H3njzoFOP7vl8a0x5K9ZYZJ9tBIHsq8uI1RfW2HU/yiYZkZc 62hfCxBEQCyDGv8jTCEOKes7HGS/39JLTUrwmdKXE7TtroN3BTYApJEhnfs+9YlVW4NJ lTJth/sVYP1UznAbFLGUOOBZaW3QbuNpIgg7jwyzRtYpztVG35s/xmhbPNSokIIBlsiZ 3ImA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dlZKihEU47KO2Q4wXh/mn6fHnYIgZzljB9zpEIZhZu8=; b=WYPJlgtSMBP9BooDKns+nhLLsUNo4pUcnjUUg8sv/GnBYX6esN6guSGr+0FZc1mCh/ ganPhcb9Qde1xmefD2VytG8wPfAG6Jc0WLsjI6XDf0XRxdHgaPuCRLUUmaS2mVtzRO9E IcQISiPocecMe1q17Q8YjiF5XXN9bZzyAPjWZYgiStA6AWPBgrT2jd1avL/ltIAs+qLY WJSmOig3PQxkwqS17B74q/WF+dmaL8QmXbPh1VqFrPqjPDOHnDldu2W+tSWAp3FJYbfl 6GuUWDkD0hJJUALQBsl+hdHVucWRzIYYvO2XfEfGgSlJydwn9BLvg53KKzLexzszcDVF ZexA== X-Gm-Message-State: AOAM533UB5VR8fyyWDLv/ABU0xy3m7bhARPE1y4MlkWW7I07XNjJHAb5 Ew7BzCeX8rl5lEwzqfhUSpEuxyIFdGBRPQb+9so= X-Google-Smtp-Source: ABdhPJzSgEcO8GMdK0RxR+ju00EjciXRlSPfuOfVG+uJDA3TOJd2ggA4xrukLCBlg743XPya5LfA3fGmXwMpmdQHRZw= X-Received: by 2002:a05:651c:11d2:: with SMTP id z18mr694563ljo.423.1603792478736; Tue, 27 Oct 2020 02:54:38 -0700 (PDT) MIME-Version: 1.0 References: <20201026194110.3817470-1-arnd@kernel.org> <20201026194110.3817470-4-arnd@kernel.org> <20201027093350.GI401619@phenom.ffwll.local> In-Reply-To: <20201027093350.GI401619@phenom.ffwll.local> From: Patrik Jakobsson Date: Tue, 27 Oct 2020 10:54:27 +0100 Message-ID: Subject: Re: [PATCH 4/4] drm/gma500: avoid Woverride-init warning To: Arnd Bergmann , Patrik Jakobsson , David Airlie , Stefan Christ , Arnd Bergmann , Thomas Zimmermann , Emil Velikov , Pankaj Bharadiya , Rikard Falkeborn , Paul Kocialkowski , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , dri-devel , linux-kernel X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Oct 27, 2020 at 10:33 AM Daniel Vetter wrote: > > On Mon, Oct 26, 2020 at 08:41:04PM +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > gcc -Wextra notices that one of the fields in psbfb_roll_ops has two > > initializers: > > > > drivers/gpu/drm/gma500/framebuffer.c:185:20: warning: initialized field overwritten [-Woverride-init] > > > > Open-code this instead, leaving out the extraneous initializers for > > .fb_pan_display. > > > > Fixes: 3da6c2f3b730 ("drm/gma500: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops") > > Signed-off-by: Arnd Bergmann > > Scrollback is dead, so I'm not sure it's even worth to keep all this. I'd > just garbage-collect this, maybe als the entire accelerator code and just > leave psbfb_unaccel_ops behind ... > -Daniel That's been my idea for quite some time. The gtt roll code is also broken in multi display setups. Arnd, I can take care of this unless you feel an urge to do it yourself. -Patrik _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel