From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21507C388F7 for ; Wed, 28 Oct 2020 14:41:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7AF7D2479E for ; Wed, 28 Oct 2020 14:41:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mM89ZJBb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7AF7D2479E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B5DA26E542; Wed, 28 Oct 2020 14:41:45 +0000 (UTC) Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 679DF6E542 for ; Wed, 28 Oct 2020 14:41:44 +0000 (UTC) Received: by mail-lj1-x242.google.com with SMTP id m16so6609412ljo.6 for ; Wed, 28 Oct 2020 07:41:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sJ4wXj2K7lJdOYLrd0jjyxtKvvbExzYsZz6tEJ6wk7o=; b=mM89ZJBbiOM2uifaVqXNKqSvyE2s1UPxX02cbg2psjG2RIj0UXsi1Jjgz1Oryq1Qpm nNtWV/Lrq7xaMOk1nJUvpvDcRkMIdXEYqEEPQNx0EvW2fb18AxSruEfievimQTV2NSfy d0ZLC0dIboHF2NU3uV6aWrN39eLuYFOWlQFDS8HE82cJyQv58B1iQYh8FUIVQimKPUBs MLmpU9GAuvttzfyZH62cYrJkwYEM6/nTI48cqRrX/HBH394+76DrhzeIYjoGxOMY6O/1 WuTtGpzaeuJe62Yr9yIyeS1BzuZq3pkYhGrezT1vDZgBDsXXtyz4klkHdsp/3vDFLiQ4 ehDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sJ4wXj2K7lJdOYLrd0jjyxtKvvbExzYsZz6tEJ6wk7o=; b=td9qKRdzWbyMvWZ29c77PJGC/Gj76AUhoMiiLH926gqqnwYmrGAUiWkt2UG0KhHxQK BeR1f187FjNdxbcNaE2j5R399n7BWoAjW9WjRpK31szABX97ECkmXBJUvgX53a4V1Bng +JvuifW+XGU8onbgDjl8PGnxKQYGVXpZ+gV+L4Ta1+47go6fc7GsRlABPWR5I0BVPLEA WYtE51G4FV7lV5e6+tkuZg3LFmOYvQbSWM489CYfLgtjse3LBm4AhM8muOwZ0Fx4pENi XHvOh6sppZt2FV1HuE8Wn5mTxoJOm+kcvAv1LP5x4IgRLy7I1z22oMCXg2Rj9B2gnErS /fGg== X-Gm-Message-State: AOAM5301i0el1ry03H4Uxb960EHbq5ktW0cyJVHPYJaAWOM/EiBADlzg IxtbBJThXIKZp0EkEkNLtOTbwd/SNo/QMK5waDk= X-Google-Smtp-Source: ABdhPJx8co+572PLantQaUV7Gqe51Vag+Xsh6dam5kO2twasvje9+9Se8vxhWJ1wtDg0J7s2tzvkIaPm0Y/N1NL42uQ= X-Received: by 2002:a2e:8706:: with SMTP id m6mr3509012lji.129.1603896102594; Wed, 28 Oct 2020 07:41:42 -0700 (PDT) MIME-Version: 1.0 References: <20201026194110.3817470-1-arnd@kernel.org> <20201026194110.3817470-4-arnd@kernel.org> <20201027093350.GI401619@phenom.ffwll.local> In-Reply-To: From: Patrik Jakobsson Date: Wed, 28 Oct 2020 15:41:31 +0100 Message-ID: Subject: Re: [PATCH 4/4] drm/gma500: avoid Woverride-init warning To: Arnd Bergmann X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , Pankaj Bharadiya , linux-kernel , Rikard Falkeborn , Paul Kocialkowski , dri-devel , Thomas Zimmermann , Daniel Vetter , Stefan Christ , Emil Velikov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Oct 27, 2020 at 5:50 PM Arnd Bergmann wrote: > > On Tue, Oct 27, 2020 at 10:54 AM Patrik Jakobsson > wrote: > > On Tue, Oct 27, 2020 at 10:33 AM Daniel Vetter wrote: > > > On Mon, Oct 26, 2020 at 08:41:04PM +0100, Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > > > > > gcc -Wextra notices that one of the fields in psbfb_roll_ops has two > > > > initializers: > > > > > > > > drivers/gpu/drm/gma500/framebuffer.c:185:20: warning: initialized field overwritten [-Woverride-init] > > > > > > > > Open-code this instead, leaving out the extraneous initializers for > > > > .fb_pan_display. > > > > > > > > Fixes: 3da6c2f3b730 ("drm/gma500: use DRM_FB_HELPER_DEFAULT_OPS for fb_ops") > > > > Signed-off-by: Arnd Bergmann > > > > > > Scrollback is dead, so I'm not sure it's even worth to keep all this. I'd > > > just garbage-collect this, maybe als the entire accelerator code and just > > > leave psbfb_unaccel_ops behind ... > > > -Daniel > > > > That's been my idea for quite some time. The gtt roll code is also > > broken in multi display setups. > > > > Arnd, I can take care of this unless you feel an urge to do it yourself. > > That would be good, thanks Should be fixed with: https://patchwork.freedesktop.org/patch/397482/?series=83153&rev=1 > > I have no specific interest in the drm drivers, this is just part of a > larger work to enable more of the W=1 options across the kernel > by default, after all the existing warnings are addressed. > > Arnd _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel