From: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
To: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] drm/gma500: fix a potential repeat execution in psb_driver_load
Date: Wed, 20 Apr 2022 09:34:30 +0200 [thread overview]
Message-ID: <CAMeQTsbV1ZcUf=ZRdzufxanRj5NJAor+SReA2Fnqk4kj13c94g@mail.gmail.com> (raw)
In-Reply-To: <20220413051105.5612-1-xiam0nd.tong@gmail.com>
On Wed, Apr 13, 2022 at 7:11 AM Xiaomeng Tong <xiam0nd.tong@gmail.com> wrote:
>
> Instead of exiting the loop as expected when an entry is found, the
> list_for_each_entry() continues until the traversal is complete. To
> avoid potential executing 'ret = gma_backlight_init(dev);' repeatly,
> goto outside the loop when found entry by replacing switch/case with
> if statement.
>
> Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Thanks for the patch. I've applied it to drm-misc-next.
I fixed up an indentation issue on the second line.
Cheers
Patrik
> ---
> changes since v2:
> - replace switch with if statement (Patrik Jakobsson)
>
> changes since v1:
> - goto outside the loop (Xiaomeng Tong)
>
> v2: https://lore.kernel.org/dri-devel/20220406113143.10699-1-xiam0nd.tong@gmail.com/
> v1: https://lore.kernel.org/lkml/20220401115811.9656-1-xiam0nd.tong@gmail.com/
> ---
> drivers/gpu/drm/gma500/psb_drv.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
> index 2aff54d505e2..85211ec16e52 100644
> --- a/drivers/gpu/drm/gma500/psb_drv.c
> +++ b/drivers/gpu/drm/gma500/psb_drv.c
> @@ -396,9 +396,8 @@ static int psb_driver_load(struct drm_device *dev, unsigned long flags)
> drm_for_each_connector_iter(connector, &conn_iter) {
> gma_encoder = gma_attached_encoder(connector);
>
> - switch (gma_encoder->type) {
> - case INTEL_OUTPUT_LVDS:
> - case INTEL_OUTPUT_MIPI:
> + if (gma_encoder->type == INTEL_OUTPUT_LVDS ||
> + gma_encoder->type == INTEL_OUTPUT_MIPI) {
> ret = gma_backlight_init(dev);
> break;
> }
> --
> 2.17.1
>
prev parent reply other threads:[~2022-04-20 7:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 5:11 [PATCH v3] drm/gma500: fix a potential repeat execution in psb_driver_load Xiaomeng Tong
2022-04-20 7:34 ` Patrik Jakobsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMeQTsbV1ZcUf=ZRdzufxanRj5NJAor+SReA2Fnqk4kj13c94g@mail.gmail.com' \
--to=patrik.r.jakobsson@gmail.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiam0nd.tong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).