From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jagan Teki Subject: Re: [PATCH v2 13/15] dt-bindings: sun6i-dsi: Add compatible for A64 DPHY Date: Thu, 25 Oct 2018 18:22:51 +0530 Message-ID: References: <20181023155035.9101-1-jagan@amarulasolutions.com> <20181023155035.9101-14-jagan@amarulasolutions.com> <20181024180927.ejt7odo23ebzjgfg@flea> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20181024180927.ejt7odo23ebzjgfg@flea> Sender: linux-kernel-owner@vger.kernel.org To: Maxime Ripard Cc: Chen-Yu Tsai , Icenowy Zheng , Jernej Skrabec , Vasily Khoruzhick , Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , David Airlie , dri-devel , Michael Turquette , Stephen Boyd , linux-clk , Michael Trimarchi , linux-arm-kernel , devicetree , linux-kernel , linux-sunxi@googlegroups.com List-Id: dri-devel@lists.freedesktop.org On Wed, Oct 24, 2018 at 11:39 PM Maxime Ripard wrote: > > On Tue, Oct 23, 2018 at 09:20:33PM +0530, Jagan Teki wrote: > > The MIPI DSI PHY HDMI controller on Allwinner A64 is similar > > on the one on A31. > > > > Add A64 compatible and append A31 compatible as fallback. > > > > Signed-off-by: Jagan Teki > > --- > > Changes for v2: > > - new patch > > > > Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > index 9fa6e7a758ad..704fb31962f2 100644 > > --- a/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > +++ b/Documentation/devicetree/bindings/display/sunxi/sun6i-dsi.txt > > @@ -36,7 +36,7 @@ D-PHY > > > > Required properties: > > - compatible: value must be one of: > > - * allwinner,sun6i-a31-mipi-dphy > > + * "allwinner,sun50i-a64-mipi-dphy", "allwinner,sun6i-a31-mipi-dphy" > > No. you need both. The A64 MIPI DPHY one needs to be always set with > the A31 fallback, but the A31 is also usable on its own. Why wouldn't be, because we don't have any difference dphy right?