From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7EF0C10F00 for ; Fri, 6 Mar 2020 08:00:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9724C20848 for ; Fri, 6 Mar 2020 08:00:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9724C20848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 231B96EC67; Fri, 6 Mar 2020 08:00:26 +0000 (UTC) Received: from mail-ot1-f66.google.com (mail-ot1-f66.google.com [209.85.210.66]) by gabe.freedesktop.org (Postfix) with ESMTPS id 933ED6EC67 for ; Fri, 6 Mar 2020 08:00:24 +0000 (UTC) Received: by mail-ot1-f66.google.com with SMTP id g96so1536470otb.13 for ; Fri, 06 Mar 2020 00:00:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vKvifh6khq6TLsSE0vcYSICDF7ZYlkhTtLvLZlGgCxw=; b=dxphUi6i23uH6Ky9QDLdUj3Y6AxftxG82UNgjkkXLLsNSU5u7+qq7x0EN0o9/uryYH k7hnalmeoRExHw9EM1oAXsjZdHu3W7eR0QzuldE7QL4UivFWxnGfEciNjt+Xc4PSNQCy URUZHypTJ4kjuxOFddamgmkMv+9h729kOy2gO0lT7b99ah1OAZImWkbjSp2s02sW2EqF +slm0eJ6T43k0Ciw/D17f/ehelpbflvNleXB6RqyvoTw0s983toPUvjeODTllkcloCgg So/xWuGOiUQQST1m11RQmZcRvXrtr902n6yoRFOznykCaZH8ecHLraBOZ7TePbvUoodj oVSA== X-Gm-Message-State: ANhLgQ2thQfzOB1X+nyyzvMav+O1luBYP+vCZELWsGahSXIX+bbEsipB 0MO9H+y7lgQ+zU6shtlV73HhGJ/VH2TNFiER78w= X-Google-Smtp-Source: ADFU+vslFJIqD7NVOi0pzRNQv5zGFctvmn9FUNf5MC80KDiKCIu60GrFhZuH4Qh4VMg4lJ9w+4Mit7IhEOnS7wS7kYc= X-Received: by 2002:a9d:b89:: with SMTP id 9mr1502003oth.297.1583481623780; Fri, 06 Mar 2020 00:00:23 -0800 (PST) MIME-Version: 1.0 References: <4b50cc9f-1434-b78a-d56a-fadfd030f002@infradead.org> In-Reply-To: <4b50cc9f-1434-b78a-d56a-fadfd030f002@infradead.org> From: Geert Uytterhoeven Date: Fri, 6 Mar 2020 09:00:12 +0100 Message-ID: Subject: Re: [RFC PATCH] drm: rcar-du: make all sub-symbols depend on DRM_RCAR_DU To: Randy Dunlap X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , LKML , Koji Matsuoka , dri-devel , Kieran Bingham , Linux-Renesas , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Randy, Thanks for your patch! On Fri, Mar 6, 2020 at 4:18 AM Randy Dunlap wrote: > From: Randy Dunlap > > DRM_RCAR_CMM depends on DRM_RCAR_DU. Since the following Kconfig > symbols do not depend on DRM_RCAR_DU, the menu presentation is > broken for these and following non-R-Car Kconfig symbols. > > Is it safe/appropriate to make all of these symbols depend on > DRM_RCAR_DU? It make the kconfig menu presentation much cleaner. I think it is. But I'd use a big "#if DRM_RCAR_DU" block instead of individual dependencies. > Signed-off-by: Randy Dunlap > --- linux-next-20200305.orig/drivers/gpu/drm/rcar-du/Kconfig > +++ linux-next-20200305/drivers/gpu/drm/rcar-du/Kconfig > @@ -24,6 +24,7 @@ config DRM_RCAR_CMM > config DRM_RCAR_DW_HDMI > tristate "R-Car DU Gen3 HDMI Encoder Support" > depends on DRM && OF > + depends on DRM_RCAR_DU > select DRM_DW_HDMI > help > Enable support for R-Car Gen3 internal HDMI encoder. > @@ -31,6 +32,7 @@ config DRM_RCAR_DW_HDMI > config DRM_RCAR_LVDS > tristate "R-Car DU LVDS Encoder Support" > depends on DRM && DRM_BRIDGE && OF > + depends on DRM_RCAR_DU > select DRM_PANEL > select OF_FLATTREE > select OF_OVERLAY > @@ -47,4 +49,5 @@ config DRM_RCAR_VSP > > config DRM_RCAR_WRITEBACK > bool > + depends on DRM_RCAR_DU > default y if ARM64 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel