From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6B64C4320A for ; Tue, 10 Aug 2021 15:52:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CEAF60E97 for ; Tue, 10 Aug 2021 15:52:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3CEAF60E97 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6411A89056; Tue, 10 Aug 2021 15:52:11 +0000 (UTC) Received: from mail-ua1-f54.google.com (mail-ua1-f54.google.com [209.85.222.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id DAF7589056 for ; Tue, 10 Aug 2021 15:52:09 +0000 (UTC) Received: by mail-ua1-f54.google.com with SMTP id 67so8772707uaq.4 for ; Tue, 10 Aug 2021 08:52:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=14LcusME7ZZfpCeACy1bKOoqz1QHnlL2Rh15LgCjnUM=; b=MFakciBTGG/pR790SxtK1JFvvC8TfByEeFHXu65LrqGT6PgNFPq+qyoNL17kYRnRuN NJXBMHCMcvM/cATSSe9xVCdMfy9v/BqK862K8e0I47miTB+4njkZgOC+sq0IjVD5jqIP HsD2i1snoIrKSmL7ILftxNM61k9bprv0aQA2wwL3xjRoI0eiULMZqRjXcEfcDRs96m4p rhPB50Xh+kzXZmUK2exRNciLYxX9BxKNz2Nmss/tUUKhIOtQ1qoGPJf4tAlrmWOHvYPm xgwBS9Av6lTWqkJhwvz6DX9VKfXuqPkkCLnQVZx2UqOl4BdusbrSxrEEIM4MIlMdvWlF vOjA== X-Gm-Message-State: AOAM532b0i4SzS8D3pUKSiG2vJNx11iGAc8Ri3oUirkq2SRJo8Y4SSHS 2f13iUuo9eUHIMP38gks9ySm2Hxf32ofy9+ss1c= X-Google-Smtp-Source: ABdhPJzMiPuuaYmNZzOEPR3m6Kf8XRk4wl132UekAFkhbG+LrgoQfXmV1JRJFkoaLWJGjv5ooMmspv0RafumgJ3SaH4= X-Received: by 2002:a9f:2341:: with SMTP id 59mr21031577uae.4.1628610728962; Tue, 10 Aug 2021 08:52:08 -0700 (PDT) MIME-Version: 1.0 References: <20210520065046.28978-1-laurent.pinchart+renesas@ideasonboard.com> <20210520065046.28978-3-laurent.pinchart+renesas@ideasonboard.com> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 10 Aug 2021 17:51:57 +0200 Message-ID: Subject: Re: [PATCH v3 2/4] drm: rcar-du: lvds: Convert to DRM panel bridge helper To: Laurent Pinchart Cc: DRI Development , Linux-Renesas , Kieran Bingham Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Laurent, On Tue, Aug 10, 2021 at 5:47 PM Geert Uytterhoeven wrote: > On Thu, May 20, 2021 at 8:51 AM Laurent Pinchart > wrote: > > Replace the manual panel handling with usage of the DRM panel bridge > > helper. This simplifies the driver, and brings support for > > DRM_BRIDGE_ATTACH_NO_CONNECTOR as an added bonus. > > > > Signed-off-by: Laurent Pinchart > > Thanks for your patch, which is now commit e9e056949c927e5b ("drm: > rcar-du: lvds: Convert to DRM panel bridge helper") in drm-next. > > This causes the following scary messages in the kernel log on Ebisu-4D: > > [drm:drm_bridge_attach] *ERROR* failed to attach bridge > Reverting this commit fixes the issue. Oops, that's not true (should not write tentative messages while booting a test kernel, and press send without checking first ;-) Reverting the commit doesn't seem to make a difference. But the parent 5bcc48395b9f35da ("drm: bridge: dw-hdmi: Attach to next bridge if available") of the bad commit is fine. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds