From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Cyril Brulebois <cyril@debamax.com>
Cc: linux-fbdev@vger.kernel.org,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
stable@vger.kernel.org, Thomas Zimmermann <tzimmermann@suse.de>,
Michal Suchanek <msuchanek@suse.de>
Subject: Re: [PATCH 2/2] drm/ofdrm: Update expected device name
Date: Mon, 24 Apr 2023 09:33:32 +0200 [thread overview]
Message-ID: <CAMuHMdW4rZn4p=gQZRWQQSEbQPmzZUd5eN+kP_Yr7bLgTHyvig@mail.gmail.com> (raw)
In-Reply-To: <20230412095509.2196162-3-cyril@debamax.com>
Hi Cyril,
CC DT
On Wed, Apr 12, 2023 at 12:05 PM Cyril Brulebois <cyril@debamax.com> wrote:
> Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"),
> as spotted by Frédéric Bonnard, the historical "of-display" device is
> gone: the updated logic creates "of-display.0" instead, then as many
> "of-display.N" as required.
>
> This means that offb no longer finds the expected device, which prevents
> the Debian Installer from setting up its interface, at least on ppc64el.
>
> Given the code similarity it is likely to affect ofdrm in the same way.
>
> It might be better to iterate on all possible nodes, but updating the
> hardcoded device from "of-display" to "of-display.0" is likely to help
> as a first step.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217328
> Link: https://bugs.debian.org/1033058
> Fixes: 241d2fb56a18 ("of: Make OF framebuffer device names unique")
> Cc: stable@vger.kernel.org # v6.2+
> Signed-off-by: Cyril Brulebois <cyril@debamax.com>
Thanks for your patch, which is now commit 3a9d8ea2539ebebd
("drm/ofdrm: Update expected device name") in fbdev/for-next.
> --- a/drivers/gpu/drm/tiny/ofdrm.c
> +++ b/drivers/gpu/drm/tiny/ofdrm.c
> @@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display);
>
> static struct platform_driver ofdrm_platform_driver = {
> .driver = {
> - .name = "of-display",
> + .name = "of-display.0",
> .of_match_table = ofdrm_of_match_display,
> },
> .probe = ofdrm_probe,
Same comment as for "[PATCH 1/2] fbdev/offb: Update expected device
name".
https://lore.kernel.org/r/CAMuHMdVGEeAsmb4tAuuqqGJ-4+BBETwEwYJA+M9NyJv0BJ_hNg@mail.gmail.com
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
next prev parent reply other threads:[~2023-04-24 7:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 9:55 Updating hardcoded "of-display" devices Cyril Brulebois
2023-04-12 9:55 ` [PATCH 1/2] fbdev/offb: Update expected device name Cyril Brulebois
2023-04-16 12:34 ` Salvatore Bonaccorso
2023-06-15 13:03 ` Linux regression tracking (Thorsten Leemhuis)
2023-06-15 13:06 ` Thomas Zimmermann
2023-06-15 13:21 ` Michal Suchánek
2023-06-15 20:09 ` Rob Herring
2023-06-15 21:19 ` Cyril Brulebois
2023-06-20 6:24 ` Helge Deller
2023-06-20 8:04 ` Michal Suchánek
2023-06-15 13:12 ` Cyril Brulebois
2023-04-22 9:50 ` Helge Deller
2023-04-24 7:31 ` Geert Uytterhoeven
2023-07-10 16:36 ` Michal Suchánek
2023-04-12 9:55 ` [PATCH 2/2] drm/ofdrm: " Cyril Brulebois
2023-04-24 7:33 ` Geert Uytterhoeven [this message]
2023-04-24 9:07 ` Thomas Zimmermann
2023-04-24 9:35 ` Helge Deller
2023-05-22 9:37 ` Linux regression tracking (Thorsten Leemhuis)
2023-05-22 11:44 ` Michal Suchánek
2023-07-10 16:36 ` Michal Suchánek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdW4rZn4p=gQZRWQQSEbQPmzZUd5eN+kP_Yr7bLgTHyvig@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=cyril@debamax.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msuchanek@suse.de \
--cc=stable@vger.kernel.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).