From: Geert Uytterhoeven <geert@linux-m68k.org>
To: carlis <zhangxuezhi3@gmail.com>
Cc: driverdevel <devel@driverdev.osuosl.org>,
Linux Fbdev development list <linux-fbdev@vger.kernel.org>,
mh12gx2825@gmail.com, Stefano Brivio <sbrivio@redhat.com>,
Greg KH <gregkh@linuxfoundation.org>,
oliver.graute@kococonnector.com,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Kari Argillander <kari.argillander@gmail.com>,
Colin King <colin.king@canonical.com>,
zhangxuezhi1@yulong.com
Subject: Re: [PATCH v10] staging: fbtft: add tearing signal detect
Date: Thu, 28 Jan 2021 12:15:28 +0100 [thread overview]
Message-ID: <CAMuHMdX50YJ6_=maJveDk=dh+suFeCEtarWrqoP_gNMP9k922Q@mail.gmail.com> (raw)
In-Reply-To: <20210128190301.00007ebe@gmail.com>
Hi Carlis,
On Thu, Jan 28, 2021 at 12:03 PM carlis <zhangxuezhi3@gmail.com> wrote:
> On Thu, 28 Jan 2021 10:42:54 +0100
> Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> > On Thu, Jan 28, 2021 at 7:53 AM Kari Argillander
> > <kari.argillander@gmail.com> wrote:
> > > On Thu, Jan 28, 2021 at 09:42:58AM +0800, carlis wrote:
> > > > On Thu, 28 Jan 2021 00:32:22 +0200
> > > > Kari Argillander <kari.argillander@gmail.com> wrote:
> > > > > > #include "fbtft.h"
> > > > > >
> > > > > > #define DRVNAME "fb_st7789v"
> > > > > > @@ -66,6 +69,32 @@ enum st7789v_command {
> > > > > > #define MADCTL_MX BIT(6) /* bitmask for column address order
> > > > > > */ #define MADCTL_MY BIT(7) /* bitmask for page address order
> > > > > > */
> > > > > >
> > > > > > +#define SPI_PANEL_TE_TIMEOUT 400 /* msecs */
> > > > > > +static struct mutex te_mutex;/* mutex for set te gpio irq
> > > > > > status */
> > > > >
> > > > > Space after ;
> > > > hi, i have fix it in the patch v11
> > > > >
> > >
> > > Yeah sorry. I accidentally review wrong patch. But mostly stuff are
> > > still relevant.
> > >
> > > > > > @@ -82,6 +111,33 @@ enum st7789v_command {
> > > > > > */
> > > > > > static int init_display(struct fbtft_par *par)
> > > > > > {
> > > > > > + int rc;
> > > > > > + struct device *dev = par->info->device;
> > > > > > +
> > > > > > + par->gpio.te = devm_gpiod_get_index_optional(dev, "te", 0,
> > > > > > GPIOD_IN);
> > > > > > + if (IS_ERR(par->gpio.te)) {
> > > > > > + rc = PTR_ERR(par->gpio.te);
> > > > > > + dev_err(par->info->device, "Failed to request te
> > > > > > gpio: %d\n", rc);
> > > > > > + return rc;
> > > > > > + }
> > > > >
> > > > > You request with optinal and you still want to error out? We
> > > > > could just continue and not care about that error. User will be
> > > > > happier if device still works somehow.
> >
> > devm_gpiod_get_index_optional() returns NULL, not an error, if the
> > GPIO is not found. So if IS_ERR() is the right check.
> >
> > And checks for -EPROBE_DEFER can be handled automatically
> > by using dev_err_probe() instead of dev_err().
> >
> hi, i fix it like below!?
> par->gpio.te = devm_gpiod_get_index_optional(dev, "te", 0,
> GPIOD_IN); if (IS_ERR(par->gpio.te)) {
> rc = PTR_ERR(par->gpio.te);
> dev_err_probe(par->info->device, rc, "Failed to request
> te gpio\n"); return rc;
> }
> if (par->gpio.te) {
> init_completion(&spi_panel_te);
> rc = devm_request_irq(dev,
> gpiod_to_irq(par->gpio.te),
> spi_panel_te_handler,
> IRQF_TRIGGER_RISING, "TE_GPIO", par);
> if (rc) {
> dev_err(par->info->device, "TE request_irq
> failed.\n"); return rc;
dev_err_probe()
> }
>
> disable_irq_nosync(gpiod_to_irq(par->gpio.te));
> } else {
> dev_info(par->info->device, "%s:%d, TE gpio not
> specified\n", __func__, __LINE__);
> }
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2021-01-28 11:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 13:42 [PATCH v10] staging: fbtft: add tearing signal detect Carlis
2021-01-27 13:51 ` Greg KH
2021-01-27 14:08 ` carlis
2021-01-27 14:13 ` Greg KH
2021-01-27 14:17 ` carlis
2021-01-27 14:25 ` Greg KH
2021-01-27 14:49 ` Dan Carpenter
2021-01-27 15:02 ` Greg KH
2021-01-28 1:12 ` carlis
2021-01-27 17:42 ` Joe Perches
2021-01-27 18:21 ` Joe Perches
2021-01-27 22:32 ` Kari Argillander
2021-01-28 1:42 ` carlis
2021-01-28 6:52 ` Kari Argillander
2021-01-28 9:24 ` carlis
2021-01-28 9:42 ` Geert Uytterhoeven
2021-01-28 9:59 ` Kari Argillander
2021-01-28 11:03 ` carlis
2021-01-28 11:15 ` Geert Uytterhoeven [this message]
2021-01-28 11:42 ` carlis
2021-01-28 15:13 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMuHMdX50YJ6_=maJveDk=dh+suFeCEtarWrqoP_gNMP9k922Q@mail.gmail.com' \
--to=geert@linux-m68k.org \
--cc=colin.king@canonical.com \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kari.argillander@gmail.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mh12gx2825@gmail.com \
--cc=oliver.graute@kococonnector.com \
--cc=sbrivio@redhat.com \
--cc=zhangxuezhi1@yulong.com \
--cc=zhangxuezhi3@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).