From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Airlie Subject: Re: [PATCH 3/4] drm/doc: integrate fb helper reference into docs Date: Wed, 28 Nov 2012 20:31:39 +1000 Message-ID: References: <1351777518-11212-1-git-send-email-daniel.vetter@ffwll.ch> <1351777518-11212-3-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-qc0-f177.google.com (mail-qc0-f177.google.com [209.85.216.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 5EB1AE5F56 for ; Wed, 28 Nov 2012 02:31:40 -0800 (PST) Received: by mail-qc0-f177.google.com with SMTP id u28so9440064qcs.36 for ; Wed, 28 Nov 2012 02:31:39 -0800 (PST) In-Reply-To: <1351777518-11212-3-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: DRI Development List-Id: dri-devel@lists.freedesktop.org On Thu, Nov 1, 2012 at 11:45 PM, Daniel Vetter wrote: > Again only minimal changes to make kerneldoc no longer shout. Plus a > little introduction in the form of a inline DOC: section to quickly > explain what this is all about. Did someone build these? > diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c > index 4d58d7e..320dcbc 100644 > --- a/drivers/gpu/drm/drm_fb_helper.c > +++ b/drivers/gpu/drm/drm_fb_helper.c > @@ -41,7 +41,14 @@ MODULE_AUTHOR("David Airlie, Jesse Barnes"); > MODULE_DESCRIPTION("DRM KMS helper"); > MODULE_LICENSE("GPL and additional rights"); > > -static LIST_HEAD(kernel_fb_helper_list); because that one liner seriously harshes my buzz. Do better next time! Dave.