From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCE82C47080 for ; Tue, 1 Jun 2021 07:20:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7C39E61396 for ; Tue, 1 Jun 2021 07:20:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C39E61396 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AA56E89FCE; Tue, 1 Jun 2021 07:20:01 +0000 (UTC) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5486889FCE; Tue, 1 Jun 2021 07:19:59 +0000 (UTC) Received: by mail-ed1-x536.google.com with SMTP id s6so15998419edu.10; Tue, 01 Jun 2021 00:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=aMuf6Zwvp9YE1uES5A5ymwviB/xP/Pc8uTaTSOxuvrs=; b=FAAXlQjKM8H1PukR8U+yUhU1LuCMnIY0FZ+b11BqqiQiKryFEA71318JnamPNIDf72 XSPwR+MIF47K218IhIWX/xoolr/NIuC5geEp3L+k/SO7n0l4tmJKowjygcCby8Bqo6Bv 3vwd8oLbcypiBqQr/ngCql3r6v4IEO/81Vok30X8z6lGSz8aZ8dg0xT2zFZv1IwqbT68 qedl1jy29LWOR2Zo5wk6TpbNNL+2sbkDy+zcJfzxrx69ym//T82rl6V+r0TSxuJO6wEa Fq24FhF4VkUi5ahfrKuDhx0EPIxS1DUluuojcQFlXfmZY2YMrbFL8bKwwJViqPa9aApg /QTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=aMuf6Zwvp9YE1uES5A5ymwviB/xP/Pc8uTaTSOxuvrs=; b=Tga5jT9S1610NRLzmSQ/vDauBcRxYb1BcnNO2iIMxae8TKkdkksZAFcDvricIq9GTA U30amNv5C3vzaXp6ve95Bk0g3X3wYPMT0DvQuKv6H1IuEDS1k0MX/aSsBj6yaLuf/W+D hJzG9AIuwfG1N2TEBHmtuv7ZMN9fIcLLiquRc5lIPUP29X2fJFAIQ9eM7X3hgTTZ5ffu d7uajO2jIOFenDp3hQeG1WaRSzzC7MG0iS+lYjQAVMxJvUOBrjykvqOBz85nI8tVFe9j 0QicDCPb5YbW2a9mdi3F6Eocf4BiA3zrtotjDiYQvZQmp8OUQn+2PqjbTOvscxRv8P2j k1LQ== X-Gm-Message-State: AOAM530fOJs5xCv2iEtWspjH4e4z5yoioM+Lx72b8xpLntLNYqb+6tb7 GGJZtyWOJZ3QgeMipCpMmBk81GxWX5niIjZYFqI= X-Google-Smtp-Source: ABdhPJw07s13De4fMTEbLWOPPhXYF72ptxy3HLqB6iX0ULdMVX84nZGRgfFUDn0OkU3AuDwHAFl5aVjr9YfjR4D8yzg= X-Received: by 2002:aa7:d7d5:: with SMTP id e21mr30782027eds.78.1622531998562; Tue, 01 Jun 2021 00:19:58 -0700 (PDT) MIME-Version: 1.0 References: <20210511083139.54002-1-zbigniew.kempczynski@intel.com> In-Reply-To: From: Dave Airlie Date: Tue, 1 Jun 2021 17:19:47 +1000 Message-ID: Subject: Re: [Intel-gfx] [PATCH] drm/i915: Add relocation exceptions for two other platforms To: Daniel Vetter Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dave Airlie , =?UTF-8?Q?Zbigniew_Kempczy=C5=84ski?= , Intel Graphics Development , dri-devel , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 27 May 2021 at 20:04, Daniel Vetter wrote: > > On Wed, May 26, 2021 at 10:35:49AM +1000, Dave Airlie wrote: > > On Wed, 12 May 2021 at 03:05, Daniel Vetter wrote: > > > On Tue, May 11, 2021 at 10:31:39AM +0200, Zbigniew Kempczy=C5=84ski w= rote: > > > > We have established previously we stop using relocations starting > > > > from gen12 platforms with Tigerlake as an exception. Unfortunately > > > > we need extend transition period and support relocations for two > > > > other igfx platforms - Rocketlake and Alderlake. > > > > > > > > Signed-off-by: Zbigniew Kempczy=C5=84ski > > > > Cc: Dave Airlie > > > > Cc: Daniel Vetter > > > > Cc: Jason Ekstrand > > > > > > So the annoying thing here is that now media-driver is fixed: > > > > > > https://github.com/intel/media-driver/commit/144020c37770083974bedf59= 902b70b8f444c799 > > > > > > Which means igt is really the only thing left. > > > > > > Dave, is this still ok for an acked exception, or is this now leaning > > > towards "just fix igt"? > > > > Oh that isn't great is it, I had thought it was the media-driver, > > keeping a big uAPI like this open just for the test code seems a bit > > silly. I get the tests are testing more than just relocs, but it's a > > pretty big interface to leave lying around if we can avoid it. > > So since we need to do the work anyway for DG1+ what about some interim > hack? Currently ADL still has the require_force_probe flag set. We could > re-enable relocations just for ADL, only while this flag is set. This > gives us a bunch of wiggle room, unblocks everything else (CI is a bit on > fire right now due to this and practially unuseable on ADL gem areay) and > we'll still make sure that when ADL is all done we wont expose relocation= s > just for igt. > > Thoughts? I can handle that as a compromise, though I'd not want to block ADL getting out of alpha over some IGT that needs porting. Dave. > -Daniel > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch