From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F205FC433DF for ; Fri, 29 May 2020 02:03:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B2C952075F for ; Fri, 29 May 2020 02:03:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="S7nH/71V" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B2C952075F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1FED76E851; Fri, 29 May 2020 02:03:00 +0000 (UTC) Received: from mail-ej1-x643.google.com (mail-ej1-x643.google.com [IPv6:2a00:1450:4864:20::643]) by gabe.freedesktop.org (Postfix) with ESMTPS id 782A46E851 for ; Fri, 29 May 2020 02:02:58 +0000 (UTC) Received: by mail-ej1-x643.google.com with SMTP id n24so504659ejd.0 for ; Thu, 28 May 2020 19:02:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zR58kZNkDITa3zkTRVIi9Vv+iIxtpv5vYAhOcit9LUI=; b=S7nH/71Vpr+3SyllwwS7tZsIiGVMAwRxpn8tZQtlVVfv/+0pwrXniGDAQvL1xS3QGh j6N9ySgl9oxTOxSVpeny4vGIA6onFpb515ACrcnkxQTqc1dqXG8z9eaOvZHmoWh0akmB 5U4Atvj08baUPGMWPrBO1BEvWLBUaVvbH0c1TeogyPJOl4K19F1bbpp1lQqcbTK0BYp/ Oh+u3eLTF8/bxle3ZJeAhloD3xA8CtaoFsz0QXeCFsyPlMH0XNAqAi3E4rEz6T8uqVYF vDYPeTu4h1FukdrMd5O9hL8GDb10nzpEqwpXYBgmK2mm6HQ5YQTn2szUINiCvgaYbB0X r4pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zR58kZNkDITa3zkTRVIi9Vv+iIxtpv5vYAhOcit9LUI=; b=DDzOUer5CK0Re2RPKTs/3WyBXgcQr49wwdfxtEg0SYvPEgkm0kXtXNg9wEsvtS+F1t Spz0yoLy5iz87FrZfZASCD5ONKYohDAtdhh7CpJiHWcHAOPEipKNE2X/pL1XN7Xxma8X D4TJI5EmSmCamu8T7ben2aX4anSBijlbAHrGm4tw0xqTqo3k/pB90EVwmU1/EK4m420/ nnT2LxSbiSSQ5WXxsH2iiMrtALKx6ecF9leJ5gdDiVcZct9doZS1jnISorkB45AQ9G+I kj1XKk4uUoGqnO2qCp+TzaOPtRrtRSEymf+u/yuCMZMMg1e6woLOp+FFyJf6aT/OI8u2 q4Lw== X-Gm-Message-State: AOAM531XqBoVD0aGaj3DoJfu6WntnjPRr9v8VA7r044zMJfdJe5oiFof jvVrv7rl9H2m++P2i7gNCLd3Gh1aulJA0vP8iew= X-Google-Smtp-Source: ABdhPJwCHqfRwTsoKAcO4U64g1rHpI/UOlZrfwrpHlnqUK2gBOvZPVU1dHxRLKJPnEFuqYpl9g4tjOjUiq/dxLRQpJA= X-Received: by 2002:a17:906:fb0e:: with SMTP id lz14mr5481366ejb.237.1590717777003; Thu, 28 May 2020 19:02:57 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Airlie Date: Fri, 29 May 2020 12:02:45 +1000 Message-ID: Subject: Re: [git pull] drm fixes for 5.7-rc8/final To: Linus Torvalds X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Rodrigo Vivi , LKML , dri-devel , Chris Wilson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, 29 May 2020 at 11:49, Linus Torvalds wrote: > > On Thu, May 28, 2020 at 5:21 PM Dave Airlie wrote: > > > > Seems to have wound down nicely, a couple of i915 fixes, amdgpu fixes > > and minor ingenic fixes. > > Dave, this doesn't even build. WTF? > > In drivers/gpu/drm/i915/gt/selftest_lrc.c, there's a > engine_heartbeat_disable() function that takes two arguments, but the > new "live_timeslice_nopreempt()" gives it only one. > > I'd blame a merge problem, since the failure is in new code, but the > problem exists in your top-of-tree, not just my merge. > > In fact, it's not even your merge of the i915 tree that is the source > of the problem (although the fact that you clearly didn't _test_ the > end result most definitely is _part_ of the problem!). > > Because the problem exists in the commit that introduced that thing: > commit 1f65efb624c4 ("drm/i915/gt: Prevent timeslicing into > unpreemptable requests"). > > It's garbage, and never compiled. I thought I'd dropped the ball completely. but I see it's a selftest failure, I must not have selftests built in my config here, I don't do exhaustive builds randconfig This has also been built by Intel, but I'm assuming they missed their selftest bits as well. I'll revert that and resend. Sorry for the noise. I'll add self tests to my builds here for future ones. Dave. _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel