From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2194C433EB for ; Tue, 28 Jul 2020 11:40:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92EF4206D4 for ; Tue, 28 Jul 2020 11:40:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="BIlUz2QY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92EF4206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0AD276E283; Tue, 28 Jul 2020 11:40:44 +0000 (UTC) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7113E6E283 for ; Tue, 28 Jul 2020 11:40:42 +0000 (UTC) Received: by mail-wr1-x441.google.com with SMTP id r2so12881332wrs.8 for ; Tue, 28 Jul 2020 04:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TarT8FJy4xxh1Gu95tM1MOrQBSTLu+L0cNKerMl6tuM=; b=BIlUz2QYxFWzzF/PGXouifAVShEdvViFuBcAvy11rSq1/UB3TPjN7cDoyPiYLXMGbE wMbfEszWmq6MQz43NGegaGCTgKkNGFFlEd8U7O868CP4tprwvtl5q9N3//jweqWAoxxc ViHZhLSVULlg1K/JYXV3GQJnuOpvZ5ihctOpovBbCRV+fC2WP5VRqheKMrgizTs8AaEm TKpDzIjehfn+zwRq/MR79ctzf0Bpb6beoozBqRgNhS1l1GCds1QqS4WVVolNx+gvcyUk p5KoK5+g+A4xIfsgxbPDcFl5QtWVgix3eV/Y5LTJ9A/Od5o+TRrdAyC2L/e9YgXNazw7 XlMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TarT8FJy4xxh1Gu95tM1MOrQBSTLu+L0cNKerMl6tuM=; b=piLFg8Em02xIiPl74tY2otyDUo0DEjzjhcBeOnl3XCWBCEf09gQCZeqwMu6lVSAlYj bZcxkx2T2+uhrK66wKvgkYP3fPubmkvHCJjNjdLD174UMANHIyizQXfE8Tt7cFABhjhp ZIOQxSRlQJi+P+yKzJ7JXGRRQQDwijSF3X2SZJMhEvXQHX9kZM96NP/eIjeqKc2A2pHO 2pNEZvlepNDgWo4QMoUdZWTFggBueDECgeFwUvrbLz3C1GOyTOKN1xJcThFshXcw//ed uA6w1lpUEEXjj5LBjJztmkuPA70rGYSe+PQOOTbKDmTHVv34MCe1nR0LRgPOveIAecfU df8Q== X-Gm-Message-State: AOAM532p9DM7YKNl0ehrKxWXFZvXeHjJ3vT/vaB1wuHAOWVECbE2oNKL o1LtpJQWKPDZ/wT/ZSzrJo5VKCpcXIud9iWWuxeuqg== X-Google-Smtp-Source: ABdhPJyAsLE0Fke7ELR7oeZm8VYO8/GGUEGfQKuUxFj/9hE+upxSUPAEcs2CfEI7Hs0Jh3gu2ANZ6pBVtbr+FcTlaC4= X-Received: by 2002:a5d:6681:: with SMTP id l1mr23497356wru.47.1595936441188; Tue, 28 Jul 2020 04:40:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Stevenson Date: Tue, 28 Jul 2020 12:40:23 +0100 Message-ID: Subject: Re: [PATCH v4 30/78] drm/vc4: crtc: Clear the PixelValve FIFO on disable To: Maxime Ripard X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , LKML , DRI Development , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime On Wed, 8 Jul 2020 at 18:43, Maxime Ripard wrote: > > In order to avoid a stale pixel getting stuck on mode change or a disable > / enable cycle, we need to make sure to flush the PV FIFO on disable. > > Signed-off-by: Maxime Ripard Reviewed-by: Dave Stevenson > --- > drivers/gpu/drm/vc4/vc4_crtc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c > index 7b178d67187f..13fe0e370fb3 100644 > --- a/drivers/gpu/drm/vc4/vc4_crtc.c > +++ b/drivers/gpu/drm/vc4/vc4_crtc.c > @@ -408,8 +408,7 @@ static void vc4_crtc_atomic_disable(struct drm_crtc *crtc, > if (vc4_encoder->post_crtc_disable) > vc4_encoder->post_crtc_disable(encoder); > > - CRTC_WRITE(PV_CONTROL, CRTC_READ(PV_CONTROL) & ~PV_CONTROL_EN); > - > + vc4_crtc_pixelvalve_reset(crtc); > vc4_hvs_atomic_disable(crtc, old_state); > > if (vc4_encoder->post_crtc_powerdown) > -- > git-series 0.9.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel