From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4209C433DF for ; Wed, 29 Jul 2020 14:09:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 952992070B for ; Wed, 29 Jul 2020 14:09:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="fEjcnq4v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 952992070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 144C06E52C; Wed, 29 Jul 2020 14:09:40 +0000 (UTC) Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id 666656E52C for ; Wed, 29 Jul 2020 14:09:38 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id 184so3122744wmb.0 for ; Wed, 29 Jul 2020 07:09:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5t5DpkkM9FfZvKuPlhDVpBPxywRpdtxeaztDcBlDx4Y=; b=fEjcnq4vJQquAdBwoOz/l89X9cOzX01g1ijj/xRZfBFMpu62QB2kZxFalmndleCpMV sbUgwYVYL8w78hxFH2mGTCXNBkhrbUWNgHMtxWN2VddpZD+Osy4SrfSWqYWr8bkDhCt1 uFRTD1I0aoky8JhSEK6Lf0jiISaaoWuInL7qKUdTvGCczzFjUujs6SEItOYKA0lTSrWe ZdYMX5KlQJ068pjIozZXX8FNlyNO1sM+OJ9YtYgp0b7LC01awjuwiXJG+kgZcV04J1uG XcYyF1BEqEoDtn8MuPs2bon7aRIT3c2vJqWBGTrxWm0Bu4tJcBxRYQQy6PwA7ACUJ2sd vTLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5t5DpkkM9FfZvKuPlhDVpBPxywRpdtxeaztDcBlDx4Y=; b=Nysn3g0DxjzGcVYLjgQHb0ODsIK8A2NPm8nQ7yYZy3fcILMAYl7tLFr3xBXTmR/kUx sBwbvx/xOrxZQByv6RFh8qG3sFjlWVPcvrqzFBAIoLAW8vUlrFmkWAEvZOKc6zB7+/rL 5bDJo/0zqssA9jRBgaKpEhg1bs1SwmwiE8w1okb4xMVYMAqBNCZj03b4Qh5K+mN3qUVW h3/dtQC0KZFjeNT51xK7SKA0nQE/pFA7B7jWCrHZqiBxZmaOeWDk+oSlIJrdKY24udKn 4+zt0w20TjWzEYOHDoZ/kAb4DM4efdBCobNQumpgyXKZgEXstRWRjyWYGaL6GWDI8eeu 3OwQ== X-Gm-Message-State: AOAM5326xderWbOdQXgt4EIpwrYeKFZPgmjN4hU5ssXhNCsXZ54XFsPk urxyPsZ+8W9zPPDB1AtPhy3cKTKQPzJ9SjNa1BHSxg== X-Google-Smtp-Source: ABdhPJwML2HLeKzyxrFF+2eyXRCw+6uwISHpNJJ9ngzcYnDb3HpcH9lWvSA2mgwpe3fjqqayKr8IeuRxi7/Mg0IgVuI= X-Received: by 2002:a7b:cf08:: with SMTP id l8mr1521918wmg.183.1596031776995; Wed, 29 Jul 2020 07:09:36 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Dave Stevenson Date: Wed, 29 Jul 2020 15:09:21 +0100 Message-ID: Subject: Re: [PATCH v4 29/78] drm/vc4: crtc: Add a delay after disabling the PixelValve output To: Maxime Ripard X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , LKML , DRI Development , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime On Wed, 8 Jul 2020 at 18:43, Maxime Ripard wrote: > > In order to avoid pixels getting stuck in the (unflushable) FIFO between > the HVS and the PV, we need to add some delay after disabling the PV output > and before disabling the HDMI controller. 20ms seems to be good enough so > let's use that. > > Signed-off-by: Maxime Ripard > --- > drivers/gpu/drm/vc4/vc4_crtc.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c > index d0b326e1df0a..7b178d67187f 100644 > --- a/drivers/gpu/drm/vc4/vc4_crtc.c > +++ b/drivers/gpu/drm/vc4/vc4_crtc.c > @@ -403,6 +403,8 @@ static void vc4_crtc_atomic_disable(struct drm_crtc *crtc, > ret = wait_for(!(CRTC_READ(PV_V_CONTROL) & PV_VCONTROL_VIDEN), 1); > WARN_ONCE(ret, "Timeout waiting for !PV_VCONTROL_VIDEN\n"); > > + mdelay(20); mdelay for 20ms seems a touch unfriendly as it's a busy wait. Can we not msleep instead? Dave > + > if (vc4_encoder->post_crtc_disable) > vc4_encoder->post_crtc_disable(encoder); > > -- > git-series 0.9.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel