From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E832C433E0 for ; Tue, 28 Jul 2020 14:45:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4A357206D4 for ; Tue, 28 Jul 2020 14:45:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=raspberrypi.com header.i=@raspberrypi.com header.b="n+V6fb8g" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4A357206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E6446E301; Tue, 28 Jul 2020 14:45:29 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id BFA146E301 for ; Tue, 28 Jul 2020 14:45:27 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id y3so18563073wrl.4 for ; Tue, 28 Jul 2020 07:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wFSLR54AG21yXuJSgEQrikeXsmLVyETIXUBo/YY7SQI=; b=n+V6fb8gaxi3wvPz5q/AZLkhYBFp17gFfZqBFOk707HPWjBYa1FRt8Ltx/88IKG7qW 6QqtyNH4gMQyQfCXhKhAzP/0HSt1ZuBRzf6T+RuL/Wzr91cYH7zl3mLYRATzYGUgG5bJ t3MUy688J6u6xPFQtjvcbDNyXdS5qe80q2byIpC/BLDkw4jsX4nR7TYgR6D3BmJzvzXm tK964nLtGTzrl9xIkcejSN0Wo7Vumd2XDIih8kw822g1+oNTLUzpWOUhZG925+s/3o81 Ej1wF810eZTRNrJnNPdKvuImV52MbsLK/93Sc+HOessePEry5j8S2V9Rl624t9iVF5X2 Ksew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wFSLR54AG21yXuJSgEQrikeXsmLVyETIXUBo/YY7SQI=; b=V4ca0zqrmui7y36yEMn3/ImCHsDk+pRvUBmLM45gLVu6J1//3bOnl+tZam8h9y0+9c FriRKkErwUBB7d8Y82A6Ngpfp77ULUAB7nmCm6QKSU0mBuOJ1Hla3hRMwqvmMuptavYy 7TfiCVWL9ty8FivCQ7bOnCsm0k20+4USS3lXPrBeq3YUiPogXiHDgUZqsTV0rhIoq5r6 jgqruLjGZtc+Rr6x2phWMUsxq7Zng8puiricR0x9XOxMY6t/P+WIxoN4a4LVpD+l7uRt vQg53inOlhjso5YPtxpYNhRlJIT82k0ywcUj80poaso/LmClWBEacXfHUAQWgqSk8Onr o+FQ== X-Gm-Message-State: AOAM531xslwT8qywR/7w69dNRnxz+maplxo57wO70ODSycS1XMieoyVF PtSeERFNyYKFdGKDcRimnV2XZ3TV0q3+Y/H5erg0v5IijgM= X-Google-Smtp-Source: ABdhPJxoae//gYKTh/KK+nGIJmSuUkxCKkLOygUv6fN0WS/O+exw/sJdg+qry+20wk4f/UqGvyE5iGiVLDilp4dPrxE= X-Received: by 2002:adf:fdce:: with SMTP id i14mr19963786wrs.273.1595947526232; Tue, 28 Jul 2020 07:45:26 -0700 (PDT) MIME-Version: 1.0 References: <98c93e0a594e42e39ba77946a0c8107996495eae.1594230107.git-series.maxime@cerno.tech> In-Reply-To: <98c93e0a594e42e39ba77946a0c8107996495eae.1594230107.git-series.maxime@cerno.tech> From: Dave Stevenson Date: Tue, 28 Jul 2020 15:45:09 +0100 Message-ID: Subject: Re: [PATCH v4 61/78] drm/vc4: hdmi: Rename drm_encoder pointer in mode_valid To: Maxime Ripard X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tim Gover , LKML , DRI Development , bcm-kernel-feedback-list@broadcom.com, Nicolas Saenz Julienne , Phil Elwell , linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime On Wed, 8 Jul 2020 at 18:44, Maxime Ripard wrote: > > The mode_valid hook on the encoder uses a pointer to a drm_encoder called > crtc, which is pretty confusing. Let's rename it to encoder to make it > clear what it is. > > Signed-off-by: Maxime Ripard Reviewed-by: Dave Stevenson > --- > drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c > index a01562a49bf0..17797b14cde4 100644 > --- a/drivers/gpu/drm/vc4/vc4_hdmi.c > +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -556,7 +556,7 @@ static void vc4_hdmi_encoder_enable(struct drm_encoder *encoder) > } > > static enum drm_mode_status > -vc4_hdmi_encoder_mode_valid(struct drm_encoder *crtc, > +vc4_hdmi_encoder_mode_valid(struct drm_encoder *encoder, > const struct drm_display_mode *mode) > { > /* > -- > git-series 0.9.1 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel