From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 895F8C4338F for ; Wed, 28 Jul 2021 13:52:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4FEB46023E for ; Wed, 28 Jul 2021 13:52:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4FEB46023E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=raspberrypi.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CB7446E055; Wed, 28 Jul 2021 13:52:42 +0000 (UTC) Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by gabe.freedesktop.org (Postfix) with ESMTPS id AFB9D6E055 for ; Wed, 28 Jul 2021 13:52:41 +0000 (UTC) Received: by mail-wm1-x32e.google.com with SMTP id f14-20020a05600c154eb02902519e4abe10so4363472wmg.4 for ; Wed, 28 Jul 2021 06:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=raspberrypi.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kuD2/cMi9v63nZZZmSBG2IaupOS/1XWwnneUf9M1k9o=; b=qcRqP641xG0vB+UDYiik9LQYbPUpon4cK820eR4sCWfADHA+T9YgUCydz8yzF5Z8gN 9ZQUEAhytwB5ZTNRpwtUWvuzeTq7kDMKRLGiRBEVaGKgpBgaJMzQzHdYwsT+ei/fzUXD tnEDngdpt/iMmL9N+uLOZBHGyiUIgar1ziPC1yNKhdps+wgFOmNmB2Bv2w4E8HKZTvBf 72i9hM0HTF4pHTf0pEs99WWodCZCQ9/x9snGUz247KYbrsT1v4M7LCB4quydvu6HYkrl oK5ypCS8Fy3yBcHA54M1L3MZ+MlQ2d4dGvvShgn5bgsDF8hmQrtKCtyrAcYa18gE4f8n mkGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kuD2/cMi9v63nZZZmSBG2IaupOS/1XWwnneUf9M1k9o=; b=ujzE5dmRNDUS6YX1RTE/BzXainen6J6Sy8yemBm4NC8S4FqLhKlJY8A7QmMG/X2kek FBnYiFF106NXjso77GIWdRAL5TtQbujkyZyD5oyfSrP8tpHG/XgQMXogJ/4+mzwetnzs sQh/BDjU+Y5JwiUMuTyM1cG2xk7SIchiCr5hta1dXZEAi1cox4IgpQJqopMb0czdu6EL dF2cEadILK9/r65916XnKivTYP5A9wWhnMy4iquC1Cp0EEpznnmYz9rqQRRgTHaHlSps Sig/IXDTbUufcWZOl+kFTdAtEcSw4DQvw8o1+sQBbTndeFf3jHQvJHqU2z0N7zMH32pe nkZA== X-Gm-Message-State: AOAM532HJG61P921d4WT6NhtGo2/aLQjuw1I6QTfF3pphs/aXZKlrey3 wfb1qtf5cHIc8SMAVipkUrrxE+5mx4qRdybH4952Kw== X-Google-Smtp-Source: ABdhPJyZ4wRTiW93BgBlBxE6MvcGFi57mJyOUsPHwaGo/ilO2tap+IJYgnG0mQS5pIEyDpoLfvQwlnfJlQMVP7gRGQs= X-Received: by 2002:a05:600c:354e:: with SMTP id i14mr27642677wmq.96.1627480360236; Wed, 28 Jul 2021 06:52:40 -0700 (PDT) MIME-Version: 1.0 References: <20210707092257.1465109-1-maxime@cerno.tech> In-Reply-To: <20210707092257.1465109-1-maxime@cerno.tech> From: Dave Stevenson Date: Wed, 28 Jul 2021 14:52:24 +0100 Message-ID: Subject: Re: [PATCH v2 0/5] drm/vc4: hdmi: Fix CEC access while disabled To: Maxime Ripard Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-rpi-kernel@lists.infradead.org, Nicolas Saenz Julienne , Tim Gover , Emma Anholt , Boris Brezillon , David Airlie , LKML , DRI Development , bcm-kernel-feedback-list@broadcom.com, Thomas Zimmermann , Hans Verkuil , Daniel Vetter , Phil Elwell , Dom Cobley Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime On Wed, 7 Jul 2021 at 10:23, Maxime Ripard wrote: > > Hi, > > This series aims at fixing a complete and silent hang when one tries to use CEC > while the display output is off. > > This can be tested with: > > echo off > /sys/class/drm/card0-HDMI-A-1/status > cec-ctl --tuner -p 1.0.0.0 > cec-compliance > > This series addresses it by making sure the HDMI controller is powered up as > soon as the CEC device is opened by the userspace. > > Let me know what you think, > Maxime > > Changes from v1: > - More fixes > - Added a big warning if we try to access a register while the device is > disabled. > - Fixed the pre_crtc_configure error path > > Maxime Ripard (5): > drm/vc4: hdmi: Make sure the controller is powered up during bind > drm/vc4: hdmi: Rework the pre_crtc_configure error handling > drm/vc4: hdmi: Split the CEC disable / enable functions in two > drm/vc4: hdmi: Make sure the device is powered with CEC > drm/vc4: hdmi: Warn if we access the controller while disabled Comment made on patch 1. Patches 2-5: Reviewed-by: Dave Stevenson Dave > > drivers/gpu/drm/vc4/vc4_hdmi.c | 123 +++++++++++++++++++--------- > drivers/gpu/drm/vc4/vc4_hdmi_regs.h | 6 ++ > 2 files changed, 89 insertions(+), 40 deletions(-) > > -- > 2.31.1 >