From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95A9AC3F68F for ; Sat, 15 Feb 2020 04:29:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 622BD2083B for ; Sat, 15 Feb 2020 04:29:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e2n8YlSy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 622BD2083B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B2F2D6E0EE; Sat, 15 Feb 2020 04:29:36 +0000 (UTC) Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 827916E0EE for ; Sat, 15 Feb 2020 04:29:35 +0000 (UTC) Received: by mail-io1-xd41.google.com with SMTP id h8so419523iob.2 for ; Fri, 14 Feb 2020 20:29:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8jrPUAST5OrlAuzaZGqL8mja6GoITz5q20XCIgnRu/A=; b=e2n8YlSyNNL6NBxMSM2XZFrjkU2pJkXhZ75A8DNN5jClucDbLCmr1dDZvvoq9N9s/X VJnNgCnx8UdNACWmjzvDOIIU5mVQwqQvUXkb5+x2rWPNdOzUmEdTOwBjO/uzw8D3ZXyL SxZfHuMX9oERSpfofrUEDYlGUg+n4vTfMC2PDu+1Bv+9UOvr+Oq6YGQt0I8uNtqdL4Wf L00y4gmcPHKUhOXZBvdhv/gVC7LggUxMgPTVUxtSVJnEk302q0mPuCgwjP6//sqL/gPw ET974V1X96MY5X7cpWB1PDieL71Zm8wRZ010uckSETjWGO22/WWiI24d+PU2Py1A/uUW 4nkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8jrPUAST5OrlAuzaZGqL8mja6GoITz5q20XCIgnRu/A=; b=PMWjENebMqDLGPKozEDOqymRuhM26D9gCXie4doOVK7TaDMozSUMqW6Xqs4yOXtpOM YkevUK5vcmelqR+7df0MfjJgjwcjV74bKwWTqq9c3cdDMNKtbQLF8/FlCGhZnp5Rc+KI Y5vsmHAWH4D7V7a6r9J5oVkc2Lqji94MFTu4tczJomZb3pl01kmrvjTRP9oQPhC+3ZAD eQqRyeYG3XT6cQheE/YmZn9iDXBRLGec42yEZ1K7jxfGkU9Ur0bE6SW0AW4YI0P4nRuX Z+il89rIRbZ/Qsi6YD7wFWS4x3ewKVbMEg6tYFQF7VuPfzGyDEA3UskHSYyGUcSp5vA+ CYsQ== X-Gm-Message-State: APjAAAVnM1V4XWLrJ/bvU0ekNMWNPcxGLw4Y4LywXMv+P8Ias0xGMhbz z0xqDd2nfIrFZ6lbb5/bHFSYHuroSJE03O9qufbHFJRs X-Google-Smtp-Source: APXvYqyhBq1CorMiyF4WmA4UaN1rXbaQs33PIoj9ij3zb5exfZ3o5Z6D45+f/Uk1vHKoPrQFpzWo2nkAKtp1zqA3LeY= X-Received: by 2002:a5e:9246:: with SMTP id z6mr5161214iop.232.1581740974706; Fri, 14 Feb 2020 20:29:34 -0800 (PST) MIME-Version: 1.0 References: <20200213231805.622-1-gurchetansingh@chromium.org> <20200213231805.622-4-gurchetansingh@chromium.org> In-Reply-To: From: Chia-I Wu Date: Fri, 14 Feb 2020 20:29:23 -0800 Message-ID: Subject: Re: [PATCH 3/5] drm/virtio: track whether or not a context has been initiated To: Gurchetan Singh X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Gerd Hoffmann , ML dri-devel , jbates@chromium.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Feb 14, 2020 at 6:29 PM Gurchetan Singh wrote: > > On Fri, Feb 14, 2020 at 11:27 AM Chia-I Wu wrote: > > > > On Thu, Feb 13, 2020 at 3:18 PM Gurchetan Singh > > wrote: > > > > > > Use an atomic variable to track whether a context has been > > > initiated. > > > > > > v2: Fix possible race (@olv) > > > > > > Signed-off-by: Gurchetan Singh > > > --- > > > drivers/gpu/drm/virtio/virtgpu_drv.h | 1 + > > > drivers/gpu/drm/virtio/virtgpu_ioctl.c | 3 +++ > > > drivers/gpu/drm/virtio/virtgpu_kms.c | 1 + > > > 3 files changed, 5 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.h b/drivers/gpu/drm/virtio/virtgpu_drv.h > > > index 72c1d9b59dfe..ca505984f8ab 100644 > > > --- a/drivers/gpu/drm/virtio/virtgpu_drv.h > > > +++ b/drivers/gpu/drm/virtio/virtgpu_drv.h > > > @@ -209,6 +209,7 @@ struct virtio_gpu_device { > > > > > > struct virtio_gpu_fpriv { > > > uint32_t ctx_id; > > > + atomic_t context_initiated; > > > }; > > > > > > /* virtio_ioctl.c */ > > > diff --git a/drivers/gpu/drm/virtio/virtgpu_ioctl.c b/drivers/gpu/drm/virtio/virtgpu_ioctl.c > > > index 896c3f419a6d..a98884462944 100644 > > > --- a/drivers/gpu/drm/virtio/virtgpu_ioctl.c > > > +++ b/drivers/gpu/drm/virtio/virtgpu_ioctl.c > > > @@ -44,6 +44,9 @@ void virtio_gpu_create_context(struct drm_device *dev, > > > if (!vgdev->has_virgl_3d) > > > return; > > > > > > + if (!atomic_add_unless(&vfpriv->context_initiated, 1, 1)) > > > + return; > > > + > > How does this work? When thread A and B enter this function at the > > same time, and thread B returns early, it is possible that thread B > > queues other commands before thread A has the chance to queue > > virtio_gpu_cmd_context_create. > > Good catch, I'll add a spinlock in v3. virtio_gpu_cmd_context_create can sleep. You will need a mutex (or figure out another way to do the lazy initialization). > > > > > > get_task_comm(dbgname, current); > > > virtio_gpu_cmd_context_create(vgdev, vfpriv->ctx_id, > > > strlen(dbgname), dbgname); > > > diff --git a/drivers/gpu/drm/virtio/virtgpu_kms.c b/drivers/gpu/drm/virtio/virtgpu_kms.c > > > index 282558576527..25248bad3fc4 100644 > > > --- a/drivers/gpu/drm/virtio/virtgpu_kms.c > > > +++ b/drivers/gpu/drm/virtio/virtgpu_kms.c > > > @@ -263,6 +263,7 @@ int virtio_gpu_driver_open(struct drm_device *dev, struct drm_file *file) > > > } > > > > > > vfpriv->ctx_id = handle + 1; > > > + atomic_set(&vfpriv->context_initiated, 0); > > > file->driver_priv = vfpriv; > > > virtio_gpu_create_context(dev, file); > > > return 0; > > > -- > > > 2.25.0.265.gbab2e86ba0-goog > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel