Re: [PATCH v2] dma-buf: Add DmaBufTotal counter in meminfo

From: Daniel Stone <daniel@fooishbar.org>
To: Peter Enderborg <Peter.Enderborg@sony.com>
Cc: "Michal Hocko" <mhocko@suse.com>,
	"Matthew Wilcox" <willy@infradead.org>, NeilBrown <neilb@suse.de>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"Alexey Dobriyan" <adobriyan@gmail.com>,
	"moderated list:DMA BUFFER SHARING FRAMEWORK"
	<linaro-mm-sig@lists.linaro.org>,
	"Shakeel Butt" <shakeelb@google.com>,
	"Mike Rapoport" <rppt@kernel.org>,
	"Sami Tolvanen" <samitolvanen@google.com>,
	"Muchun Song" <songmuchun@bytedance.com>,
	linux-fsdevel@vger.kernel.org,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Christian König" <christian.koenig@amd.com>,
	"Roman Gushchin" <guro@fb.com>,
	"open list:DMA BUFFER SHARING FRAMEWORK"
	<linux-media@vger.kernel.org>
Subject: Re: [PATCH v2] dma-buf: Add DmaBufTotal counter in meminfo
Date: Tue, 20 Apr 2021 15:48:21 +0100	[thread overview]
Message-ID: <CAPj87rNo2WS8A0BUoncZhZg4gMOcBrjOF5gxiAWrbpO6z1Rnqg@mail.gmail.com> (raw)
In-Reply-To: <9d4b7f7d-1a7d-0899-bf33-49fac1847bbe@sony.com>

[-- Attachment #1.1: Type: text/plain, Size: 1278 bytes --]

On Tue, 20 Apr 2021 at 14:46, <Peter.Enderborg@sony.com> wrote:

> On 4/20/21 3:34 PM, Daniel Stone wrote:
> > On Fri, 16 Apr 2021 at 13:34, Peter Enderborg <peter.enderborg@sony.com
> <mailto:peter.enderborg@sony.com>> wrote:
> >     This adds a total used dma-buf memory. Details
> >     can be found in debugfs, however it is not for everyone
> >     and not always available. dma-buf are indirect allocated by
> >     userspace. So with this value we can monitor and detect
> >     userspace applications that have problems.
> >
> >
> > FWIW, this won't work super well for Android where gralloc is
> implemented as a system service, so all graphics usage will instantly be
> accounted to it.
>
> This resource allocation is a big part of why we need it. Why should it
> not work?
>

Sorry, I'd somehow completely misread that as being locally rather than
globally accounted. Given that, it's more correct, just also not super
useful.

Some drivers export allocation tracepoints which you could use if you have
a decent userspace tracing infrastructure. Short of that, many drivers
export this kind of thing through debugfs already. I think a better
long-term direction is probably getting accounting from dma-heaps rather
than extending core dmabuf itself.

Cheers,
Daniel

[-- Attachment #1.2: Type: text/html, Size: 1966 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel