From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40032C433DF for ; Tue, 4 Aug 2020 07:27:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 386BB2076C for ; Tue, 4 Aug 2020 07:27:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=gmx.net header.i=@gmx.net header.b="UTAFAQAz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 386BB2076C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=public-files.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B08BB6E431; Tue, 4 Aug 2020 07:27:04 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3587689274 for ; Mon, 3 Aug 2020 18:03:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1596477768; bh=BBa3NSjXaC3TQAHSDrvm2A0DeRZLmH0CWpxHTLdlYjs=; h=X-UI-Sender-Class:Date:In-Reply-To:References:Subject:Reply-to:To: CC:From; b=UTAFAQAzApPZZ0flsN9S1yEnccWgfdgX7V9WZUnOsUBFIqOuXwq3VHF97JnHS2iUf kG+viCGPchkFkwExep2S5/u0UME9TcEfaeyT1JeSfrM1uBULYdrccAGh9PS7OOO5RT 543q1lHNvfC35ZsMYpalHjQ4lz9/DkIeEjLRi02I= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from frank-s9 ([217.61.148.26]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MmlXK-1kUsso2yBS-00juVp; Mon, 03 Aug 2020 20:02:48 +0200 Date: Mon, 03 Aug 2020 20:02:38 +0200 User-Agent: K-9 Mail for Android In-Reply-To: References: <20200728111800.77641-1-frank-w@public-files.de> <20200728111800.77641-2-frank-w@public-files.de> MIME-Version: 1.0 Subject: Re: Re: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port To: linux-mediatek@lists.infradead.org, Chun-Kuang Hu , ryder.lee@mediatek.com From: Frank Wunderlich Message-ID: X-Provags-ID: V03:K1:WAQfzGVjSkS/16yz9r7IpNOuSlMl2BMKsoaMRRAoP3sVBH84qNq wD261Oq8/ov+9nxyiq1n/yjiI8bous5siv81EUe0lDdC9apZwvIfi//d2RQVhmg/5lFA683 eKifWM6puhV8WX6izdjWHwl8PERQlm8PXD7uwIsSjbGuzFloLAdV9Z2Zd1l8AbB9pcv2dZN 6qiuH0R+YQg36uqjHpCsA== X-UI-Out-Filterresults: notjunk:1;V03:K0:bv0vMe1HGgs=:Ot2Dri9B6JRi7gkA5+I8B+ PkMBVJDfumgzFBC3CAldXejaKPq/gpCzWuT3RtgtVVFXdmR5m3flZOp6k5exj3VBkPa8JxIA9 DrQrWK6khzrvwaWTrGJOEmFAfUhnickZo96K9r8xubioKh6F1+NQw+raMXePuDtkFHP0uy/au 0PdQ5f+q2IUCXAOVfUwTeyCDuMSmIDSBIoezxbnZFHc1SiuJ3yuty8m8eA0OKGiO69fyfDlPW SBTzkzznB1IVSMoOizir+Nn7RFwKtIvGyGOXLD1v871lz9baNXqH3pLUY8cY/eOFPZslwoVCL QgIZ8CjC04iP2GPLpWDGmyzPbyGuqnwgdFJIh2TM1cxX10TlBYssqjlLMIUhn4bVOEfIRRAU3 gd7TuYa4x4EyLnrWkl3Las+b1DjIlbwkYrH1mIn68uAQjblxXziZpAaR6YHryS8jo1FCGzRg2 gyVkyclaURvX1y7AM0ZBDSLsetp7N3gfgfHm2nekEQuFDbi+PN6gK5m2604vYrPi7w0XivnDd 3kYUfi17Zn7Xgq74Et16bhWi3o626NdEC2FfQNPc6v2ltiVsZXNpcuxeZCgpjqVlj0rvYiyDi n8c/VlUmFSipPoNIQMZA2rLkAjY9dXkS5UzW6KRHt5JZSSE0ahio5T+YkR+MJowQ0std6ESSR w6CowPHmidjF6E1/Ch0jooaRnn1424QJZ1MBy1/X6/k/yhteMzr8Uu/GBzUjnctHY7SLFTR+x mLzcvIg7Lidvw0UaPqz5yRWKeSlxA4ATOwigXDVgqx/ucoWQPriOTfHYML2qgENx+pVH+sRDr c06+FvRlOEZfC0Br91IBXyZ77BsJgBkA3nWlfAAQJlSkjRF0KEAJNdd1MP/KHVnjEapH8ppdp MXR0CjgycbAui4PWvs6m27hG/8KU31mHdOaqhMLS8xT6E24GL6iuRREeU+58q2OlMKGxrjDBs pLi8jD6lsNgP5/TQjeFeYtBE8Y5D4U2SL0YGPK6L9U3KAjwr7nSKlGAFXvmS/Kn3y4j/YJ+7p EDCpkFfnMeFSDksEWqRJIX6H1l0K647GOBnEwBf++o2RMRnTW2i8HfAqm/37Y0amCkm9xxIOO TyLihjFr4r4WBP/33uFJmuhTSn5Vsar624OOJYh4D3mCXEhx8+C07YScahCH8kQ4Dva9Omt7T 31rYgmi+/nYkeJ5y2uOa8kVGdGV0Dg0T+tH1v/coBnzCk1tbua9LopdHd64z8Schp2vR8IrYa oZ9Y6BN43P46iOgYzXsiLhiIHGEF/sddtg029cw== X-Mailman-Approved-At: Tue, 04 Aug 2020 07:27:04 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: frank-w@public-files.de Cc: David Airlie , linux-kernel , DRI Development , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am 3. August 2020 18:27:02 MESZ schrieb Chun-Kuang Hu : >But now I have a solution that you need not to modify binding document. >Because now mt7623 has a different routing than mt2701, and this >patch's approach is to use different port setting in each device tree. >My solution is that these two SoC has different compatible string: >"mediatek,mt7623-mmsys" and "mediatek,mt2701-mmsys". For now, >"mediatek,mt2701-mmsys" has its data as > >static const struct mtk_mmsys_driver_data mt2701_mmsys_driver_data = { >.main_path = mt2701_mtk_ddp_main, >.main_len = ARRAY_SIZE(mt2701_mtk_ddp_main), >.ext_path = mt2701_mtk_ddp_ext, >.ext_len = ARRAY_SIZE(mt2701_mtk_ddp_ext), >.shadow_register = true, >}; > >I think you could create a data for "mediatek,mt7623-mmsys" which has >a different routing. The paths are defined as this: static enum mtk_ddp_comp_id mt2701_mtk_ddp_main[] = { DDP_COMPONENT_OVL0, DDP_COMPONENT_RDMA0, DDP_COMPONENT_COLOR0, DDP_COMPONENT_BLS, DDP_COMPONENT_DSI0,}; static enum mtk_ddp_comp_id mt2701_mtk_ddp_ext[] = { DDP_COMPONENT_RDMA1, DDP_COMPONENT_DPI0,}; First thing i notice is that main=dsi and ext=dpi (hdmi). I guess dpi should be main,right? And bls is actually routed to dpi...how about the other components? The 2 loops are not really clear to me (except 1st overwrites mt2701 main-path and second ext_path based on ports/endpoints) but this only applies from bls-dpi-hdmi-connector,not xdma/color or similar. Or should be main-path (or external) only bls and dpi? It looks like it only swappes dpi and dsi in my case. @Ryder Lee can you explain it? regards Frank _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel