From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28ECDC33C9E for ; Wed, 15 Jan 2020 02:40:34 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F3D34222C3 for ; Wed, 15 Jan 2020 02:40:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amdcloud.onmicrosoft.com header.i=@amdcloud.onmicrosoft.com header.b="dlUJl1TO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F3D34222C3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amd.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3D9E1891CE; Wed, 15 Jan 2020 02:40:31 +0000 (UTC) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2088.outbound.protection.outlook.com [40.107.237.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 014D9891CE; Wed, 15 Jan 2020 02:40:29 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a+dzjIAmPNtmvzIE+5MCGy1Ib0hvtKBCnQMbU9c8EQnPESvIaNTbPV/wlpKcGq5cizDAR5zm5DvvBx0R/dTY1W1jSGEBrlJRFOm6K1/FgcsUkeBrSPxxt8OQkFBhtfouZWpXVX6XdOcn2gMB+wLnT0+v04e7imNinjkfODC/+3Ablwv3wKISlbUozHyMO2TInkiuZyxBPRDgU0OXDTnSUmAR483Ye4N/zgmKQLsdgo7xkCUo7Wg39pH54l0iU9IcsAD9fBy8SpgoXu7tsytVlEQTchzZqlP8T5xbbzmrlSL//kqUopat7gvsX0qg7YrX6nRiuKgyS7STfkt+1RitVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6vw6WTSNnXw+EJKLY8mE6y82l79u3+RUXNndtDtxulM=; b=QRrQHmwwqv/dvnp4hXEmWlElGhi0DwPGOczFzY1kwWU1w25BP4U/IqIvFkF5Y86Gi+IPVKAduOobLkSM3dgSPLfcIGTvMo5bRQu1RqHRRTnNxk3KUpy56my7ujXOXYHB5XuZBMHeVBY/sbBE8flZvLpO46gw91nrGlWTkAXnzUjlNqfgmabkmN8xPwjJmFJwCJL2FDuy9oWwhJ4RCEwMBZq6ZWGaOPev+gvMO9R+2tHrFV/EQOcXzSAlesCWV2Yu0QEEWUz+dXBNkg0D+MBsmGSGc9cK4qPJ/+hrE1nVnTf4TIJ55yq1uXFBHGe0D1b4XRaKxeGBBkQ4jgIEt8E70Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amdcloud.onmicrosoft.com; s=selector2-amdcloud-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6vw6WTSNnXw+EJKLY8mE6y82l79u3+RUXNndtDtxulM=; b=dlUJl1TOKX/bAv5P0f+x9XuR80IBrXSLKMpX82URufOeB5DMxv1pSPI4q/ijvaNxgnytP7WZTIvnDPi65OLgxoT06/aj37chNbXletvu0wrPzhUgnCDvC/Xdilme8HMPr8WUCi9yJF72e7QEImnhROv0whhBfJGsLt0YzlwBoFQ= Received: from DM6PR12MB4137.namprd12.prod.outlook.com (10.141.186.21) by DM6PR12MB3659.namprd12.prod.outlook.com (10.255.76.95) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2623.9; Wed, 15 Jan 2020 02:40:26 +0000 Received: from DM6PR12MB4137.namprd12.prod.outlook.com ([fe80::cd1d:def3:d2df:3882]) by DM6PR12MB4137.namprd12.prod.outlook.com ([fe80::cd1d:def3:d2df:3882%7]) with mapi id 15.20.2644.015; Wed, 15 Jan 2020 02:40:26 +0000 From: "Lin, Wayne" To: Lyude Paul , "dri-devel@lists.freedesktop.org" , "amd-gfx@lists.freedesktop.org" Subject: RE: [PATCH 1/2] drm/dp_mst: Add a function to determine the mst end device Thread-Topic: [PATCH 1/2] drm/dp_mst: Add a function to determine the mst end device Thread-Index: AQHVxf/7ktN/4D76nUmiuLJ8r0I7Lqfqs5UAgABY5iA= Date: Wed, 15 Jan 2020 02:40:26 +0000 Message-ID: References: <20200108084416.6296-1-Wayne.Lin@amd.com> <20200108084416.6296-2-Wayne.Lin@amd.com> In-Reply-To: Accept-Language: en-US, zh-TW Content-Language: zh-TW X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Enabled=true; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SetDate=2020-01-15T02:34:15Z; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Method=Privileged; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_Name=Public_0; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ActionId=a6a37699-26d8-4eaa-9499-0000764b165b; MSIP_Label_0d814d60-469d-470c-8cb0-58434e2bf457_ContentBits=1 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_enabled: true msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_setdate: 2020-01-15T02:40:23Z msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_method: Privileged msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_name: Public_0 msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_siteid: 3dd8961f-e488-4e60-8e11-a82d994e183d msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_actionid: 91cb6eb7-9053-4e8a-b535-0000db69c68c msip_label_0d814d60-469d-470c-8cb0-58434e2bf457_contentbits: 0 authentication-results: spf=none (sender IP is ) smtp.mailfrom=Wayne.Lin@amd.com; x-originating-ip: [165.204.68.36] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 3978c252-92a6-4a7e-3e11-08d79964472e x-ms-traffictypediagnostic: DM6PR12MB3659:|DM6PR12MB3659: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-forefront-prvs: 02830F0362 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(376002)(346002)(366004)(136003)(39860400002)(396003)(199004)(189003)(66446008)(7696005)(6506007)(55016002)(64756008)(76116006)(53546011)(186003)(66946007)(66476007)(33656002)(86362001)(26005)(478600001)(9686003)(4326008)(8936002)(110136005)(52536014)(316002)(8676002)(5660300002)(66556008)(2906002)(71200400001)(81156014)(54906003)(81166006); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR12MB3659; H:DM6PR12MB4137.namprd12.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: amd.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Ghtez9n8WkGSfeR0VAs0Wz6RTX5ABRq45A0PozrQTSQ1LYYDqmXteO4OdcVTgqNdt4CO4iynsvj/pGiEEQ1ZLwk7f8tJP0VTg5oK/qN8LL4G5Z+bdTCLXfdEdLs1XZ+O2nNTeyha6PYaKWZBUfq7ayxpJw0UrcnAq1FANZzcPDYayI+HOYM5Df/S6Xxsh+NKMYQeuFjLlGKcnwTyVp/bwJI7tUJpGBqOBcgmEdlCINNsqdBPn+447JLcjZI+r+WdlQKoZCIU6h1fzX744HSNfhSX5IAQeQGc/64TONlaQAOZzVSkdmEIJ4dxU9K3xixE7TSsRCNouRJENcZS7aSBVYMZXtL31GIyqVWHFDoGyPwVN6HFR91/Af8Vm3h0VAQxHtYG2Xd64NzpCbEujGFOJXLnxQJJm1yg8S+tok9Cjt6v0EMjXqnHA8lrE+7wuamq MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3978c252-92a6-4a7e-3e11-08d79964472e X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jan 2020 02:40:26.4892 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: DnUGp11pialz/jUT00kwl7TcrAUfZbQWR2QddzFPOyS4/35ZJXd8OZqaWE6a5w6nSGYxmSlVRBCOYDjVVvRPMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3659 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Zuo, Jerry" , "Kazlauskas, Nicholas" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" [AMD Public Use] > -----Original Message----- > From: Lyude Paul > Sent: Wednesday, January 15, 2020 5:16 AM > To: Lin, Wayne ; dri-devel@lists.freedesktop.org; > amd-gfx@lists.freedesktop.org > Cc: Kazlauskas, Nicholas ; Wentland, Harry > ; Zuo, Jerry > Subject: Re: [PATCH 1/2] drm/dp_mst: Add a function to determine the mst end > device > > This patch series looks awesome so far, thank you for the great work! This > patch looks great, I think we should just squash it into the next patch though > since we don't use this function until then. > Thanks for your time. I will squash it in the new version. > On Wed, 2020-01-08 at 16:44 +0800, Wayne Lin wrote: > > [Why] > > For later usage convenience, add the function > > drm_dp_mst_is_dp_mst_end_device() to decide whether a peer device > > connected to a DFP is mst end device. Which also indicates if the peer > > device is capable of handling message or not. > > > > Signed-off-by: Wayne Lin > > --- > > drivers/gpu/drm/drm_dp_mst_topology.c | 16 ++++++++++++++++ > > 1 file changed, 16 insertions(+) > > > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c > > b/drivers/gpu/drm/drm_dp_mst_topology.c > > index eebf325d7f48..8f54b241db08 100644 > > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > > @@ -1918,6 +1918,22 @@ static u8 drm_dp_calculate_rad(struct > > drm_dp_mst_port *port, > > return parent_lct + 1; > > } > > > > +static bool drm_dp_mst_is_dp_mst_end_device(u8 pdt, bool mcs) { > > + switch (pdt) { > > + case DP_PEER_DEVICE_DP_LEGACY_CONV: > > + case DP_PEER_DEVICE_SST_SINK: > > + return true; > > + case DP_PEER_DEVICE_MST_BRANCHING: > > + /* For sst branch device */ > > + if (!mcs) > > + return true; > > + > > + return false; > > + } > > + return true; > > +} > > + > > static int drm_dp_port_set_pdt(struct drm_dp_mst_port *port, u8 > > new_pdt) { > > struct drm_dp_mst_topology_mgr *mgr = port->mgr; > -- > Cheers, > Lyude Paul -- Best regards, Wayne Lin _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel