From: "Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>
To: Pekka Paalanen <ppaalanen@gmail.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"Joshi, Kunal1" <kunal1.joshi@intel.com>,
"Shankar, Uma" <uma.shankar@intel.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: RE: [i-g-t 08/14] tests/kms_color_chamelium: New subtests for Plane gamma
Date: Mon, 3 Jan 2022 04:06:17 +0000 [thread overview]
Message-ID: <DM8PR11MB5719F4B2AC4433C3BA2EDC118D499@DM8PR11MB5719.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20211118113202.0ff5dcae@eldfell>
> From: Pekka Paalanen <ppaalanen@gmail.com>
> Sent: Thursday, November 18, 2021 3:02 PM
> To: Modem, Bhanuprakash <bhanuprakash.modem@intel.com>
> Cc: igt-dev@lists.freedesktop.org; dri-devel@lists.freedesktop.org; Joshi,
> Kunal1 <kunal1.joshi@intel.com>; Juha-Pekka Heikkila
> <juhapekka.heikkila@gmail.com>; Shankar, Uma <uma.shankar@intel.com>
> Subject: Re: [i-g-t 08/14] tests/kms_color_chamelium: New subtests for Plane
> gamma
>
> On Mon, 15 Nov 2021 15:17:53 +0530
> Bhanuprakash Modem <bhanuprakash.modem@intel.com> wrote:
>
> > To verify Plane gamma, draw 3 gradient rectangles in red, green and blue,
> > with a maxed out gamma LUT and verify we have the same frame dump as
> > drawing solid color rectangles.
> >
> > Cc: Harry Wentland <harry.wentland@amd.com>
> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> > Cc: Uma Shankar <uma.shankar@intel.com>
> > Cc: Kunal Joshi <kunal1.joshi@intel.com>
> > Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
> > ---
> > tests/kms_color_chamelium.c | 188 +++++++++++++++++++++++++++++++++++-
> > 1 file changed, 187 insertions(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_color_chamelium.c b/tests/kms_color_chamelium.c
> > index 76f82d6d35..b506109271 100644
> > --- a/tests/kms_color_chamelium.c
> > +++ b/tests/kms_color_chamelium.c
> > @@ -24,7 +24,34 @@
> >
> > #include "kms_color_helper.h"
> >
> > -IGT_TEST_DESCRIPTION("Test Color Features at Pipe level using Chamelium to
> verify instead of CRC");
> > +IGT_TEST_DESCRIPTION("Test Color Features at Pipe & Plane level using
> Chamelium to verify instead of CRC");
>
> Now that you actually can get a captured image of the result with
> Chamelium, I think the tests should be more ambitious. Do not rely on
> identity curves or matrices, nor max LUT, because now you can use a
> difference threshold per pixel when comparing the result with the
> reference.
>
> Use various non-trivial curves, different for each of red, green and
> blue. Use non-trivial matrices that actually compute mixtures instead
> of just moving red value to the green channel. Use multiple planes
> simultaneously. Use different framebuffer formats, particularly with
> higher than 8 bits per channel, and check the capture has the same
> precision and not truncated to 8 bit.
>
> That kind of tests would have much more proving power, and they also
> help assess the precision of the hardware. Precision is important to
> userspace.
>
> These are also tests that userspace projects cannot really execute, they
> do not have labs with Chamelium boards and not all drivers/hardware
> support writeback connectors.
Thanks for the review Pekka,
We are planning to add these kind of Advanced tests in next phase.
- Bhanu
>
> > +
> > +#define MAX_SUPPORTED_PLANES 7
> > +#define SDR_PLANE_BASE 3
> > +
> > +typedef bool (*test_t)(data_t*, igt_plane_t*);
> > +
> > +static bool is_hdr_plane(const igt_plane_t *plane)
> > +{
> > + return plane->index >= 0 && plane->index < SDR_PLANE_BASE;
>
> This here again. I guess the previous definition of this function was
> never used?
>
> The same questions.
>
> > +}
> > +
> > +static bool is_valid_plane(igt_plane_t *plane)
> > +{
> > + int index = plane->index;
> > +
> > + if (plane->type != DRM_PLANE_TYPE_PRIMARY)
> > + return false;
> > +
> > + /*
> > + * Test 1 HDR plane, 1 SDR plane.
> > + *
> > + * 0,1,2 HDR planes
> > + * 3,4,5,6 SDR planes
> > + *
> > + */
> > + return index >= 0 && index < MAX_SUPPORTED_PLANES;
> > +}
>
>
> Thanks,
> pq
next prev parent reply other threads:[~2022-01-03 4:06 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 9:47 [i-g-t 00/14] Add IGT support for plane color management Bhanuprakash Modem
2021-11-15 9:47 ` [i-g-t 01/14] HAX: Get uapi headers to compile the IGT Bhanuprakash Modem
2021-11-15 9:47 ` [i-g-t 02/14] lib/igt_kms: Add plane color mgmt properties Bhanuprakash Modem
2021-11-15 9:47 ` [i-g-t 03/14] kms_color_helper: Add helper functions for plane color mgmt Bhanuprakash Modem
2021-11-18 8:41 ` Pekka Paalanen
2022-01-03 4:02 ` Modem, Bhanuprakash
2021-11-26 16:54 ` Harry Wentland
2022-01-03 4:02 ` Modem, Bhanuprakash
2021-11-15 9:47 ` [i-g-t 04/14] tests/kms_color: New subtests for Plane gamma Bhanuprakash Modem
2021-11-18 9:02 ` Pekka Paalanen
2022-01-03 4:09 ` Modem, Bhanuprakash
2021-11-26 16:55 ` Harry Wentland
2022-01-03 4:05 ` Modem, Bhanuprakash
2022-01-04 21:19 ` Harry Wentland
2022-01-05 11:21 ` Modem, Bhanuprakash
2022-01-05 22:13 ` Harry Wentland
2021-11-15 9:47 ` [i-g-t 05/14] tests/kms_color: New subtests for Plane degamma Bhanuprakash Modem
2021-11-15 9:47 ` [i-g-t 06/14] tests/kms_color: New subtests for Plane CTM Bhanuprakash Modem
2021-11-26 16:55 ` Harry Wentland
2021-11-15 9:47 ` [i-g-t 07/14] tests/kms_color: New negative tests for plane level color mgmt Bhanuprakash Modem
2021-11-18 9:19 ` Pekka Paalanen
2021-11-29 14:56 ` [igt-dev] " Harry Wentland
2022-01-03 4:05 ` Modem, Bhanuprakash
2021-11-15 9:47 ` [i-g-t 08/14] tests/kms_color_chamelium: New subtests for Plane gamma Bhanuprakash Modem
2021-11-18 9:32 ` Pekka Paalanen
2022-01-03 4:06 ` Modem, Bhanuprakash [this message]
2021-11-15 9:47 ` [i-g-t 09/14] tests/kms_color_chamelium: New subtests for Plane degamma Bhanuprakash Modem
2021-11-15 9:47 ` [i-g-t 10/14] tests/kms_color_chamelium: New subtests for Plane CTM Bhanuprakash Modem
2021-11-15 9:47 ` [i-g-t 11/14] lib/igt_kms: Add pipe color mgmt properties Bhanuprakash Modem
2021-11-18 9:34 ` Pekka Paalanen
2021-11-15 9:47 ` [i-g-t 12/14] kms_color_helper: Add helper functions to support logarithmic gamma mode Bhanuprakash Modem
2021-11-18 9:45 ` Pekka Paalanen
2022-01-03 4:07 ` Modem, Bhanuprakash
2021-11-26 16:55 ` Harry Wentland
2022-01-03 4:08 ` Modem, Bhanuprakash
2021-11-15 9:47 ` [i-g-t 13/14] tests/kms_color: Extended IGT tests " Bhanuprakash Modem
2021-11-15 9:47 ` [i-g-t 14/14] tests/kms_color_chamelium: " Bhanuprakash Modem
2021-11-18 9:50 ` [i-g-t 00/14] Add IGT support for plane color management Pekka Paalanen
2021-11-26 16:54 ` Harry Wentland
2021-11-29 9:20 ` Pekka Paalanen
2021-11-29 15:20 ` Harry Wentland
2022-01-03 4:11 ` Modem, Bhanuprakash
2022-01-04 22:01 ` Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM8PR11MB5719F4B2AC4433C3BA2EDC118D499@DM8PR11MB5719.namprd11.prod.outlook.com \
--to=bhanuprakash.modem@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=kunal1.joshi@intel.com \
--cc=ppaalanen@gmail.com \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).