From: Flavio Suligoi <f.suligoi@asem.it>
To: Conor Dooley <conor@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Helge Deller <deller@gmx.de>,
Lee Jones <lee@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Pavel Machek <pavel@ucw.cz>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>
Subject: RE: [PATCH 1/1] dt-bindings: backlight: mp3309c: remove two required properties
Date: Tue, 24 Oct 2023 07:53:38 +0000 [thread overview]
Message-ID: <DU2PR01MB8034CF8EE4358B9446809AA2F9DFA@DU2PR01MB8034.eurprd01.prod.exchangelabs.com> (raw)
In-Reply-To: <20231023-anybody-silver-4548023f8f26@spud>
Hi Conor,
...
> On Mon, Oct 23, 2023 at 09:28:03AM +0000, Flavio Suligoi wrote:
> > > On Fri, Oct 20, 2023 at 03:54:33PM +0200, Flavio Suligoi wrote:
> > > > The two properties:
> > > >
> > > > - max-brightness
> > > > - default brightness
> > > >
> > > > are not really required, so they can be removed from the "required"
> > > > section.
> > >
> > > Why are they not required? You need to provide an explanation.
> >
> > The "max-brightness" is not more used now in the driver (I used it in
> > the first version of the driver).
>
> If it is not used any more, what happens when someone passes an old
> devicetree to the kernel, that contains max-brightness, but not any of your
> new properties?
This is not a problem, because the device driver has not yet been included in any kernel.
My patch for the device driver is still being analyzed by the maintainers.
Only this dt-binding yaml file is already included in the "for-backlight-next" branch
of the "backlight" kernel repository.
At the moment, this driver is used only in a i.MX8MM board produced in my company,
under my full control. No other developer is using it now.
> > The "default-brightness", if omitted in the DT, is managed by the
> > device driver, using a default value. This depends on the dimming mode
> used:
>
> For default-brightness, has here always been support in the driver for the
> property being omitted, or is this newly added?
In the first version of the driver this property was a "required property",
but nobody has used this driver before, so this should be not a problem.
>
> > - for the "analog mode", via I2C commands, this value is fixed by
> > hardware (=31)
> > - while in case of pwm mode the default used is the last value of the
> > brightness-levels array.
> >
> > Also the brightness-levels array is not required; if it is omitted,
> > the driver uses a default array of 0..255 and the "default-brightness" is the
> last one, which is "255".
>
> Firstly, this is the sort of rationale that needs to be put into your commit
> messages, rather than bullet pointed lists of what you have done.
You are absolutely right, I'll include these details in the next commit message.
>
> Secondly, what about other operating systems etc, do any of those support
> this platform and depend on presence of these properties?
I used this backlight driver in our i.MX8MM board only, with Linux only.
>
> >
> > > > Other changes:
> > > >
> > > > - improve the backlight working mode description, in the "description"
> > > > section
> > >
> > > > - update the example, removing the "max-brightness" and introducing
> the
> > > > "brightess-levels" property
> > >
> > > Why is this more useful?
> >
> > I introduced the "brightness-levels" instead of "max-brightness" for
> > homogeneity, since the "analog mode" dimming has a brightness-levels array
> fixed by hardware (0..31).
> > In this way also the "pwm" mode can use the same concepts of array of
> levels.
>
> What I would like is an explanation in the commit message as to why the
> revised example is more helpful than the existing (and
> must-remain-valid) one.
As said before, no one may have ever used this device driver,
so I would leave only this new version of the example.
>
> Cheers,
> Conor.
Thanks for your help and best regards,
Flavio.
>
> > >
> > > >
> > > > Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> > > > ---
> > > > .../bindings/leds/backlight/mps,mp3309c.yaml | 10 ++++------
> > > > 1 file changed, 4 insertions(+), 6 deletions(-)
> > > >
> > > > diff --git
> > > a/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
> > > b/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
> > > > index 4191e33626f5..527a37368ed7 100644
> > > > ---
> > > a/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
> > > > +++
> > > b/Documentation/devicetree/bindings/leds/backlight/mps,mp3309c.yaml
> > > > @@ -14,8 +14,8 @@ description: |
> > > > programmable switching frequency to optimize efficiency.
> > > > It supports two different dimming modes:
> > > >
> > > > - - analog mode, via I2C commands (default)
> > > > - - PWM controlled mode.
> > > > + - analog mode, via I2C commands, as default mode (32 dimming
> > > > + levels)
> > > > + - PWM controlled mode (optional)
> > > >
> > > > The datasheet is available at:
> > > > https://www.monolithicpower.com/en/mp3309c.html
> > > > @@ -50,8 +50,6 @@ properties:
> > > > required:
> > > > - compatible
> > > > - reg
> > > > - - max-brightness
> > > > - - default-brightness
> > > >
> > > > unevaluatedProperties: false
> > > >
> > > > @@ -66,8 +64,8 @@ examples:
> > > > compatible = "mps,mp3309c";
> > > > reg = <0x17>;
> > > > pwms = <&pwm1 0 3333333 0>; /* 300 Hz --> (1/f) * 1*10^9 */
> > > > - max-brightness = <100>;
> > > > - default-brightness = <80>;
> > > > + brightness-levels = <0 4 8 16 32 64 128 255>;
> > > > + default-brightness = <6>;
> > > > mps,overvoltage-protection-microvolt = <24000000>;
> > > > };
> > > > };
> > > > --
> > > > 2.34.1
> > > >
next prev parent reply other threads:[~2023-10-24 7:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 13:54 [PATCH 0/1] dt-bindings: backlight: mp3309c: remove two required properties Flavio Suligoi
2023-10-20 13:54 ` [PATCH 1/1] " Flavio Suligoi
2023-10-20 15:59 ` Conor Dooley
2023-10-23 9:28 ` Flavio Suligoi
2023-10-23 16:29 ` Conor Dooley
2023-10-24 7:53 ` Flavio Suligoi [this message]
2023-10-24 15:08 ` Conor Dooley
2023-10-25 7:02 ` Flavio Suligoi
2023-10-20 13:54 ` [PATCH v5] backlight: mp3309c: Add support for MPS MP3309C Flavio Suligoi
2023-10-20 15:56 ` Conor Dooley
2023-10-23 9:11 ` Flavio Suligoi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DU2PR01MB8034CF8EE4358B9446809AA2F9DFA@DU2PR01MB8034.eurprd01.prod.exchangelabs.com \
--to=f.suligoi@asem.it \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).