From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C23F3C4BA06 for ; Thu, 27 Feb 2020 06:33:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A1D0324683 for ; Thu, 27 Feb 2020 06:33:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1D0324683 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EC25C6EBED; Thu, 27 Feb 2020 06:33:24 +0000 (UTC) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 051376EBEB; Thu, 27 Feb 2020 06:33:23 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Feb 2020 22:33:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,491,1574150400"; d="scan'208";a="261333098" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga004.fm.intel.com with ESMTP; 26 Feb 2020 22:33:23 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 26 Feb 2020 22:33:22 -0800 Received: from bgsmsx152.gar.corp.intel.com (10.224.48.50) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 26 Feb 2020 22:33:22 -0800 Received: from BGSMSX107.gar.corp.intel.com ([169.254.9.58]) by BGSMSX152.gar.corp.intel.com ([169.254.6.56]) with mapi id 14.03.0439.000; Thu, 27 Feb 2020 12:03:20 +0530 From: "Laxminarayan Bharadiya, Pankaj" To: Chris Wilson , "jani.nikula@linux.intel.com" Subject: RE: [Intel-gfx][PATCH 01/10] drm/i915: Add i915 device based MISSING_CASE macro Thread-Topic: [Intel-gfx][PATCH 01/10] drm/i915: Add i915 device based MISSING_CASE macro Thread-Index: AQHV6+ORF98y/9Y/3EqxiyZJG7rk3agrlFCAgAL+ieA= Date: Thu, 27 Feb 2020 06:33:19 +0000 Message-ID: References: <20200225134709.6153-1-pankaj.laxminarayan.bharadiya@intel.com> <20200225134709.6153-2-pankaj.laxminarayan.bharadiya@intel.com> <158263931977.26598.171017617509031302@skylake-alporthouse-com> In-Reply-To: <158263931977.26598.171017617509031302@skylake-alporthouse-com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.223.10.10] MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , "intel-gfx@lists.freedesktop.org" , "dri-devel@lists.freedesktop.org" , "Vivi, Rodrigo" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Chris, > -----Original Message----- > From: Chris Wilson > Sent: 25 February 2020 19:32 > To: David Airlie ; Joonas Lahtinen > ; Laxminarayan Bharadiya, Pankaj > ; Vivi, Rodrigo > ; daniel@ffwll.ch; dri-devel@lists.freedesktop.org; > intel-gfx@lists.freedesktop.org; jani.nikula@linux.intel.com > Cc: Laxminarayan Bharadiya, Pankaj > > Subject: Re: [Intel-gfx][PATCH 01/10] drm/i915: Add i915 device based > MISSING_CASE macro > > Quoting Pankaj Bharadiya (2020-02-25 13:47:00) > > Now that we have struct drm_device based drm_WARN, introduce struct > > drm_i915_private based i915_MISSING_CASE macro which uses > drm_WARN so > > that device specific information will also get printed in backtrace. > > > > i915_MISSING_CASE macro should be preferred over MISSING_CASE, > > wherever possible. > > Whatever for? MISSING_CASE() itself should be a complete picture for the > forgotten code. Are you saying, no need to have a new device specific macro? We want convert all the calls of WARN* with device specific drm_WARN* in i915, hence I introduced new i915_MISSING_CASE macro. Jani, Will you please share your opinion on this? Thanks, Pankaj > -Chris _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel