From: "H. Nikolaus Schaller" <hns@goldelico.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Discussions about the Letux Kernel <letux-kernel@openphoenux.org>,
Sam Ravnborg <sam@ravnborg.org>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 24/33] drm/panel-simple: Fix dotclock for Ortustech COM37H3M
Date: Mon, 9 Mar 2020 14:03:57 +0100 [thread overview]
Message-ID: <EC094BF3-C112-4D6E-AC2B-D10327CE6C0A@goldelico.com> (raw)
In-Reply-To: <20200309130035.GV13686@intel.com>
> Am 09.03.2020 um 14:00 schrieb Ville Syrjälä <ville.syrjala@linux.intel.com>:
>
> On Thu, Mar 05, 2020 at 08:41:43PM +0100, H. Nikolaus Schaller wrote:
>>
>>> Am 03.03.2020 um 16:49 schrieb H. Nikolaus Schaller <hns@goldelico.com>:
>>>
>>> Hi,
>>>
>>>> Am 03.03.2020 um 16:03 schrieb Ville Syrjälä <ville.syrjala@linux.intel.com>:
>>>>
>>>>> I haven't looked into the driver code, but would it be
>>>>> possible to specify .clock = 0 (or leave it out) to
>>>>> calculate it bottom up? This would avoid such inconsistencies.
>>>>
>>>> I'm going to remove .vrefresh entirely from the struct.
>>>> It'll just be calculated from the other timings as needed.
>>>
>>> Ok!
>>>
>>> Anyways we should fix the panel timings so that it is compatible to .vrefresh = 60.
>>>
>>> I'll give it a try and let you know.
>>
>> Ok, here is a new parameter set within data sheet limits for both
>> panel variants:
>>
>> static const struct drm_display_mode ortustech_com37h3m_mode = {
>> .clock = 22153,
>> .hdisplay = 480,
>> .hsync_start = 480 + 40,
>> .hsync_end = 480 + 40 + 10,
>> .htotal = 480 + 40 + 10 + 40,
>> .vdisplay = 640,
>> .vsync_start = 640 + 4,
>> .vsync_end = 640 + 4 + 2,
>> .vtotal = 640 + 4 + 2 + 4,
>> .vrefresh = 60,
>> .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
>> };
>>
>> I have tested on our omap3 based board and didn't find an issue
>> so you can insert into your patch.
>
> Migth be better if you send that so we get proper attribution and
> you can explain the change properly in the commit message.
Ok, will do asap.
BR and thanks,
Nikolaus
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-10 8:20 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-02 20:34 [PATCH 00/33] drm/panel: Fix dotclocks Ville Syrjala
2020-03-02 20:34 ` [PATCH 01/33] drm/panel-novatek-nt35510: Fix dotclock Ville Syrjala
2020-03-07 14:29 ` Linus Walleij
2020-03-09 13:36 ` [PATCH v2 " Ville Syrjala
2020-03-09 15:33 ` Linus Walleij
2020-03-11 14:46 ` Ville Syrjälä
2020-03-02 20:34 ` [PATCH 02/33] drm/panel-arm-versatile: " Ville Syrjala
2020-03-03 12:10 ` Linus Walleij
2020-03-03 14:54 ` Ville Syrjälä
2020-03-02 20:34 ` [PATCH 03/33] drm/panel-feixin-k101-im2ba02: " Ville Syrjala
2020-03-02 23:36 ` Icenowy Zheng
2020-03-03 14:51 ` Ville Syrjälä
2020-03-02 20:34 ` [PATCH 04/33] drm/panel-ilitek-ili9322: Fix dotclocks Ville Syrjala
2020-03-07 14:38 ` Linus Walleij
2020-03-09 13:38 ` [PATCH v2 " Ville Syrjala
2020-03-09 15:33 ` Linus Walleij
2020-03-11 14:47 ` Ville Syrjälä
2020-03-02 20:34 ` [PATCH 05/33] drm/panel-leadtek-ltk500hd1829: Fix dotclock Ville Syrjala
2020-03-03 12:52 ` Heiko Stuebner
2020-04-02 13:13 ` Ville Syrjälä
2020-04-02 13:20 ` Heiko Stuebner
2020-04-02 15:49 ` Sam Ravnborg
2020-03-02 20:34 ` [PATCH 06/33] drm/panel-lg-lg4573: " Ville Syrjala
2020-03-03 5:24 ` Heiko Schocher
2020-03-11 14:46 ` Ville Syrjälä
2020-03-02 20:34 ` [PATCH 07/33] drm/panel-sitronix-st7789v: " Ville Syrjala
2020-03-02 20:34 ` [PATCH 08/33] drm/panel-sony-acx424akp: Fix dotclocks Ville Syrjala
2020-03-07 14:40 ` Linus Walleij
2020-03-11 14:46 ` Ville Syrjälä
2020-03-02 20:34 ` [PATCH 09/33] drm/panel-simple: Fix dotclock for AUO G101EVN010 Ville Syrjala
2020-03-02 20:34 ` [PATCH 10/33] drm/panel-simple: Fix dotclock for AUO G104SN02 V2 Ville Syrjala
2020-03-03 13:13 ` Christoph Fritz
2020-03-04 12:19 ` Stefan Riedmüller
2020-03-02 20:34 ` [PATCH 11/33] drm/panel-simple: Fix dotclock for CDTech S043WQ26H-CT7 Ville Syrjala
2020-03-02 20:34 ` [PATCH 12/33] drm/panel-simple: Fix dotclock for CDTech S070WV95-CT16 Ville Syrjala
2020-03-02 20:34 ` [PATCH 13/33] drm/panel-simple: Fix dotclock for Chunghwa CLAA070WP03XG Ville Syrjala
2020-03-02 20:34 ` [PATCH 14/33] drm/panel-simple: Fix dotclock for Chunghwa Picture Tubes 10.1" WXGA Ville Syrjala
2020-03-02 20:34 ` [PATCH 15/33] drm/panel-simple: Fix dotclock for EDT ET035012DM6 Ville Syrjala
2020-03-03 7:33 ` Marco Felsch
2020-03-03 14:52 ` Ville Syrjälä
2020-03-06 8:02 ` Marco Felsch
2020-03-09 13:18 ` Ville Syrjälä
2020-03-10 7:05 ` Marco Felsch
2020-03-10 12:04 ` Ville Syrjälä
2020-03-02 20:34 ` [PATCH 16/33] drm/panel-simple: Fix dotclock for EDT ET043080DH6-GP Ville Syrjala
2020-03-02 20:34 ` [PATCH 17/33] drm/panel-simple: Fix dotclock for Foxlink FL500WVR00-A0T Ville Syrjala
2020-03-02 20:34 ` [PATCH 18/33] drm/panel-simple: Fix dotclock for Giantplus GPG482739QS5 Ville Syrjala
2020-03-02 20:34 ` [PATCH 19/33] drm/panel-simple: Fix dotclock for Innolux AT070TN92 Ville Syrjala
2020-03-02 20:34 ` [PATCH 20/33] drm/panel-simple: Fix dotclock for LeMaker BL035-RGB-002 3.5" LCD Ville Syrjala
2020-03-02 20:34 ` [PATCH 21/33] drm/panel-simple: Fix dotclock for Logic PD Type 28 Ville Syrjala
2020-03-03 13:00 ` Adam Ford
2020-03-11 14:46 ` Ville Syrjälä
2020-03-02 20:34 ` [PATCH 22/33] drm/panel-simple: Fix dotclock for Netron DY E231732 Ville Syrjala
2020-03-02 20:34 ` [PATCH 23/33] drm/panel-simple: Fix dotclock for On Tat Industrial Company 7" DPI TFT Ville Syrjala
2020-03-02 20:34 ` [PATCH 24/33] drm/panel-simple: Fix dotclock for Ortustech COM37H3M Ville Syrjala
2020-03-02 21:24 ` H. Nikolaus Schaller
2020-03-03 15:03 ` Ville Syrjälä
2020-03-03 15:49 ` H. Nikolaus Schaller
2020-03-05 19:41 ` H. Nikolaus Schaller
2020-03-09 13:00 ` Ville Syrjälä
2020-03-09 13:03 ` H. Nikolaus Schaller [this message]
2020-03-02 20:34 ` [PATCH 25/33] drm/panel-simple: Fix dotclock for PDA 91-00156-A0 Ville Syrjala
2020-03-02 20:34 ` [PATCH 26/33] drm/panel-simple: Fix dotclock for QiaoDian qd43003c0-40 Ville Syrjala
2020-03-02 20:34 ` [PATCH 27/33] drm/panel-simple: Fix dotclock for Sharp LQ035Q7DB03 Ville Syrjala
2020-03-02 21:40 ` Vladimir Zapolskiy
2020-03-03 14:49 ` Ville Syrjälä
2020-03-02 20:34 ` [PATCH 28/33] drm/panel-simple: Fix dotclock for Sharp LQ150X1LG11 Ville Syrjala
2020-03-02 22:53 ` Peter Rosin
2020-03-03 14:20 ` Thierry Reding
2020-03-03 14:57 ` Peter Rosin
2020-03-03 15:05 ` Thierry Reding
2020-03-03 15:16 ` Peter Rosin
2020-03-04 17:25 ` Sam Ravnborg
2020-03-05 13:07 ` [PATCH] Revert "drm/panel: simple: Add support for Sharp LQ150X1LG11 panels" Peter Rosin
2020-03-07 18:31 ` Sam Ravnborg
2020-03-02 20:34 ` [PATCH 29/33] drm/panel-simple: Fix dotclock for Shelly SCA07010-BFN-LNN Ville Syrjala
2020-03-02 20:34 ` [PATCH 30/33] drm/panel-simple: Fix dotclock for TPK U.S.A. LLC Fusion Ville Syrjala
2020-03-02 20:34 ` [PATCH 31/33] drm/panel-simple: Fix dotclock for XT VL050-8048NT-C01 Ville Syrjala
2020-03-11 14:56 ` Fabio Estevam
2020-03-02 20:34 ` [PATCH 32/33] drm/panel-simple: Fix dotclock for LG LH500WX1-SD03 Ville Syrjala
2020-03-02 20:34 ` [PATCH 33/33] drm/panel-simple: Fix dotclock for LG ACX467AKM-7 Ville Syrjala
2020-03-02 20:48 ` Jonathan Marek
2020-03-03 3:13 ` Brian Masney
2020-03-03 3:28 ` Jonathan Marek
2020-03-03 3:36 ` Jonathan Marek
2020-03-03 12:26 ` Brian Masney
2020-03-03 13:04 ` Jonathan Marek
2020-03-04 2:16 ` Brian Masney
2020-03-04 2:27 ` Jonathan Marek
2020-03-04 2:53 ` Brian Masney
2020-03-04 3:04 ` Jonathan Marek
2020-03-04 10:00 ` Brian Masney
2020-03-04 10:37 ` Brian Masney
2020-03-04 9:10 ` Linus Walleij
2020-03-04 13:16 ` Jonathan Marek
2020-03-04 14:00 ` Linus Walleij
2020-03-02 21:47 ` [PATCH 00/33] drm/panel: Fix dotclocks Sam Ravnborg
2020-03-03 14:50 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EC094BF3-C112-4D6E-AC2B-D10327CE6C0A@goldelico.com \
--to=hns@goldelico.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=letux-kernel@openphoenux.org \
--cc=sam@ravnborg.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).