From: Dexuan Cui <decui@microsoft.com>
To: Deepak Rawat <drawat.floss@gmail.com>,
"linux-hyperv@vger.kernel.org" <linux-hyperv@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Cc: Wei Liu <wei.liu@kernel.org>,
Stephen Hemminger <sthemmin@microsoft.com>,
David Airlie <airlied@linux.ie>,
Haiyang Zhang <haiyangz@microsoft.com>,
Michael Kelley <mikelley@microsoft.com>,
Jork Loeser <Jork.Loeser@microsoft.com>,
Wei Hu <weh@microsoft.com>, KY Srinivasan <kys@microsoft.com>
Subject: RE: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device
Date: Tue, 23 Jun 2020 02:31:20 +0000 [thread overview]
Message-ID: <HK0P153MB03224C17D736FF164209F6DABF940@HK0P153MB0322.APCP153.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20200622110623.113546-2-drawat.floss@gmail.com>
> From: linux-hyperv-owner@vger.kernel.org
> <linux-hyperv-owner@vger.kernel.org> On Behalf Of Deepak Rawat
> Sent: Monday, June 22, 2020 4:06 AM
>
> DRM driver for hyperv synthetic video device, based on hyperv_fb
> framebuffer driver. Also added config option "DRM_HYPERV" to enabled
> this driver.
Hi Deepak,
I had a quick look and overall the patch as v1 looks good to me.
Some quick comments:
1. hyperv_vmbus_probe() assumes the existence of the PCI device, which
is not true in a Hyper-V Generation-2 VM.
2. It looks some other functionality in the hyperv_fb driver has not been
implemented in this new driver either, e.g. the handling of the
SYNTHVID_FEATURE_CHANGE msg.
Thanks,
-- Dexuan
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-06-23 7:49 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 11:06 [RFC PATCH 0/2] DRM driver for hyper-v synthetic video device Deepak Rawat
2020-06-22 11:06 ` [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv " Deepak Rawat
2020-06-22 12:46 ` Gerd Hoffmann
2020-06-22 22:20 ` Deepak Rawat
2020-06-23 9:42 ` Daniel Vetter
2020-06-23 16:17 ` Gerd Hoffmann
2020-06-25 0:47 ` Deepak Rawat
2020-06-22 15:19 ` Sam Ravnborg
2020-06-22 22:43 ` Deepak Rawat
2020-06-23 7:59 ` Thomas Zimmermann
2020-06-23 9:12 ` Deepak Rawat
2020-06-23 9:19 ` Thomas Zimmermann
2020-06-23 2:31 ` Dexuan Cui [this message]
2020-06-23 6:48 ` Deepak Rawat
2020-06-23 21:58 ` Dexuan Cui
2020-06-22 11:06 ` [RFC PATCH 2/2] MAINTAINERS: Add maintainer for hyperv " Deepak Rawat
2020-06-28 23:01 ` [RFC PATCH 0/2] DRM driver for hyper-v synthetic " Daniel Vetter
2020-09-10 8:19 [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv " Tang, Shaofeng
2020-09-11 0:38 ` Deepak Rawat
2020-11-15 9:14 ` Thomas Zimmermann
2020-11-15 17:55 ` Deepak Rawat
2020-11-15 18:58 ` Thomas Zimmermann
2020-11-16 9:58 ` Daniel Vetter
2020-11-16 16:36 ` Deepak Rawat
2020-09-28 15:58 Marcin Skarbek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HK0P153MB03224C17D736FF164209F6DABF940@HK0P153MB0322.APCP153.PROD.OUTLOOK.COM \
--to=decui@microsoft.com \
--cc=Jork.Loeser@microsoft.com \
--cc=airlied@linux.ie \
--cc=drawat.floss@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=sthemmin@microsoft.com \
--cc=weh@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).