From: Chris Morgan <macromorgan@hotmail.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: devicetree@vger.kernel.org, krzysztof.kozlowski+dt@linaro.org,
airlied@linux.ie, dri-devel@lists.freedesktop.org,
Chris Morgan <macroalpha82@gmail.com>,
robh+dt@kernel.org, thierry.reding@gmail.com, sam@ravnborg.org
Subject: Re: [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings
Date: Wed, 21 Sep 2022 10:50:48 -0500 [thread overview]
Message-ID: <SN6PR06MB53420E8B1245EDFCB7547C69A54F9@SN6PR06MB5342.namprd06.prod.outlook.com> (raw)
In-Reply-To: <ff2ee392-0f78-37d4-56b5-443e6e998443@linaro.org>
On Wed, Sep 21, 2022 at 05:21:19PM +0200, Krzysztof Kozlowski wrote:
> On 21/09/2022 16:38, Chris Morgan wrote:
> >>> + compatible:
> >>> + items:
> >>> + - enum:
> >>> + - anbernic,rg353p-panel
> >>
> >> Are these vendor prefixs documented?
> >
> > Yes, they are in another patch series referenced in the cover letter.
> > They were added for the Anbernic devicetrees and should (I believe)
> > land in 6.1.
>
> OK... you still need to test your bindings. Your patch was clearly not
> tested before sending. :(
I did: yamllint, make dt_binding_check (with DT_SCHEMA_FILES specified), and
make dtbs_check (with DT_SCHEMA_FILES specified again). That's the proper
testing flow correct? In this case it's the pre-requisite that's causing
the issue as I see on a pristine master tree I'm warned about the missing
vendor prefix for anbernic. Should I wait for that to go upstream before
I submit this again?
I'll make the other change about the space and the description of the
vdd-supply when I resubmit. Are we good with the panel compatibles? I'm
still not entirely sure the best thing to name them as I have no part
number whatsoever except the driver IC.
Thank you.
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2022-09-21 15:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 14:59 [PATCH V2 0/3] drm/panel: Add NewVision NV3051D Panels Chris Morgan
2022-09-20 14:59 ` [PATCH V2 1/3] dt-bindings: vendor-prefixes: add NewVision vendor prefix Chris Morgan
2022-09-21 6:50 ` Krzysztof Kozlowski
2022-09-20 14:59 ` [PATCH V2 2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings Chris Morgan
2022-09-21 6:51 ` Krzysztof Kozlowski
2022-09-21 14:38 ` Chris Morgan
2022-09-21 15:21 ` Krzysztof Kozlowski
2022-09-21 15:50 ` Chris Morgan [this message]
2022-09-21 15:57 ` Krzysztof Kozlowski
2022-09-21 16:17 ` Chris Morgan
2022-09-21 7:01 ` Krzysztof Kozlowski
2022-09-24 17:07 ` Rob Herring
2022-09-24 17:51 ` Chris Morgan
2022-09-20 14:59 ` [PATCH V2 3/3] drm/panel: Add NewVision NV3051D MIPI-DSI LCD panel Chris Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR06MB53420E8B1245EDFCB7547C69A54F9@SN6PR06MB5342.namprd06.prod.outlook.com \
--to=macromorgan@hotmail.com \
--cc=airlied@linux.ie \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=macroalpha82@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).