From: Simon Ser <contact@emersion.fr>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Melissa Wen <melissa.srw@gmail.com>,
Haneen Mohammed <hamohammed.sa@gmail.com>,
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 1/3] drm/vkms: Set preferred depth correctly
Date: Fri, 16 Oct 2020 10:38:03 +0000 [thread overview]
Message-ID: <UQ4Aj6rvEUPvWt1cTYlNRLNoawlAIGTCnzstzNkRjZkv_NH-jIpnL7Xt9kGALYGc1M0RzZS0BcdvTb0V4przOwP8UBG_Xm6q2yRjCi3n-QE=@emersion.fr> (raw)
In-Reply-To: <20201009232156.3916879-1-daniel.vetter@ffwll.ch>
> The only thing we support is xrgb8888.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> Cc: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
> Cc: Melissa Wen <melissa.srw@gmail.com>
> Cc: Haneen Mohammed <hamohammed.sa@gmail.com>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> ---
> drivers/gpu/drm/vkms/vkms_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 726801ab44d4..eb4007443706 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -124,7 +124,7 @@ static int vkms_modeset_init(struct vkms_device *vkmsdev)
> dev->mode_config.max_height = YRES_MAX;
> dev->mode_config.cursor_width = 512;
> dev->mode_config.cursor_height = 512;
> - dev->mode_config.preferred_depth = 24;
> + dev->mode_config.preferred_depth = 32;
Are you sure xrgb8888's depth is 32 and not 24? Looking at drmdb [1], *all*
drivers set it to 24.
[1]: https://drmdb.emersion.fr/capabilities
> dev->mode_config.helper_private = &vkms_mode_config_helpers;
>
> return vkms_output_init(vkmsdev, 0);
> --
> 2.28.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-10-16 10:38 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 23:21 [PATCH 1/3] drm/vkms: Set preferred depth correctly Daniel Vetter
2020-10-09 23:21 ` [PATCH 2/3] drm/vkms: Switch to shmem helpers Daniel Vetter
2020-10-12 10:59 ` Chris Wilson
2020-10-12 11:20 ` Thomas Zimmermann
2020-10-12 11:22 ` Thomas Zimmermann
2020-10-12 12:41 ` Melissa Wen
2020-10-13 11:10 ` [PATCH] " Daniel Vetter
2020-10-09 23:21 ` [PATCH 3/3] drm/vkms: fbdev emulation support Daniel Vetter
2020-10-12 11:24 ` Thomas Zimmermann
2020-10-12 12:40 ` Neil Armstrong
2020-10-12 14:23 ` Daniel Vetter
2020-10-13 6:14 ` Pekka Paalanen
2020-10-13 7:53 ` Daniel Vetter
2020-10-13 10:19 ` Pekka Paalanen
2020-10-13 11:03 ` Daniel Vetter
2020-10-16 10:10 ` Melissa Wen
2020-10-20 8:34 ` Daniel Vetter
2020-10-12 11:08 ` [PATCH 1/3] drm/vkms: Set preferred depth correctly Thomas Zimmermann
2020-10-12 12:59 ` Melissa Wen
2020-10-15 21:39 ` Daniel Vetter
2020-10-16 10:18 ` Melissa Wen
2020-10-16 10:38 ` Simon Ser [this message]
2020-10-16 11:35 ` Daniel Vetter
2020-10-16 17:02 ` Melissa Wen
2020-10-16 17:05 ` Daniel Vetter
2020-10-17 8:39 ` Melissa Wen
2020-10-17 15:23 ` Daniel Vetter
2020-10-27 10:13 ` Thomas Zimmermann
2020-10-27 10:18 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='UQ4Aj6rvEUPvWt1cTYlNRLNoawlAIGTCnzstzNkRjZkv_NH-jIpnL7Xt9kGALYGc1M0RzZS0BcdvTb0V4przOwP8UBG_Xm6q2yRjCi3n-QE=@emersion.fr' \
--to=contact@emersion.fr \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hamohammed.sa@gmail.com \
--cc=melissa.srw@gmail.com \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).