From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Maxime Ripard <maxime@cerno.tech>
Cc: Chris Morgan <macromorgan@hotmail.com>,
Emma Anholt <emma@anholt.net>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
David Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org, Eric Anholt <eric@anholt.net>,
Joerg Quinten <aBUGSworstnightmare@gmail.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/7] media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI
Date: Tue, 29 Nov 2022 14:39:25 +0200 [thread overview]
Message-ID: <Y4X9fY71WYhf0Ty4@pendragon.ideasonboard.com> (raw)
In-Reply-To: <Y4X5o8tcQHbfa/cV@pendragon.ideasonboard.com>
On Tue, Nov 29, 2022 at 02:23:04PM +0200, Laurent Pinchart wrote:
> Hi Maxime and Chris,
>
> Thank you for the patch.
>
> On Thu, Oct 20, 2022 at 10:30:45AM +0200, Maxime Ripard wrote:
> > From: Chris Morgan <macromorgan@hotmail.com>
> >
> > Add the MEDIA_BUS_FMT_RGB565_1X24_CPADHI format used by the Geekworm
> > MZP280 panel for the Raspberry Pi.
> >
> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> > Signed-off-by: Maxime Ripard <maxime@cerno.tech>
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> > ---
> > .../userspace-api/media/v4l/subdev-formats.rst | 37 ++++++++++++++++++++++
> > include/uapi/linux/media-bus-format.h | 3 +-
> > 2 files changed, 39 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/userspace-api/media/v4l/subdev-formats.rst b/Documentation/userspace-api/media/v4l/subdev-formats.rst
> > index d21d532eee15..1e61c02aa788 100644
> > --- a/Documentation/userspace-api/media/v4l/subdev-formats.rst
> > +++ b/Documentation/userspace-api/media/v4l/subdev-formats.rst
> > @@ -986,6 +986,43 @@ The following tables list existing packed RGB formats.
> > - g\ :sub:`2`
> > - g\ :sub:`1`
> > - g\ :sub:`0`
> > + * .. _MEDIA-BUS-FMT-RGB565-1X24_CPADHI:
> > +
> > + - MEDIA_BUS_FMT_RGB565_1X24_CPADHI
> > + - 0x1022
> > + -
> > + -
> > + -
> > + -
> > + -
> > + -
> > + -
> > + -
> > + -
> > + - 0
> > + - 0
> > + - 0
> > + - r\ :sub:`4`
> > + - r\ :sub:`3`
> > + - r\ :sub:`2`
> > + - r\ :sub:`1`
> > + - r\ :sub:`0`
> > + - 0
> > + - 0
> > + - g\ :sub:`5`
> > + - g\ :sub:`4`
> > + - g\ :sub:`3`
> > + - g\ :sub:`2`
> > + - g\ :sub:`1`
> > + - g\ :sub:`0`
> > + - 0
> > + - 0
> > + - 0
> > + - b\ :sub:`4`
> > + - b\ :sub:`3`
> > + - b\ :sub:`2`
> > + - b\ :sub:`1`
> > + - b\ :sub:`0`
> > * .. _MEDIA-BUS-FMT-RGB666-1X24_CPADHI:
> >
> > - MEDIA_BUS_FMT_RGB666_1X24_CPADHI
> > diff --git a/include/uapi/linux/media-bus-format.h b/include/uapi/linux/media-bus-format.h
> > index ec3323dbb927..b0a945eb7040 100644
> > --- a/include/uapi/linux/media-bus-format.h
> > +++ b/include/uapi/linux/media-bus-format.h
> > @@ -34,13 +34,14 @@
> >
> > #define MEDIA_BUS_FMT_FIXED 0x0001
> >
> > -/* RGB - next is 0x1022 */
> > +/* RGB - next is 0x1023 */
> > #define MEDIA_BUS_FMT_RGB444_1X12 0x1016
> > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001
> > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002
> > #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_BE 0x1003
> > #define MEDIA_BUS_FMT_RGB555_2X8_PADHI_LE 0x1004
> > #define MEDIA_BUS_FMT_RGB565_1X16 0x1017
> > +#define MEDIA_BUS_FMT_RGB565_1X24_CPADHI 0x1022
I spoke a bit too fast, this should go down with the other 1X24 formats.
The Rb tag still holds with this fixed.
> > #define MEDIA_BUS_FMT_BGR565_2X8_BE 0x1005
> > #define MEDIA_BUS_FMT_BGR565_2X8_LE 0x1006
> > #define MEDIA_BUS_FMT_RGB565_2X8_BE 0x1007
> >
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2022-11-29 12:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 8:30 [PATCH v2 0/7] drm/vc4: dpi: Various improvements Maxime Ripard
2022-10-20 8:30 ` [PATCH v2 1/7] media: uapi: add MEDIA_BUS_FMT_RGB565_1X24_CPADHI Maxime Ripard
2022-11-29 12:22 ` Laurent Pinchart
2022-11-29 12:39 ` Laurent Pinchart [this message]
2022-10-20 8:30 ` [PATCH v2 2/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X18 Maxime Ripard
2022-11-29 12:26 ` Laurent Pinchart
2022-10-20 8:30 ` [PATCH v2 3/7] media: uapi: add MEDIA_BUS_FMT_BGR666_1X24_CPADHI Maxime Ripard
2022-11-29 12:38 ` Laurent Pinchart
2022-11-29 14:52 ` Jörg Quinten
2022-11-29 18:37 ` Laurent Pinchart
2022-10-20 8:30 ` [PATCH v2 4/7] drm/vc4: dpi: Support RGB565 format Maxime Ripard
2022-10-20 8:30 ` [PATCH v2 5/7] drm/vc4: dpi: Support BGR666 formats Maxime Ripard
2022-10-20 8:30 ` [PATCH v2 6/7] drm/vc4: dpi: Change the default DPI format to being 18bpp, not 24 Maxime Ripard
2022-10-20 8:30 ` [PATCH v2 7/7] drm/vc4: dpi: Fix format mapping for RGB565 Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4X9fY71WYhf0Ty4@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=aBUGSworstnightmare@gmail.com \
--cc=airlied@linux.ie \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emma@anholt.net \
--cc=eric@anholt.net \
--cc=linux-kernel@vger.kernel.org \
--cc=macromorgan@hotmail.com \
--cc=maxime@cerno.tech \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).