dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jessica Yu <jeyu@kernel.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Petr Mladek <pmladek@suse.com>,
	Joe Lawrence <joe.lawrence@redhat.com>,
	Andrew Donnellan <ajd@linux.ibm.com>,
	linux-kbuild@vger.kernel.org, David Airlie <airlied@linux.ie>,
	Masahiro Yamada <masahiroy@kernel.org>,
	Jiri Kosina <jikos@kernel.org>,
	linux-kernel@vger.kernel.org, live-patching@vger.kernel.org,
	Michal Marek <michal.lkml@markovi.net>,
	dri-devel@lists.freedesktop.org,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Josh Poimboeuf <jpoimboe@redhat.com>,
	Frederic Barrat <fbarrat@linux.ibm.com>,
	Miroslav Benes <mbenes@suse.cz>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: module loader dead code removal and cleanups v3
Date: Tue, 2 Feb 2021 15:37:04 +0100	[thread overview]
Message-ID: <YBljkDgMFcqKcH8H@gunter> (raw)
In-Reply-To: <20210202121334.1361503-1-hch@lst.de>

+++ Christoph Hellwig [02/02/21 13:13 +0100]:
>Hi all,
>
>this series removes support for long term unused export types and
>cleans up various loose ends in the module loader.
>
>Changes since v2:
> - clean up klp_find_object_symbol a bit
> - remove the now unused module_assert_mutex helper
>
>Changes since v1:
> - move struct symsearch to module.c
> - rework drm to not call find_module at all
> - allow RCU-sched locking for find_module
> - keep find_module as a public API instead of module_loaded
> - update a few comments and commit logs

Thanks Christoph for cleaning up all that aged cruft, and thanks everyone
for the reviews.

I was curious about EXPORT_SYMBOL_GPL_FUTURE and EXPORT_UNUSED_SYMBOL
variants, and found that most of that stuff was introduced between
2006 - 2008. All the of the unused symbols were removed and gpl future
symbols were converted to gpl quite a long time ago, and I don't
believe these export types have been used ever since. So I
think it's safe to retire those export types now.

The patchset looks good so far. After Miroslav's comments are
addressed, I'll wait an extra day or two in case there are more
comments before queueing them onto modules-next. I can take the first
two patches as well provided the acks are there (I think patch 2 is
missing Daniel Vetter's ack from v1 of the series, but I'll add that
back in).

Thanks,

Jessica
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2021-02-02 14:37 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20210202121334.1361503-1-hch@lst.de>
     [not found] ` <20210202121334.1361503-7-hch@lst.de>
2021-02-02 14:03   ` [PATCH 06/13] kallsyms: only build {, module_}kallsyms_on_each_symbol when required Miroslav Benes
     [not found] ` <20210202121334.1361503-8-hch@lst.de>
2021-02-02 14:04   ` [PATCH 07/13] module: mark module_mutex static Miroslav Benes
     [not found] ` <20210202121334.1361503-9-hch@lst.de>
2021-02-02 14:04   ` [PATCH 08/13] module: remove each_symbol_in_section Miroslav Benes
     [not found] ` <20210202121334.1361503-10-hch@lst.de>
2021-02-02 14:04   ` [PATCH 09/13] module: merge each_symbol_section into find_symbol Miroslav Benes
     [not found] ` <20210202121334.1361503-11-hch@lst.de>
2021-02-02 14:07   ` [PATCH 10/13] module: pass struct find_symbol_args to find_symbol Miroslav Benes
     [not found]     ` <20210203090418.GA7833@lst.de>
2021-02-03  9:31       ` Miroslav Benes
     [not found] ` <20210202121334.1361503-12-hch@lst.de>
2021-02-02 14:10   ` [PATCH 11/13] module: move struct symsearch to module.c Miroslav Benes
     [not found] ` <20210202121334.1361503-13-hch@lst.de>
2021-02-02 14:12   ` [PATCH 12/13] module: remove EXPORT_SYMBOL_GPL_FUTURE Miroslav Benes
     [not found] ` <20210202121334.1361503-14-hch@lst.de>
2021-02-02 14:21   ` [PATCH 13/13] module: remove EXPORT_UNUSED_SYMBOL* Miroslav Benes
2021-02-02 14:37 ` Jessica Yu [this message]
2021-02-02 17:38   ` module loader dead code removal and cleanups v3 Emil Velikov
     [not found] ` <20210202121334.1361503-6-hch@lst.de>
2021-02-03  8:58   ` [PATCH 05/13] kallsyms: refactor {,module_}kallsyms_on_each_symbol Petr Mladek
     [not found] ` <20210202121334.1361503-2-hch@lst.de>
2021-02-04 10:44   ` [PATCH 01/13] powerpc/powernv: remove get_cxl_module Michael Ellerman
2021-02-08 11:36 ` module loader dead code removal and cleanups v3 Jessica Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YBljkDgMFcqKcH8H@gunter \
    --to=jeyu@kernel.org \
    --cc=airlied@linux.ie \
    --cc=ajd@linux.ibm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fbarrat@linux.ibm.com \
    --cc=hch@lst.de \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=live-patching@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=mbenes@suse.cz \
    --cc=michal.lkml@markovi.net \
    --cc=pmladek@suse.com \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).