From: Daniel Vetter <daniel@ffwll.ch>
To: DRI Development <dri-devel@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH 00/11] dma_fence critical sections annotations for atomic
Date: Tue, 23 Feb 2021 12:54:44 +0100 [thread overview]
Message-ID: <YDTtBAolax5Gxp2k@phenom.ffwll.local> (raw)
In-Reply-To: <20210121152959.1725404-1-daniel.vetter@ffwll.ch>
On Thu, Jan 21, 2021 at 04:29:48PM +0100, Daniel Vetter wrote:
> Hi all,
>
> Finally gotten around to refreshing all the various fence anntotions I've
> hast last summer. Or well parts of it:
>
> - entire amdgpu and drm/scheduler annotations postponed for now, because
> there's way too many splats in there that need some work
>
> - in recent patches I've seen quite a few dma_resv_lock or kmalloc in
> atomic_commit_tail, which doesn't work in full generality with the rules
> for dma_fences we've discussed and encoded in lockdep. These annotations
> should catch stuff like this.
>
> Review comments and testing very much welcome.
I pulled in the acked/reviewed patches into drm-misc-next. Testing (enable
lockdep, test your driver) and review on the others very much appreciated.
Thanks, Daniel
>
> Cheers, Daniel
>
> Daniel Vetter (11):
> drm/atomic-helper: Add dma-fence annotations
> drm/vkms: Annotate vblank timer
> drm/vblank: Annotate with dma-fence signalling section
> drm/komeda: Annotate dma-fence critical section in commit path
> drm/malidp: Annotate dma-fence critical section in commit path
> drm/atmel: Use drm_atomic_helper_commit
> drm/imx: Annotate dma-fence critical section in commit path
> drm/omapdrm: Annotate dma-fence critical section in commit path
> drm/rcar-du: Annotate dma-fence critical section in commit path
> drm/tegra: Annotate dma-fence critical section in commit path
> drm/tidss: Annotate dma-fence critical section in commit path
>
> .../gpu/drm/arm/display/komeda/komeda_kms.c | 3 +
> drivers/gpu/drm/arm/malidp_drv.c | 3 +
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 107 +-----------------
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.h | 7 --
> drivers/gpu/drm/drm_atomic_helper.c | 16 +++
> drivers/gpu/drm/drm_vblank.c | 8 +-
> drivers/gpu/drm/imx/imx-drm-core.c | 2 +
> drivers/gpu/drm/omapdrm/omap_drv.c | 9 +-
> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +
> drivers/gpu/drm/tegra/drm.c | 3 +
> drivers/gpu/drm/tidss/tidss_kms.c | 4 +
> drivers/gpu/drm/vkms/vkms_crtc.c | 8 +-
> 12 files changed, 54 insertions(+), 118 deletions(-)
>
> --
> 2.30.0
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2021-02-23 11:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-21 15:29 [PATCH 00/11] dma_fence critical sections annotations for atomic Daniel Vetter
2021-01-21 15:29 ` [PATCH 01/11] drm/atomic-helper: Add dma-fence annotations Daniel Vetter
2021-01-21 15:29 ` [PATCH 02/11] drm/vkms: Annotate vblank timer Daniel Vetter
2021-01-21 15:29 ` [PATCH 03/11] drm/vblank: Annotate with dma-fence signalling section Daniel Vetter
2021-01-21 15:29 ` [PATCH 04/11] drm/komeda: Annotate dma-fence critical section in commit path Daniel Vetter
2021-01-21 15:29 ` [PATCH 05/11] drm/malidp: " Daniel Vetter
2021-01-21 15:29 ` [PATCH 06/11] drm/atmel: Use drm_atomic_helper_commit Daniel Vetter
2021-01-21 15:29 ` [PATCH 07/11] drm/imx: Annotate dma-fence critical section in commit path Daniel Vetter
2021-01-21 15:29 ` [PATCH 08/11] drm/omapdrm: " Daniel Vetter
2021-01-21 15:29 ` [PATCH 09/11] drm/rcar-du: " Daniel Vetter
2021-01-21 15:29 ` [PATCH 10/11] drm/tegra: " Daniel Vetter
2021-02-05 18:09 ` Thierry Reding
2021-01-21 15:29 ` [PATCH 11/11] drm/tidss: " Daniel Vetter
2021-05-27 12:15 ` Tomi Valkeinen
2021-06-22 16:31 ` Daniel Vetter
2021-02-23 11:54 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDTtBAolax5Gxp2k@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).