From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1B5DC433C1 for ; Fri, 19 Mar 2021 19:16:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8745F61962 for ; Fri, 19 Mar 2021 19:16:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8745F61962 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AAB276EA9B; Fri, 19 Mar 2021 19:16:37 +0000 (UTC) Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by gabe.freedesktop.org (Postfix) with ESMTPS id 90A1B6EA9A for ; Fri, 19 Mar 2021 19:16:36 +0000 (UTC) Received: by mail-wr1-x436.google.com with SMTP id 61so10167103wrm.12 for ; Fri, 19 Mar 2021 12:16:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=sfSbjAxCLutq3EQbKsACb8JZ8n+mbDV5OuF+cMaKNb8=; b=EZ3xsTpvjtT2iTkFCneXoXl7inkPvn5P1YRYiM38MrJYDgKIosC4/hWpUhcaf+slEW LZ1PLLyPTJ922u+q0XjjshX1al1zudoKdd4sg0m690qXwpwRmPaOAt85ZRbSxfuW3tf7 Z1HRbTIsWcqNUC5V8/h6jWARwj2RXPQKLqhJ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=sfSbjAxCLutq3EQbKsACb8JZ8n+mbDV5OuF+cMaKNb8=; b=UiZFugeNW8UueBzBt3rzHCreVXbaN19OIjH5ioF4oSwKf8AOgnY3bAEn31ydJMb3J5 LKLc9/Olwamd3xtykIhZX2UeyGPNZFtQG9BZqAZNSVdEJeqKpLXFn8L2rLyy+lHXGPAv L0fdshEAvmtA4MY86R+hgdvFK4VNt0BZk/KcOJvl7wfKWdDiF1vCeWYQcOrD1cIZnGxc eGgSJIEYwRsTTzTwku1/cPqg1MzDt8QstEw39G4kHgZbTJiCOFTnn1WZeDvqkHKM1V1x +eHbEUXKUn75WW1SzNBRTtBDINuVQ4XMXK4JKqlAXhGOPODaZLP82a67bY8RbW/tWhjT 1W+A== X-Gm-Message-State: AOAM5315ujsCTW1wrWBs4gdhtHlEIHGP+WIcMWa+AlCNnn6863vuimOm gsKGj86BXI2ZEzkL3MVDnEx6iQ== X-Google-Smtp-Source: ABdhPJyTLS3ilL7s2EzDPT2zc+xkuwu6pOWld1Rcrp1G7k52acY6v3fM39t4meeqtqgv3SiM3BXbaw== X-Received: by 2002:a05:6000:223:: with SMTP id l3mr4824239wrz.5.1616181395344; Fri, 19 Mar 2021 12:16:35 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id l21sm7777078wmg.41.2021.03.19.12.16.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 Mar 2021 12:16:34 -0700 (PDT) Date: Fri, 19 Mar 2021 20:16:33 +0100 From: Daniel Vetter To: John Hubbard Subject: Re: [PATCH 2/2] drm/etnaviv: User FOLL_LONGTERM in userptr Message-ID: References: <20210301095254.1946084-1-daniel.vetter@ffwll.ch> <20210301095254.1946084-2-daniel.vetter@ffwll.ch> <1aabe37b-d79b-8456-641d-aaf8fe2c330d@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1aabe37b-d79b-8456-641d-aaf8fe2c330d@nvidia.com> X-Operating-System: Linux phenom 5.7.0-1-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , etnaviv@lists.freedesktop.org, DRI Development , Russell King , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Mar 01, 2021 at 02:26:01AM -0800, John Hubbard wrote: > On 3/1/21 01:52, Daniel Vetter wrote: > > There's no mmu notifier or anything like that, releasing this pin is > > entirely up to userspace. Hence FOLL_LONGTERM. > > > > No cc: stable for this patch since a lot of the infrastructure around > > FOLL_LONGETRM (like not allowing it for pages currently sitting in > > ^FOLL_LONGTERM > > > ZONE_MOVEABLE before they're migrated) is still being worked on. So > > not big benefits yet. > > Yes. Great write-up, that's very clear, and it's exactly where we're at. > > Reviewed-by: John Hubbard Both patches pushed to drm-misc-fixes. 2nd one maybe not required there, but easier due to conflicts. Thanks for the review. -Daniel > > > thanks, > -- > John Hubbard > NVIDIA > > > > > Cc: John Hubbard > > Signed-off-by: Daniel Vetter > > Cc: Lucas Stach > > Cc: Russell King > > Cc: Christian Gmeiner > > Cc: etnaviv@lists.freedesktop.org > > --- > > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > > index a9e696d05b33..db69f19ab5bc 100644 > > --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c > > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > > @@ -689,7 +689,8 @@ static int etnaviv_gem_userptr_get_pages(struct etnaviv_gem_object *etnaviv_obj) > > struct page **pages = pvec + pinned; > > ret = pin_user_pages_fast(ptr, num_pages, > > - FOLL_WRITE | FOLL_FORCE, pages); > > + FOLL_WRITE | FOLL_FORCE | FOLL_LONGTERM, > > + pages); > > if (ret < 0) { > > unpin_user_pages(pvec, pinned); > > kvfree(pvec); > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel