From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE1ACC43600 for ; Thu, 1 Apr 2021 09:54:55 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99EC161057 for ; Thu, 1 Apr 2021 09:54:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99EC161057 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5976C6E3BB; Thu, 1 Apr 2021 09:54:54 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7AF926E3AE; Thu, 1 Apr 2021 09:54:52 +0000 (UTC) IronPort-SDR: R7sf4ydNN060oDZbU5u8BePP+bJ33TXYfPdl2Lb+paQIwYTIZahfvOgtWhHIjys0VTW/emVqwz Zli141yIt0sA== X-IronPort-AV: E=McAfee;i="6000,8403,9940"; a="172240407" X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="172240407" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 02:54:48 -0700 IronPort-SDR: Cn18i/9EiiFRc6ci1qc4fxMgu2cYt/3M+8GYdaM7vfwDD4Sr6BgXRpnQ2Kb6iG19GyTkXiwyZL nEWS6m0zjfRw== X-IronPort-AV: E=Sophos;i="5.81,296,1610438400"; d="scan'208";a="607543759" Received: from nbisnik-mobl.amr.corp.intel.com (HELO intel.com) ([10.212.6.247]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Apr 2021 02:54:46 -0700 Date: Thu, 1 Apr 2021 05:54:45 -0400 From: Rodrigo Vivi To: Tvrtko Ursulin Subject: Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check actual RC6 status Message-ID: References: <20210331101850.2582027-1-tvrtko.ursulin@linux.intel.com> <2c813fb2-6836-1888-f606-25ef1321a366@linux.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <2c813fb2-6836-1888-f606-25ef1321a366@linux.intel.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Intel-gfx@lists.freedesktop.org, Eero T Tamminen , dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Apr 01, 2021 at 10:38:11AM +0100, Tvrtko Ursulin wrote: > > On 01/04/2021 10:19, Rodrigo Vivi wrote: > > On Wed, Mar 31, 2021 at 11:18:50AM +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > RC6 support cannot be simply established by looking at the static device > > > HAS_RC6() flag. There are cases which disable RC6 at driver load time so > > > use the status of those check when deciding whether to enumerate the rc6 > > > counter. > > > > > > Signed-off-by: Tvrtko Ursulin > > > Reported-by: Eero T Tamminen > > > --- > > > drivers/gpu/drm/i915/i915_pmu.c | 4 +++- > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c > > > index 41651ac255fa..a75cd1db320b 100644 > > > --- a/drivers/gpu/drm/i915/i915_pmu.c > > > +++ b/drivers/gpu/drm/i915/i915_pmu.c > > > @@ -476,6 +476,8 @@ engine_event_status(struct intel_engine_cs *engine, > > > static int > > > config_status(struct drm_i915_private *i915, u64 config) > > > { > > > + struct intel_gt *gt = &i915->gt; > > > + > > > switch (config) { > > > case I915_PMU_ACTUAL_FREQUENCY: > > > if (IS_VALLEYVIEW(i915) || IS_CHERRYVIEW(i915)) > > > @@ -489,7 +491,7 @@ config_status(struct drm_i915_private *i915, u64 config) > > > case I915_PMU_INTERRUPTS: > > > break; > > > case I915_PMU_RC6_RESIDENCY: > > > - if (!HAS_RC6(i915)) > > > + if (!gt->rc6.supported) > > > > Is this really going to remove any confusion? > > Right now it is there but with residency 0, but after this change the event is > > not there anymore so I wonder if we are not just changing to a different kind > > of confusion on users. > > I think it is possible to argue both ways. > > 1) > HAS_RC6 means hardware has RC6 so if we view PMU as very low level we can > say always export it. > > If i915 had to turn it off (rc6->supported == false) due firmware or GVT-g, > then we could say reporting zero RC6 is accurate in that sense. Only the > reason "why it is zero" is missing for PMU users. > > 2) > Or if we go with this patch we could say that presence of the PMU metric > means RC6 is active and enabled, while absence means it is either not > supported due platform (or firmware) or how the platform is getting used > (GVT-g). > yeap, these 2 cases described well my mental conflict... > So I think patch is a bit better. I don't see it is adding more confusion. As I said on the other patch I have no strong position on which is better, but if you and Eero feel that this works better for the current case, let's do it... > > > > > > return -ENODEV; > > > > would a different return help somehow? > > Like distinguishing between not theoretically possible to support on this > GPU, versus not active? Perhaps.. suggest an errno? :) ENODATA? or EIDRM? But only if it helps somehow... otherwise don't bother and move with this as is: Reviewed-by: Rodrigo Vivi > > Regards, > > Tvrtko > > > > > > break; > > > case I915_PMU_SOFTWARE_GT_AWAKE_TIME: > > > -- > > > 2.27.0 > > > > > > _______________________________________________ > > > Intel-gfx mailing list > > > Intel-gfx@lists.freedesktop.org > > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel